From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <bruce.richardson@intel.com>
Received: from mga06.intel.com (mga06.intel.com [134.134.136.31])
 by dpdk.org (Postfix) with ESMTP id DC439FF4;
 Mon,  8 May 2017 11:46:51 +0200 (CEST)
Received: from fmsmga006.fm.intel.com ([10.253.24.20])
 by orsmga104.jf.intel.com with ESMTP; 08 May 2017 02:46:50 -0700
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.38,309,1491289200"; d="scan'208";a="99032938"
Received: from bricha3-mobl3.ger.corp.intel.com ([10.237.221.42])
 by fmsmga006.fm.intel.com with SMTP; 08 May 2017 02:46:48 -0700
Received: by  (sSMTP sendmail emulation); Mon, 08 May 2017 10:46:47 +0100
Date: Mon, 8 May 2017 10:46:47 +0100
From: Bruce Richardson <bruce.richardson@intel.com>
To: Tiwei Bie <tiwei.bie@intel.com>
Cc: dev@dpdk.org, stable@dpdk.org
Message-ID: <20170508094646.GA34348@bricha3-MOBL3.ger.corp.intel.com>
References: <20170507133334.16219-1-tiwei.bie@intel.com>
 <20170507133334.16219-2-tiwei.bie@intel.com>
 <20170508085501.GB47408@bricha3-MOBL3.ger.corp.intel.com>
 <20170508090736.GA11935@debian>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20170508090736.GA11935@debian>
Organization: Intel Research and =?iso-8859-1?Q?De=ACvel?=
 =?iso-8859-1?Q?opment?= Ireland Ltd.
User-Agent: Mutt/1.8.0 (2017-02-23)
Subject: Re: [dpdk-dev] [PATCH 1/2] eal/bsd: fix ioport write operation
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Mon, 08 May 2017 09:46:52 -0000

On Mon, May 08, 2017 at 05:07:36PM +0800, Tiwei Bie wrote:
> On Mon, May 08, 2017 at 09:55:01AM +0100, Bruce Richardson wrote:
> > On Sun, May 07, 2017 at 01:33:33PM +0000, Tiwei Bie wrote:
> > > The first param of out*() on FreeBSD is port, and the second one is
> > > data. But they are reversed in DPDK. This patch fixes it.
> > > 
> > > Fixes: 756ce64b1ecd ("eal: introduce PCI ioport API") Cc:
> > > stable@dpdk.org
> > > 
> > > Signed-off-by: Tiwei Bie <tiwei.bie@intel.com> ---
> > How was this bug discovered so that we can verify that it is fixed?.  Is
> > this in use by virtio or was it just discovered via code inspection?
> > 
> 
> The virtio PMD in legacy mode doesn't work FreeBSD, and I tried to
> fix this issue. And then I found this bug.
> 
> Best regards,
> Tiwei Bie

Acked-by: Bruce Richardson <bruce.richardson@intel.com>