From: Olivier Matz <olivier.matz@6wind.com>
To: Ferruh Yigit <ferruh.yigit@intel.com>
Cc: Tetsuya Mukawa <mtetsuyah@gmail.com>, dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH] net/null: do not touch mbuf next or nb segs on Rx
Date: Tue, 9 May 2017 09:24:37 +0200 [thread overview]
Message-ID: <20170509092437.652bac1c@platinum> (raw)
In-Reply-To: <20170504154358.40122-1-ferruh.yigit@intel.com>
On Thu, 4 May 2017 16:43:58 +0100, Ferruh Yigit <ferruh.yigit@intel.com> wrote:
> mbuf next and nb_segs fields already have the default values when get
> from mempool, no need to update them in PMD.
>
> See: 8f094a9ac5d7 ("mbuf: set mbuf fields while in pool")
>
> Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com>
> ---
> Cc: Olivier Matz <olivier.matz@6wind.com>
> ---
> drivers/net/null/rte_eth_null.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/drivers/net/null/rte_eth_null.c b/drivers/net/null/rte_eth_null.c
> index abf3ec7..2c94339 100644
> --- a/drivers/net/null/rte_eth_null.c
> +++ b/drivers/net/null/rte_eth_null.c
> @@ -139,8 +139,6 @@ eth_null_copy_rx(void *q, struct rte_mbuf **bufs, uint16_t nb_bufs)
> packet_size);
> bufs[i]->data_len = (uint16_t)packet_size;
> bufs[i]->pkt_len = packet_size;
> - bufs[i]->nb_segs = 1;
> - bufs[i]->next = NULL;
> bufs[i]->port = h->internals->port_id;
> }
>
Reviewed-by: Olivier Matz <olivier.matz@6wind.com>
next prev parent reply other threads:[~2017-05-09 7:24 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-04 15:43 Ferruh Yigit
2017-05-09 7:24 ` Olivier Matz [this message]
2017-05-12 11:59 ` Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170509092437.652bac1c@platinum \
--to=olivier.matz@6wind.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=mtetsuyah@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).