From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f42.google.com (mail-wm0-f42.google.com [74.125.82.42]) by dpdk.org (Postfix) with ESMTP id 9924B2C3F for ; Tue, 9 May 2017 09:24:39 +0200 (CEST) Received: by mail-wm0-f42.google.com with SMTP id u65so601331wmu.1 for ; Tue, 09 May 2017 00:24:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=wP9cGVSy4n8U1zfRGWuIEv4tR0Uk21Wl4jp36ZFkuME=; b=jFJGWgpH/GrXfe0RSwMe9/k25bmnlEmfBJbIm2renK/oYnCbpxB08xogGGZtl7TVXc 9TgF5S2IVrFmBIVKVEzGTeHJP5OXNuIJJnpczJvoGPGFL0WmxcjFFiel5wEaf+YJKqzu xw17idLDXYPOYHsVoZwbhtvnVt6XOpBDGCQB5GCwrt1lkLC/9eTKvPX/HlGvU4tPd39u GvgJ3J8I94C/UtPXevamZHPclApGaBvDI6xazsIQPlafVS3oi8+KoNjf9Blnd45uO1Ym PpF+ZcPXzfq7Ed+d1pbFeJZFsaGneROuQ0AwWBXTm2+YaMvkByeQd5qBZyqUAwuE5YVH ZdWg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=wP9cGVSy4n8U1zfRGWuIEv4tR0Uk21Wl4jp36ZFkuME=; b=pD1H48b1/vWOFbGUDvd2fgK8PHKNpyXDOm38tEwf+GQEQiHYGcVqlDuyNLpe7cFKsV jvJwgwSDWd+wK3MHBWhd7oqEjHcM5DGXOiOQiOrtiSn/ZgwnmFg/VNlkcji0YHaKuxQ2 xRopF1t5ORvKcT+Tjv6gakykhpYRShJdp+9g2mm+998nVLVY9buCzw/IUcq8FPdLLFMe 9VvqaGXP1ToVhjeyg2VwwdGJhJSS0XZonS2XbNUgMXKf16bpplToPIHP9uw+w8IsLip1 si8D+TIe2alNZvc/yQOTGJco57oFhDYAxZpftimIc0mdrOyuGrx/L9D+1nLHMoop6cxK mYyA== X-Gm-Message-State: AODbwcA9ozNnAFsyyCw/9wvxCp9mFQCxZXh2ra6TFvkjApnZJMnR6j0j ce9jDD/8sP92jc4+ X-Received: by 10.28.12.211 with SMTP id 202mr63338wmm.32.1494314679251; Tue, 09 May 2017 00:24:39 -0700 (PDT) Received: from platinum (2a01cb0c03c651000226b0fffeed02fc.ipv6.abo.wanadoo.fr. [2a01:cb0c:3c6:5100:226:b0ff:feed:2fc]) by smtp.gmail.com with ESMTPSA id 4sm16459602wry.31.2017.05.09.00.24.39 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 09 May 2017 00:24:39 -0700 (PDT) Date: Tue, 9 May 2017 09:24:37 +0200 From: Olivier Matz To: Ferruh Yigit Cc: Tetsuya Mukawa , dev@dpdk.org Message-ID: <20170509092437.652bac1c@platinum> In-Reply-To: <20170504154358.40122-1-ferruh.yigit@intel.com> References: <20170504154358.40122-1-ferruh.yigit@intel.com> X-Mailer: Claws Mail 3.14.1 (GTK+ 2.24.31; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH] net/null: do not touch mbuf next or nb segs on Rx X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 09 May 2017 07:24:39 -0000 On Thu, 4 May 2017 16:43:58 +0100, Ferruh Yigit wrote: > mbuf next and nb_segs fields already have the default values when get > from mempool, no need to update them in PMD. > > See: 8f094a9ac5d7 ("mbuf: set mbuf fields while in pool") > > Signed-off-by: Ferruh Yigit > --- > Cc: Olivier Matz > --- > drivers/net/null/rte_eth_null.c | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/drivers/net/null/rte_eth_null.c b/drivers/net/null/rte_eth_null.c > index abf3ec7..2c94339 100644 > --- a/drivers/net/null/rte_eth_null.c > +++ b/drivers/net/null/rte_eth_null.c > @@ -139,8 +139,6 @@ eth_null_copy_rx(void *q, struct rte_mbuf **bufs, uint16_t nb_bufs) > packet_size); > bufs[i]->data_len = (uint16_t)packet_size; > bufs[i]->pkt_len = packet_size; > - bufs[i]->nb_segs = 1; > - bufs[i]->next = NULL; > bufs[i]->port = h->internals->port_id; > } > Reviewed-by: Olivier Matz