From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from NAM03-CO1-obe.outbound.protection.outlook.com (mail-co1nam03on0049.outbound.protection.outlook.com [104.47.40.49]) by dpdk.org (Postfix) with ESMTP id 15C9B4A63 for ; Tue, 9 May 2017 19:04:36 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=CAVIUMNETWORKS.onmicrosoft.com; s=selector1-cavium-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=yu+My+77Llm94jYbtsLyg/AIKwsJK6fjiAgHU/xlnDc=; b=ZyBUFD17TGv19G7Tmo3rGcjGJ0WfBogCXRw+rFAtiOgki4N6Hfk1qIRywD4CVfSpF668oVwa0BPjlHd4zsxvnBC+gz1EWDSTb0HtNS7eomNMpCxfNp2O6xndJG3+lcq2h+V8Rkg5zzQ0W3Wd/KA+iMISXD4GCV/nXX0UYmc4ZPU= Authentication-Results: 6wind.com; dkim=none (message not signed) header.d=none;6wind.com; dmarc=none action=none header.from=caviumnetworks.com; Received: from jerin (106.200.244.106) by BLUPR0701MB1714.namprd07.prod.outlook.com (10.163.85.140) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1075.11; Tue, 9 May 2017 17:04:30 +0000 Date: Tue, 9 May 2017 22:34:13 +0530 From: Jerin Jacob To: Adrien Mazarguil Cc: Shahaf Shuler , Konstantin Ananyev , Olivier Matz , Tomasz Kulasek , dev@dpdk.org Message-ID: <20170509170412.GA14727@jerin> References: <20170501065812.5185-1-shahafs@mellanox.com> <20170509134004.GO16218@6wind.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170509134004.GO16218@6wind.com> User-Agent: Mutt/1.8.2 (2017-04-18) X-Originating-IP: [106.200.244.106] X-ClientProxiedBy: BMXPR01CA0031.INDPRD01.PROD.OUTLOOK.COM (10.174.214.17) To BLUPR0701MB1714.namprd07.prod.outlook.com (10.163.85.140) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 065b800a-a833-4796-9f39-08d496fd76d1 X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(22001)(201703131423075)(201703031133081); SRVR:BLUPR0701MB1714; X-Microsoft-Exchange-Diagnostics: 1; BLUPR0701MB1714; 3:hxkwHnUDEhUNuZw6WASuHjyaiKrdSEL8tv40LI9VdA5CwMDbmNLoLY977RbKvrTeCuH2TRpv/MeZK05jq+tScR8CkO9Ss7SQIZnTX9lmexdrN2Az3e6qf8FNrpI6+T716tnb/e6ttmno+Fyoe4U6dRsFfgER/+Uigku2oswb+Vg7rRhOVurYqbX2xxa12FCRA0zqq/DlrLDWO0O2FyIyVPYntjwZThhlOD913GKXP3mGCElx6kmdjX5JOyir3/cS2Asp+Me4B+KtM8UFmUEe7yrEdoK1Ewx7n6u4i6s59t4v/JqShJ6uXFA1ltDpg7g/m0omfl0vb6I2UhKbZTvCuw==; 25:En8BUjMmRKRr8bNeAYVHVbCj07c045GKu5/NhivezGSahTG/VI4/NbgycB0CWRZha/TnQ9cq7hyoodDyHH949m1MGI4DWh1gxCrZSKi1Ogb9oahZfSQR735w3FjLwEKpzMYMB2thU5+KkGS/0YQNxnh2oofvj6kx3nSXdcSV4Jegc16+8qJAK19083KJiZqDHO5XdZiUFF4xStnVH5KSLAk6XGLMtuTGU+g/h4+Q9n6zuJSnnUumqx37rkKod2hr17I7FaXirjO7lYxaKOrjQcn+ycl7CGWwRU0eNFOj9OqiH+Mr4BB9ZOSoLqpdSPmce5t1isDtTU38HEXTPuVhx+ajtDnlrPktKAZU0cFMJTx48TYQUu/H5/fjibiZScwsLXrOVvgimj/G+gRpPHcLfMVBFXnxwd4FgYxIjxMo7+VXuywP/3OB0QfkowTAEwiNjy4kuuWfxmcrakzSNyKnySfBr1hX1xJujfThl1/Q+Qk= X-Microsoft-Exchange-Diagnostics: 1; BLUPR0701MB1714; 31:8EBQbTi3hk8h5Owv1539mK6ZxF9cb0mS2ztZmlX3qSyyXbxPCSxed9PfULGY/qmyVj6klgYlEdiwgUD3b4dlH/yAgPD4mrfmkbV040jRYN6E4htsdV+XbOLNplMzdM/qLCnNbapIbxxgKRgobxAnfDDee07FzUDkqaXj7Wcd2Ylwm8fXrWSXxdZAa8yR73GlQqYKp9aAv6CGZuSdBXYMXYo7FWFF6Zx61xYJSgne5OTez5vJik6IzV564MfZFoBSJiViCsjg48eUehpJj9o/Iw==; 20:ZDRkP4aUT+5cp/rb2WGlhNRd854BGU7Yfdk+auBIXsenZPFbEN+Uh6DsYi52G8hrctHhGGa+Fd88s7z4LbgKOhWBr3wmWltmlEeHD8HblNhFpA94KinWcYOaZYtLLwepb7Y3JnRhXti/S/OicnS3W06TSarhoJRtgcf8y/5RxVqTRwF/rL0BlRdrx/js3C8gVZsc6h4zBdxgFwfHZRmzTSmu/aFkZoSBIwWq3lz/4NLV/ObYVrlt6iohn6D/A21sjiPSnBNqK7Z0v7SXwtgIroBdgtUqynzOhyhLwXkVcCBZVGPBHBrz3JVQi2RF3XU4UPBapKOwnyyt+7jR6+BDVu9RsvGp5Su2/cCFrJvX+Pgmr6O0qwLLp9OgATyBjVvflip9JnzPfITlARJ8wXjAjFVfz02zsVLDBScgZIRVQIDhd3X8HH28qN2iipjTrsl1pbWdBNO5KpFXYLpXdkdR8pmNORv3ZiZoqQ08pv7V0jvRU+fQHjm3HfeKeJrGMCl9wHZ6v9D5wt8b1oqOGUdc7QCW7Q3hZMiNSt3BgtqqeiLmGNdexaCplRQI3usE2v7rphFU9DZ755vPdyDVuRp7rJqzat5PEYlvWgVSWrg3Mh0= X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(278428928389397)(228905959029699); X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(6040450)(601004)(2401047)(8121501046)(5005006)(10201501046)(93006095)(3002001)(6041248)(20161123558100)(20161123560025)(20161123555025)(20161123564025)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(20161123562025)(6072148); SRVR:BLUPR0701MB1714; BCL:0; PCL:0; RULEID:; SRVR:BLUPR0701MB1714; X-Microsoft-Exchange-Diagnostics: 1; BLUPR0701MB1714; 4:0yXBAZwKvegqg8r37lUqReuxBoy6wsb3tbBuec2EDlCcfIMaIYleDE6gWhx0qNF3PRmzab0eSlt+GRZvi24FrD93HEIH7/7agCsDI9Kfi62mrsGKe6dcROwNchq6T+P28genK2dn7nLcokV376EWJZPc1z1SaszM/tncS61kGUKUDZBO6Liugm0YctDZGiP3bQsStfYLEjEK8Y5skxGbGzCHQJchZQVz3QCzjH1ukXe3EROK4miCtabjd646fpj5h3XjcGxjOpv1VrBixMJb8e+qzCJF3IYlH4Kx3xcozi80rZ+A2x7TtIol4MHVgIMcgNFWQt90hr+z6twYKTVL0aqvmy5ytIqk0UcurtGXBrCjdnu0axN22ZcqjRtJ9uHbe2fFPtE6oZH3PvhJJ6+xSQ9x3wczVq3amdc8LKl1EBwcFMQNdFfqyqbqla31QU+fE0xO5JNdrRaDGxV57I+d5xtCXDSDvVk8uVdAzjA0LuCyF7zYfXWES2KYR6MfNas4n9yQiNFgs+huJh7bgC0K6xOEpF252oYDc/qjq1RIHnTfrSJ61neZFwP0+OEhR7ofAmr4PCKEQ2LLi8JK7XHxFgvrlrDOgL7XB9q2vc5cP8gB+b7memd0neHEEMH4DfHr1fVg1xdJCCSjoSKJdKMFVOcqDZXYMkocPMxkxyMpv9rUDnTcPeQXIj05+pYbA9loEN9/Le/Kcz8E2o556JQn+yvpFAJOil4X+DBVebKmRpq4735VBgqwRMQNRzq6NOcKFPU6di53gq+ApSEtyGnns95bUrApO6Y6uYxgYYV83njtb8mJaQMIo9PcoYulec7vhCPuajyZbVy6I5CXU+kSxg== X-Forefront-PRVS: 0302D4F392 X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(4630300001)(6009001)(39410400002)(39850400002)(39450400003)(39400400002)(39840400002)(24454002)(13464003)(6116002)(54906002)(33716001)(54356999)(50986999)(3846002)(23726003)(42186005)(561944003)(8676002)(47776003)(81166006)(25786009)(42882006)(1076002)(6916009)(5660300001)(76176999)(66066001)(6666003)(2950100002)(6246003)(4326008)(7736002)(229853002)(305945005)(478600001)(110136004)(38730400002)(5009440100003)(53936002)(83506001)(2906002)(33656002)(6496005)(189998001)(50466002)(55016002)(9686003)(4001350100001)(18370500001); DIR:OUT; SFP:1101; SCL:1; SRVR:BLUPR0701MB1714; H:jerin; FPR:; SPF:None; MLV:sfv; LANG:en; X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; BLUPR0701MB1714; 23:8thJK8O5XqTqpRb3DutzTHMiULRSE7705vjJQKg?= =?us-ascii?Q?7GCd5Z2mSB+oBSMADuWoLS0+00TdKAbGPbmqCB2jNaMTcbHNvFyBA9H+65ec?= =?us-ascii?Q?RHh8LXIIcAeL4FjazU6pbrFMqYs0+wCeDP6y1H3oPE6F1ALYDo7TA/5Yx0kg?= =?us-ascii?Q?EDaUzha+IBJTn3Zps++E+o+QrFZAppS7bIl8AkjrvLdocHUb3VsqjI1yqL/S?= =?us-ascii?Q?8502wl50aMHUjyiGPR2YwNB52L1sWTtyzJsi9zLEhyxWTq+CvFxbWxgqKivm?= =?us-ascii?Q?tpaHgucr/Vc7uJ+iAvndU4bdRLv6gGZiJNT5odFSZ3//qzdGYQy8Z1usbu+y?= =?us-ascii?Q?tHnTuJgVJie2uLMjiRkR6+g5BCqK7r6kBpqj2ZcIFVwbSXy19fD/kI7Uw9V2?= =?us-ascii?Q?WNUpzBGPiikT+VDzyzGZfj/JcH/j0In+c3RY4giLMIHMi7wO09JV902JA/bd?= =?us-ascii?Q?LQ5Awl9mW5Fuo2SAwCw+4Xa/cUgz702SuHsFEQ+EKHzenMcj5KnTIiU6CtTi?= =?us-ascii?Q?jvccqbrRXpPIkkSfasl/GOv/zpwS+OpZHoYmEa9gbMy8Bkg41ZLEBVjfeJgK?= =?us-ascii?Q?Mm8juU+Hee+O+BXiogoabBOgcz12nAz/2azmotW4RKBDGHB3IFAj2Obkq7Fg?= =?us-ascii?Q?tE/PaR7n2mb1KsiKX6YKPNkDGx3nh4x2dnVDOBeBjld5XDHlseGz9MQnihMy?= =?us-ascii?Q?QQ228G4t5fqtp88A+ZZ3eNhPAuvax7QE23LbrnbJurmIsOjQfzcRVW1WWKt1?= =?us-ascii?Q?G07cYtI8vx2y3+vdzSR5xwgK9tPFNDjJb4vnU4k5f/code4rU41ZF1sW/RGK?= =?us-ascii?Q?BobtYvloRl3hQopS488u7ITqwksUe8VX9PW9tJVdw9uzjb9aRwW3ffP80Bkz?= =?us-ascii?Q?DiElG/6as5dk+f2kBCoakN745sOSZvDho4YmaJp1gnDvNCqO7ySVsGs6Og06?= =?us-ascii?Q?/uJ/w9f7ldZI5v7F8IURWdLopxacligzVwbdxEUobXu2GfQkviDua/eZVdaN?= =?us-ascii?Q?rLNGX/VQTiUExQGWATlwBUsYjWx88iWO3vgz/b7/J5eLWZdsayZJn72kyOue?= =?us-ascii?Q?PEKztf1cnXKwHYKyDVPemKcmZ2O5CJnkL3jMfJRjTh4Nb9rgxCHm/MlsoCmR?= =?us-ascii?Q?X5/64r9wLM70UGOh18JlR+ibG6QfW/adIfkNEHYteSu70998rVp3iqoJGen4?= =?us-ascii?Q?Qw35SU4tsK9XnI+CpSoVqCePbCu11YHroK5z76Dx81D35+9tqjS9d8fXWish?= =?us-ascii?Q?6uSLvN+wEE1/citued4Y=3D?= X-Microsoft-Exchange-Diagnostics: 1; BLUPR0701MB1714; 6:tg00xGW7t/WscX7M0q4jzCcf6NE6qia2rzTeXHNKZTCT3RDXnmLRcSL84ZvJJl6ACoG0vbhcNJ4QQqpnCF3lfqHCNztXMHjstDpvROMAlp24vrv20GMhJNH9GBxZLm5heLX+hrFlYz3/lDqMlExEp/LVIpwIUdhLztJPTzGuXT2yRtJ4XzGzUcUS51HejlJCwUq5HPqHYOSEaB1RFSLzumQeLDOeLXtUlmZ4sGuMqe7SY2isRn8cdANpcE7F1ksu+raLd/y+BV4d87HV7coDomRmryRgUQUeLRgmbsve3bCXY4ZT+9T94A7QX5W6pqgTF6A78Cu1gX2rI3Z1iazFpjtK1is4bGA0p3a0zubHIyQgupu6hZBRjRaPnXxWEK/TNFNelmWwZ4fA8zoUBpsPsuzDXDfM2x7y7OaIKWLUJF4gvftwRXX5XvsZYIWTpLh0lPBHDpzJWhXTkffJiWUr+BVrkCnycsHwXe873W6BR8pA3Wi1gnlAw+F0WvG8DcLn1AHhVq/l1DiXauwfxUv5qA==; 5:+e9bhK2e2X3tNdFFTIJ9pdcFOO5WHpuOlU1R6peGn2L/QotsZEjZRwtWefW+xPiklpKhlekog+5/LkAmH0jISA1qNSaY2xvCYr3xfO1QL/xZAZ3GHww3lWplNd9GwU8a3iArTJPkCbk+XnbC9PEOHQ==; 24:Xi049A0fEkmpoRcOvju1rCi+U7KTs5iXoHyqRfm4CjNhW4xjKQu3Rp8O6zmhvRbzp9jkdTw4KNhJG9l3LI8zKjhGRfTB6/qK9zhrOJCtzRg= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1; BLUPR0701MB1714; 7:XVTY6IGiklXxPBwZYEBDx6Uj8ba+jNQrlhw7dNDcm5x8+MiX5j+rgdKLfqq6khPa09+alLcWjE5jyaUzHE6gTPaBUOypzHUqbBYASheOzciQVqEzb0Z9Wtjzfyf34PzBDZFf9L42NmXl8VF4F74P9pMnPVII9dN9ptrFrCklgblTI2ptGjzjyys0Qqh+bPASPgnGntqN2f4bwf8xW+61frUYmYUf8ABNl6MZHBqG5cx2NaE2FzzbOtchTqkMxOnvxFt45xQ8pNYWNCq9EGwt5PGY6RS6NhA90d5XQvgOj96ecyohfe8CmLcYHY2f/e7hBGTYU9MvJ1N1xP7hKJTgsQ== X-OriginatorOrg: caviumnetworks.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 May 2017 17:04:30.8194 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: BLUPR0701MB1714 Subject: Re: [dpdk-dev] [PATCH] doc: announce ABI change on ethdev X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 09 May 2017 17:04:36 -0000 -----Original Message----- > Date: Tue, 9 May 2017 15:40:04 +0200 > From: Adrien Mazarguil > To: Shahaf Shuler , Konstantin Ananyev > , Olivier Matz , > Tomasz Kulasek > Cc: dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCH] doc: announce ABI change on ethdev > > On Mon, May 01, 2017 at 09:58:12AM +0300, Shahaf Shuler wrote: > > This is an ABI change notice for DPDK 17.08 in librte_ether > > about changes in rte_eth_txmode structure. > > > > Currently Tx offloads are enabled by default, and can be disabled > > using ETH_TXQ_FLAGS_NO* flags. This behaviour is not consistent with > > the Rx side where the Rx offloads are disabled by default and enabled > > according to bit field in rte_eth_rxmode structure. > > > > The proposal is to disable the Tx offloads by default, and provide > > a way for the application to enable them in rte_eth_txmode structure. > > Besides of making the Tx configuration API more consistent for > > applications, PMDs will be able to provide a better out of the > > box performance. > > Finally, as part of the work, the ETH_TXQ_FLAGS_NO* will > > be superseded as well. > > > > Signed-off-by: Shahaf Shuler > > Basically, TX mbuf flags like TSO and checksum offloads won't have to be > honored by PMDs unless applications request them first while configuring the > device, just like RX offloads. > > Considering more and more TX offloads will be added over time, I do not > think expecting them all to be enabled by default is sane. There will always > be an associated software cost in PMDs, and this solution allows > applications to selectively enable them as needed for maximum performance. > > Konstantin/Olivier/Tomasz, I do not want to resume the thread about > tx_prepare(), however this could provide an alternative means to benefit > from improved performance when applications do not need TSO (or any other > offload for that matter), while adding consistency to device configuration. > > What's your opinion? > > In any case I'm fine with this change: > > Acked-by: Adrien Mazarguil Acked-by: Jerin Jacob