From: Bruce Richardson <bruce.richardson@intel.com>
To: Shahaf Shuler <shahafs@mellanox.com>
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH] doc: announce ABI change on ethdev
Date: Wed, 10 May 2017 15:29:24 +0100 [thread overview]
Message-ID: <20170510142924.GA51072@bricha3-MOBL3.ger.corp.intel.com> (raw)
In-Reply-To: <20170501065812.5185-1-shahafs@mellanox.com>
On Mon, May 01, 2017 at 09:58:12AM +0300, Shahaf Shuler wrote:
> This is an ABI change notice for DPDK 17.08 in librte_ether
> about changes in rte_eth_txmode structure.
>
> Currently Tx offloads are enabled by default, and can be disabled
> using ETH_TXQ_FLAGS_NO* flags. This behaviour is not consistent with
> the Rx side where the Rx offloads are disabled by default and enabled
> according to bit field in rte_eth_rxmode structure.
>
> The proposal is to disable the Tx offloads by default, and provide
> a way for the application to enable them in rte_eth_txmode structure.
> Besides of making the Tx configuration API more consistent for
> applications, PMDs will be able to provide a better out of the
> box performance.
> Finally, as part of the work, the ETH_TXQ_FLAGS_NO* will
> be superseded as well.
>
> Signed-off-by: Shahaf Shuler <shahafs@mellanox.com>
> ---
Sounds a great idea to me. I never liked the fact that offloads were on
by default and needed to be explicitly disabled.
Acked-by: Bruce Richardson <bruce.richardson@intel.com>
prev parent reply other threads:[~2017-05-10 14:29 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-01 6:58 Shahaf Shuler
2017-05-09 10:24 ` Shahaf Shuler
2017-05-09 13:40 ` Adrien Mazarguil
2017-05-09 17:04 ` Jerin Jacob
2017-05-10 23:17 ` Thomas Monjalon
2017-05-09 13:49 ` Ferruh Yigit
2017-05-09 16:55 ` Shahaf Shuler
2017-05-09 18:09 ` Ananyev, Konstantin
2017-05-10 14:29 ` Bruce Richardson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170510142924.GA51072@bricha3-MOBL3.ger.corp.intel.com \
--to=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=shahafs@mellanox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).