From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by dpdk.org (Postfix) with ESMTP id 08D9114EC for ; Wed, 10 May 2017 16:29:28 +0200 (CEST) Received: from orsmga002.jf.intel.com ([10.7.209.21]) by fmsmga105.fm.intel.com with ESMTP; 10 May 2017 07:29:28 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.38,319,1491289200"; d="scan'208";a="85147323" Received: from bricha3-mobl3.ger.corp.intel.com ([10.237.221.42]) by orsmga002.jf.intel.com with SMTP; 10 May 2017 07:29:25 -0700 Received: by (sSMTP sendmail emulation); Wed, 10 May 2017 15:29:25 +0100 Date: Wed, 10 May 2017 15:29:24 +0100 From: Bruce Richardson To: Shahaf Shuler Cc: dev@dpdk.org Message-ID: <20170510142924.GA51072@bricha3-MOBL3.ger.corp.intel.com> References: <20170501065812.5185-1-shahafs@mellanox.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170501065812.5185-1-shahafs@mellanox.com> Organization: Intel Research and =?iso-8859-1?Q?De=ACvel?= =?iso-8859-1?Q?opment?= Ireland Ltd. User-Agent: Mutt/1.8.0 (2017-02-23) Subject: Re: [dpdk-dev] [PATCH] doc: announce ABI change on ethdev X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 10 May 2017 14:29:29 -0000 On Mon, May 01, 2017 at 09:58:12AM +0300, Shahaf Shuler wrote: > This is an ABI change notice for DPDK 17.08 in librte_ether > about changes in rte_eth_txmode structure. > > Currently Tx offloads are enabled by default, and can be disabled > using ETH_TXQ_FLAGS_NO* flags. This behaviour is not consistent with > the Rx side where the Rx offloads are disabled by default and enabled > according to bit field in rte_eth_rxmode structure. > > The proposal is to disable the Tx offloads by default, and provide > a way for the application to enable them in rte_eth_txmode structure. > Besides of making the Tx configuration API more consistent for > applications, PMDs will be able to provide a better out of the > box performance. > Finally, as part of the work, the ETH_TXQ_FLAGS_NO* will > be superseded as well. > > Signed-off-by: Shahaf Shuler > --- Sounds a great idea to me. I never liked the fact that offloads were on by default and needed to be explicitly disabled. Acked-by: Bruce Richardson