From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from NAM02-SN1-obe.outbound.protection.outlook.com (mail-sn1nam02on0087.outbound.protection.outlook.com [104.47.36.87]) by dpdk.org (Postfix) with ESMTP id D16C82952 for ; Thu, 11 May 2017 07:22:18 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=CAVIUMNETWORKS.onmicrosoft.com; s=selector1-cavium-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=TVuDgdmRoTt4I0AuA2y+MKGW7WL13y2Y0KCBP+4cbUI=; b=MmUXTCdKOdGiJD9E55h9ssd8ipXhFaJn6lRv8IM0o6XULaSw3/nj4HciJhERbgyVE8iuZQhQZEzUk3BAT7pONga8zulPTQAQsHq9uo25uxQOSvTtJipfaDcQ8eI5g5z/hscudHt+e7uCQuYplzNfD3z6M5DRfX0Mee3qwJBI3Bk= Authentication-Results: caviumnetworks.com; dkim=none (message not signed) header.d=none;caviumnetworks.com; dmarc=none action=none header.from=caviumnetworks.com; Received: from jerin (111.93.218.67) by BLUPR0701MB1716.namprd07.prod.outlook.com (10.163.85.142) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1075.11; Thu, 11 May 2017 05:22:11 +0000 Date: Thu, 11 May 2017 10:51:49 +0530 From: Jerin Jacob To: Ashwin Sekhar T K Cc: thomas@monjalon.net, maciej.czekaj@caviumnetworks.com, viktorin@rehivetech.com, jianbo.liu@linaro.org, bruce.richardson@intel.com, pablo.de.lara.guarch@intel.com, konstantin.ananyev@intel.com, dev@dpdk.org Message-ID: <20170511052148.GA3057@jerin> References: <20170510101643.30556-1-ashwin.sekhar@caviumnetworks.com> <20170510101643.30556-2-ashwin.sekhar@caviumnetworks.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170510101643.30556-2-ashwin.sekhar@caviumnetworks.com> User-Agent: Mutt/1.8.2 (2017-04-18) X-Originating-IP: [111.93.218.67] X-ClientProxiedBy: PN1PR01CA0023.INDPRD01.PROD.OUTLOOK.COM (10.164.137.30) To BLUPR0701MB1716.namprd07.prod.outlook.com (10.163.85.142) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: da108083-a930-4cb4-b397-08d4982db025 X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(22001)(201703131423075)(201703031133081); SRVR:BLUPR0701MB1716; X-Microsoft-Exchange-Diagnostics: 1; BLUPR0701MB1716; 3:1elb4toKRydUtN7EdC63Ni1PAopZ6mbD57By6ihv5XDvYsetmFKx0ozY0vvwhGSzRWG963YO5SNKXHgI+R0C1fRqOIWn2gJa4TcfWOGNcxc0Gzgc3lePz/UZeZtwx/NGl3P8s9P1TP42rGiVGssw8CS4A71e3ihQ3bksSRqw/o7wWrnZHAiJ8GelgDEvhyDyQ2jPQyfbYwrwgL2m3mLFwj0DxmGDRIg+xoxC5gxtCGSVxavVrSozJMY2NN1rl4JNw73XVdyE+stneyMAGh+yb9L8GxMEWykIkvmsKyn/nt9VUxk0DEVeWZV8hQAKDrBioHgo2qbmiwWPtCmWNm0oHQ==; 25:9qgc1uvnlERNUPfZVyqKTQafLM3WW4dW17Gbamb+cczksEWC/GRCyeBNdtmZxmY1mTGPJF+FBlh66mE3IRlhAaCp3DEgZoQe6b5dHWoe+Xum1quZI/k1qvJwidtJG4lHQv/aQm7HftKGRmxrvbgsSFTcuE8qDHnPtz3u31ii5OLi2twThuWFznnYUMhes4lGI+orpFl/3J3wkibYPmJuO61mvbkRSqa2KNMUVaHBir8OOghEBMZMUftm32f+FkzZcmeqVvjTd3qJNTM3oii78MOdOEKM4g5fUcWsDfp6SvkUUdDMIgoN+7nvIlYBeO6mxeJwiXUHwkQYhKK31MZtDX1qqYQrOStDYFZWYBK6JZRKa0uvy3jKMINJBZQE+T3wDiVvqn8+YEIp7geB2zlXrI2D4LMDsvf1xpyeIaghbJxcaGFwZS2IFajZ1jZn9UgS7+v4+IESpXmi+wmJCy+kLMWWDPWleI0taJ3FjsCmnKU= X-Microsoft-Exchange-Diagnostics: 1; BLUPR0701MB1716; 31:P8icYWzZT9BQvJiARr5lww619ZudARrDVCnF9XDiBNsocL1rVEvjPpcA9H1pVy4cj23evMeeErf/OnhAym1YYYEEveR+8D2kYOt8F3AK3vNYOBa2yVSQkI1fp53yNQYz/7N8Bof+quDYyKbS8TeU0nM/W14/tvz5TlEoYBiRUG8Ed+H2RupBdoRft3rjROzb5wjhDGmmk5F+AqfKHU9rgjkr6SVSKS0cavBEe+N6ayY=; 20:fTxBKbLVaWW1/vlMLuWhi4Otu6ry74eAPh4PiTYLx8E8KK86jsedkWt+o/4piMBPlK1/TlZ4zOiqSfmoNWODXgtipMOsOYhOCFPJFf98WUOyn4uG/ziW/i0Gg9LvAQzx3WtkaYq5UkFapkP15qw3ZKNzND4Pgnj6CuUzCZ3MK5rGn+2EOoNki+YDjMwk1VT9/SIN0aTysCcgmZ8ODeT8u8WbbG4Oy9Zg61Qp/uXNXmABTfdsgQaCsoZEKM6CgzcbPysY8qlcsK4AHo4ImRWWL7Or/svwgNS/ZONBd+LJnZVY2BB0msEeS5wyzED+AialjbKlWLB8iQOENw2epBDT5pXJ5WcYDtmMTNT1RDhWB1O1VYhMejYdCdos/H7wB5mltXXGWYGt6/KFXkp1/VxE0CXnIlqSx0WMfNd5PR8dyP9zQAWJBHXBmVNvZmq+0ElkiaOy0qWB5Pr9bpfSkUM3z25I4pj9mfrty9KJH1jHZMC9+mxMSB2rm2AKJpPDLgkAN1CWXD0tvuSWJrucGe2k7dTFr4z8iAGfoHVAxw/owlVc5caugxwZv9+tmmxI8Ybnx3OxOUGVkZDnrvV0n4gwNKI9p2iZ0IGPWAO6mdKtOPk= X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(228905959029699); X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(6040450)(601004)(2401047)(5005006)(8121501046)(3002001)(93006095)(10201501046)(6041248)(20161123558100)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(20161123555025)(20161123560025)(20161123562025)(20161123564025)(6072148); SRVR:BLUPR0701MB1716; BCL:0; PCL:0; RULEID:; SRVR:BLUPR0701MB1716; X-Microsoft-Exchange-Diagnostics: 1; BLUPR0701MB1716; 4:/wvT9nz1+8p7bEn5M/bV4TyVW+AYgBf0UJzVzyeE4K96DUeWTDjLX5qXlokGWclwxDqWYa0BPyYan3iHrHIl3nzb4JEsNMlXHzfFqllzqDjFZwyJTcSuI6IYxn0D7kridA05VDsib8F0eA0nTjzwF0EqMszQ8xN8HsZ0NdnsSYg4SK4gElBW3+JW11AyYDMBcdlXJvBQ1KwUbAn25xkrdgw37BOuFjeukjhSTrlPWIwW7uB0V9I3QXxKtBC+qlJxEqKGT/nY1YdMCXHUlwcJClfJ78uKJ6y6oNH2uyEFmPtd77ml/8Tvq5Sem/1uyArM4I4/mz1fhsUIQn/lJpW6knQdpQe93Old4I4aePOWXzlPw/b4AsLlKYrP6NHJ/NNnVNM6jKHLXKUaAPQz78srqk6c6AyuNzaKld8REbgN5xPoWn7XqFjsvNpyq61At5jnKYHjRrSgUFZjwk5tFDyKN1GyNm56UsELL3DUCiN6mDIqyXMXMWvt1DoZ8kO60AbJm+xOaYhLqAHKKrdUrRjKM3MnEeqa95wwbxe6fu7QEoBoHSACT6Ak0H0yhGWPguj9GSrv5Jjdnn5gY4O0q6hfj9IoHn62LHz+AxomWehW8q0K5D142COpxIIiHLd1pbQpe359nxlBEM7lw6qARnryf2E5GFpkai8RYTfpS1ytXdf7LB04obF9nIDPGavXTH4ugA2N6B2SUph9d20ZCv8seQ1zdr2IKQQ3VG/fgQpCU/hEDk3m3ncNQgeMjdu8vXJmNYC7riq/wNWrRTMDNFZWCDlTGOVxiNHYytO1Xe5NTXa5oQt3bXB1xQt270CXdu4p X-Forefront-PRVS: 0304E36CA3 X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(4630300001)(6009001)(39410400002)(39400400002)(39850400002)(39450400003)(39840400002)(13464003)(33656002)(33716001)(6862004)(50986999)(6116002)(4001350100001)(50466002)(76176999)(54356999)(3846002)(2906002)(1076002)(23726003)(8676002)(81166006)(6666003)(42882006)(42186005)(229853002)(5660300001)(2950100002)(6636002)(66066001)(47776003)(6246003)(38730400002)(478600001)(110136004)(5009440100003)(6496005)(55016002)(53936002)(9686003)(305945005)(7736002)(189998001)(72206003)(4326008)(25786009)(83506001)(18370500001)(32563001); DIR:OUT; SFP:1101; SCL:1; SRVR:BLUPR0701MB1716; H:jerin; FPR:; SPF:None; MLV:sfv; LANG:en; X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; BLUPR0701MB1716; 23:5DGPd1lpLcsGY9CIXNEOt51DAHNgnKjoMscPar7?= =?us-ascii?Q?gDNri6HvDmUwYcK9jejBvJUWMYPHXNQGDf7am1jmb1L35n92AvIjPjetX00c?= =?us-ascii?Q?R+aP1j1lQV/0KXF8cPwrcXdBI+2//iFH7+Y0uQAqPmC2SVikozMiTUC8jy//?= =?us-ascii?Q?bs2P0dh3m0SUnGCp1gjSanuN7J3W0F/W66+p4MyRDrHyBleCQ6ZalcgUqywa?= =?us-ascii?Q?2hcNz42Bzl9rczeu0oKE33n4S3vNJ/k1zjMhwgbR4PN5SbBYMnQNqoP80ASD?= =?us-ascii?Q?B4WDMRDbhcM2PBQ20o2Ai14IZ6Rg7RE9egnnI8Y2PIe5mWOZZU0wGRjx3K7a?= =?us-ascii?Q?rlfqRkmIE5UZOKy1I9ZhiPYTJZfmE6qdppCOP/gjiwB3/AJMSpi5/Ce3kpw8?= =?us-ascii?Q?YbAbgjO3bzfAOkN+qbB6ZcP3LT7tou7KFoex7bN88XvCBGL81fsAwizXHVgd?= =?us-ascii?Q?x7xPZ2IkcLNkS1VFkuJRe72xbKNOlKEiJQjrfOzhzkjkSqp64eMeihqeKetV?= =?us-ascii?Q?vhbp5YSrG84DEmvDXGCRaO62TH9o+6BhBDQRdTaqscBBbloQI62ViWOrXxJu?= =?us-ascii?Q?1JLLhtKrv5oWUh+2frUwRCtDiDJamN1I4ZVU9W96XSOBltbTcY/07fr0E5/y?= =?us-ascii?Q?iTdX3Kl0Fn60QtrxAeIE916nAs0b7vbRZmxkYVGBf4Y1XHufexcKYdcZRSEI?= =?us-ascii?Q?I1jdSmmT+UDq4vrasvN3UaAjlHTjc7u+7S3WhOuXNjY7OHRGcGVadvMPcr7Y?= =?us-ascii?Q?7WHXzAtrT3JVRXSk5hP2C7x/ZnrhKuSkCF1YHZkiTa5/wVzcc4SKhIwQFsfA?= =?us-ascii?Q?nrVeoj/BayhTELXhH8oz4TR2LFep8QL6OwNe0UBg4PiFjBuMmjceau+H56IT?= =?us-ascii?Q?PeS6Z8Y4Bnr91lYzQv+1uNZBbX1BSYFwULwhBR4fmDcsJkUfQBn6RIxX6bMN?= =?us-ascii?Q?oJlmgZRwTjD+z0Gzj/os7WlQCFOuDWD44asybLpFNuZNhFSdbFPH2na9EDam?= =?us-ascii?Q?vx01T844h42yDSmDQt4Q/frcqd1P2r8IiJyxxPYPVpxgcHGx9kFZ8/GjiQ+h?= =?us-ascii?Q?wd9CrQUxPUismIlZmArZmaFyU6PvGFYEANQl5jMu8FIji+1/liJ66HVA84Zd?= =?us-ascii?Q?82qhiluIA09Ta9eNcOZev20rg/1BezfDDj7plKU9t3dioA+NxUcYk4sm6U5U?= =?us-ascii?Q?rffH4bE7tPt8o6QPL4od4d92acPXV6864k4CMa04oVwuYPkAiGM4ZFFy7JUc?= =?us-ascii?Q?TCjBnm1zxStJI69A1qp0=3D?= X-Microsoft-Exchange-Diagnostics: 1; BLUPR0701MB1716; 6:rLsrJ/9uqbKcQLXLaBmGgRmBujU5gM5qG5tkAWceauHUTj1iKa7IcwDNR69bNWfD20pcPXiq4PFSkJhhPi3gGPxG5CFV/bxiTEhUpZM1y+GE5g3TTHt1Ku3f9jjg+H27bWV3cG40iPSh60qhh3YmV+TYp1Tc4JrCXOQcInaoLreCu8XfG+4jV5jjwzmN6eqwXC6so6CELp+pI88JZCK1wVipCtbuVK7CeZ/dyhwEKfQ294cHSrRyCPE1yQoPxMa5aLLpQgBD3zRDhENTs6GIOIjcrdgX/x4sIGa2e8Ci/lxgEODNmSU8yceSIGmuezNYpahKCO+zePVCNlUjcM9WIWytzJC1dmf7hN44g1j68LwXouhOBOC9tGGI5GgJs7NM+yZBF27te2Xb8RnXar5Yx1NdC+CasF+JGK6JjB6Qwrz9hhbe4pF1G5739hTekWgcjEv37o8MsTFJI9kQV5FSt66fbLHvo9NAZglthCvmVDHdFPlmd4BTdivqSlYCWPrzUT7sTRIGdcihkwAuQjNtUA==; 5:AJFikGKI3miUi+pexoHY7iEWCZZI+YB03XmPez+tXVFKCp5eaiitIX9f4piOfiUjYXZdwSZtAB6mTaBtuVn4v9qnbEiVkf6T+lQo7sf58ifrz4bIsskkLIBhb2B9SnZIrcSw6aNNYG054c17v7WZLQ==; 24:jjKAF6wI5GCWPZghvihMQTETtfPtKDodmB4kVAjICDHoDKlNbIFcsDQyCD5ehfwis8z83d4KUZ2lzJ1pr4qIto6agH2+mKlblPKIad072S4= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1; BLUPR0701MB1716; 7:ObjIvZFLHD235t7hlikxxEHH1kTKXhuVVlCZY9Pi8uZgDfhWeQgbufSdrVkEfpXrMIXziJAV4CguL/3g3e+AFO1T9OEIQyAVOZaNxlr1mGE4ckmx9RvFmC2E3sdhmPpdbOwYyQH0E527enTnylROPMfMqntnz2jygUQSdPSgphRBUbL/Do1MbBRgbfJLzR/hmgahJvGKw/HBjDlt6xkVNT2HdpFvCEr1c8ZXITLLJbqlOwqwjVis+LPm0I9CnjBhH0/v7YZ6l0zXL8vDsqXsHS60djRE6W5BuxG0HuAGH5PwKSdRQ4w1Aw9658w5GYAdoITATv5wMWIzcnDxXG4PhA== X-OriginatorOrg: caviumnetworks.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 May 2017 05:22:11.7933 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: BLUPR0701MB1716 Subject: Re: [dpdk-dev] [PATCH 1/6] hash: compile armv8a CRC32 support conditionally X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 11 May 2017 05:22:20 -0000 -----Original Message----- > Date: Wed, 10 May 2017 03:16:38 -0700 > From: Ashwin Sekhar T K > To: thomas@monjalon.net, jerin.jacob@caviumnetworks.com, > maciej.czekaj@caviumnetworks.com, viktorin@rehivetech.com, > jianbo.liu@linaro.org, bruce.richardson@intel.com, > pablo.de.lara.guarch@intel.com, konstantin.ananyev@intel.com > Cc: dev@dpdk.org, Ashwin Sekhar T K > Subject: [dpdk-dev] [PATCH 1/6] hash: compile armv8a CRC32 support > conditionally > X-Mailer: git-send-email 2.13.0.rc1 > > Compile the armv8a CRC32 support only if the machine > has the CRC extensions i.e if RTE_MACHINE_CPUFLAG_CRC32 > is defined. > > Removed the .arch assembly directives as these are no > more necessary. > > Signed-off-by: Ashwin Sekhar T K Reviewed-by: Jerin Jacob > --- > lib/librte_hash/Makefile | 2 ++ > lib/librte_hash/rte_crc_arm64.h | 4 ---- > lib/librte_hash/rte_hash_crc.h | 2 +- > 3 files changed, 3 insertions(+), 5 deletions(-) > > diff --git a/lib/librte_hash/Makefile b/lib/librte_hash/Makefile > index d856aa26d..9cf13a045 100644 > --- a/lib/librte_hash/Makefile > +++ b/lib/librte_hash/Makefile > @@ -49,8 +49,10 @@ SRCS-$(CONFIG_RTE_LIBRTE_HASH) += rte_fbk_hash.c > SYMLINK-$(CONFIG_RTE_LIBRTE_HASH)-include := rte_hash.h > SYMLINK-$(CONFIG_RTE_LIBRTE_HASH)-include += rte_hash_crc.h > ifeq ($(CONFIG_RTE_ARCH_ARM64),y) > +ifneq ($(findstring RTE_MACHINE_CPUFLAG_CRC32,$(CFLAGS)),) > SYMLINK-$(CONFIG_RTE_LIBRTE_HASH)-include += rte_crc_arm64.h > endif > +endif > SYMLINK-$(CONFIG_RTE_LIBRTE_HASH)-include += rte_jhash.h > SYMLINK-$(CONFIG_RTE_LIBRTE_HASH)-include += rte_thash.h > SYMLINK-$(CONFIG_RTE_LIBRTE_HASH)-include += rte_fbk_hash.h > diff --git a/lib/librte_hash/rte_crc_arm64.h b/lib/librte_hash/rte_crc_arm64.h > index 7dd6334ee..91cde3b9d 100644 > --- a/lib/librte_hash/rte_crc_arm64.h > +++ b/lib/librte_hash/rte_crc_arm64.h > @@ -52,7 +52,6 @@ extern "C" { > static inline uint32_t > crc32c_arm64_u8(uint8_t data, uint32_t init_val) > { > - asm(".arch armv8-a+crc"); > __asm__ volatile( > "crc32cb %w[crc], %w[crc], %w[value]" > : [crc] "+r" (init_val) > @@ -63,7 +62,6 @@ crc32c_arm64_u8(uint8_t data, uint32_t init_val) > static inline uint32_t > crc32c_arm64_u16(uint16_t data, uint32_t init_val) > { > - asm(".arch armv8-a+crc"); > __asm__ volatile( > "crc32ch %w[crc], %w[crc], %w[value]" > : [crc] "+r" (init_val) > @@ -74,7 +72,6 @@ crc32c_arm64_u16(uint16_t data, uint32_t init_val) > static inline uint32_t > crc32c_arm64_u32(uint32_t data, uint32_t init_val) > { > - asm(".arch armv8-a+crc"); > __asm__ volatile( > "crc32cw %w[crc], %w[crc], %w[value]" > : [crc] "+r" (init_val) > @@ -85,7 +82,6 @@ crc32c_arm64_u32(uint32_t data, uint32_t init_val) > static inline uint32_t > crc32c_arm64_u64(uint64_t data, uint32_t init_val) > { > - asm(".arch armv8-a+crc"); > __asm__ volatile( > "crc32cx %w[crc], %w[crc], %x[value]" > : [crc] "+r" (init_val) > diff --git a/lib/librte_hash/rte_hash_crc.h b/lib/librte_hash/rte_hash_crc.h > index 0f485b854..808a082c5 100644 > --- a/lib/librte_hash/rte_hash_crc.h > +++ b/lib/librte_hash/rte_hash_crc.h > @@ -453,7 +453,7 @@ crc32c_sse42_u64(uint64_t data, uint64_t init_val) > > static uint8_t crc32_alg = CRC32_SW; > > -#if defined(RTE_ARCH_ARM64) > +#if defined(RTE_ARCH_ARM64) && defined(RTE_MACHINE_CPUFLAG_CRC32) > #include "rte_crc_arm64.h" > #else > > -- > 2.13.0.rc1 >