From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail01.napatech.com (mail01.napatech.com [188.120.77.121]) by dpdk.org (Postfix) with ESMTP id 450D51C00 for ; Thu, 11 May 2017 12:21:29 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=napatech.com; i=@napatech.com; q=dns/txt; s=mar2017; t=1494498089; x=1526034089; h=from:to:cc:subject:date:message-id:mime-version: content-transfer-encoding; bh=19ySMUONn+ajJKY8TBwBBHE1RSd59i9rIZkM5M8Tebs=; b=B4UYZIBYFez0lL6h98vjqs6R0gTVdNf29ggAILYD1pSURcmw0SlQgI3c RnU39AXP+iIFzczri4bATvAIMeMAS+r4cyaBeXzygijT6O0MZCcOlqoC3 SDJRcua5Mv5Dn2w5+jn/YJWslxHTpxDz4LC+4iD7ZkVlge9dbe3asxiFL qoUfvBS33mwupvEHs595jX5G0QyTDQShuwXVNGZehKONdBgYJyCG6g6zX qZB7puWMLjB2K6Fhc0rEWuLd3iH0p05iQb+MDkrP25ivX0oLQ5abaqFVZ S02FfFwRAJRFIm4etXSGlcNInYYnFTfb2F04dq6DnBIBRXI/ve4dUz6SY Q==; IronPort-PHdr: =?us-ascii?q?9a23=3A6mFAexwpQ6DOONTXCy+O+j09IxM/srCxBDY+r6Qd?= =?us-ascii?q?1OkXIJqq85mqBkHD//Il1AaPBtSEraoZwLCL+4nbGkU4qa6bt34DdJEeHzQksu?= =?us-ascii?q?4x2zIaPcieFEfgJ+TrZSFpVO5LVVti4m3peRMNQJW2aFLduGC94iAPERvjKwV1?= =?us-ascii?q?Ov71GonPhMiryuy+4ZPebgFKiTanfb9/LBq6oRvRu8ILnYZsN6E9xwfTrHBVYe?= =?us-ascii?q?pW32RoJVySnxb4+Mi9+YNo/jpTtfw86cNOSL32cKskQ7NWCjQmKH0169bwtRbf?= =?us-ascii?q?VwuP52ATXXsQnxFVHgXK9hD6XpP2sivnqupw3TSRMMPqQbwoXzmp8qFmQwLqhi?= =?us-ascii?q?gaLT406GHZhNJtgqxVoxyvoBNwzJLVYI+aL/d+YrrdcMkGSWdbQspdSypMCZ68?= =?us-ascii?q?YYsVCOoBOP5VoY78p1QSrRuxHxejBOfywTFOh3/22a863P48GgzB2QwgG8kDsH?= =?us-ascii?q?LOo9XtLqgSTf66w7XIzTnZc/xW3jL95ZHOfxs8r/+MWrdwftDQyUkpDw7FiE+f?= =?us-ascii?q?qZT/MDOJyOsCr2ib4/B8WuKojm4qrRx6rDu3xso0l4XFmpgZxk7L+Cll2oo5OM?= =?us-ascii?q?e0RU10bNK8DZdcqzuWO5V5T88+WW1luDo2xqcEtJO7eiUB1Y4pyATFa/OddoiF?= =?us-ascii?q?+hfjVOGMLjhmnH9lY7e/hwqq8Uin1+38StG40FZUoSpBldnBrnUN2AbS6siDUP?= =?us-ascii?q?d9+F2u2S6V2ADP9O5LPUA0mbDHJJ4mx748jpsTsULdES/qgEj6kbOael869uWn?= =?us-ascii?q?9+jreKjqqoWfOoJ7kg3+N74hms27AeQ2KAgOWG2b9Py51L3n5kD5Rq9FjuUsna?= =?us-ascii?q?nFrp/VOcQbqrSlDA9S14Yv8wy/ACu+0NQEgXkHK0pIdw+ZgIj3IFzBPej4Auq8?= =?us-ascii?q?g1i2lzdr3f/GbfXdBcCZInXduLv5cbU77FRTnlkd19dasrdVAbEILfa7fk71tt?= =?us-ascii?q?WQWho9Gwq92+/7Bd59kIgZXDTcUeeiLKrOvArQtaoUKO6WadpNtQ=3D=3D?= X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: =?us-ascii?q?A2H0AABxOhRZ/1QB8ApdHAEBBAEBCgEBF?= =?us-ascii?q?wEBBAEBCgEBhAyBDAeNeqdOgg8cEIV4hUsYAQEBAQEBAQEBAQECgRCCMyCBLCw?= =?us-ascii?q?ISAFHUoE+DgWKMLJGOop0AQEBAQEFAQEBAR8FCQGERIIRgV6HTxIBaIUmBYk9i?= =?us-ascii?q?D6MD5MOghGFO4osSJN7H4E4Cy8gCBkVhz10hmuBIYENAQEB?= X-IPAS-Result: =?us-ascii?q?A2H0AABxOhRZ/1QB8ApdHAEBBAEBCgEBFwEBBAEBCgEBhAy?= =?us-ascii?q?BDAeNeqdOgg8cEIV4hUsYAQEBAQEBAQEBAQECgRCCMyCBLCwISAFHUoE+DgWKM?= =?us-ascii?q?LJGOop0AQEBAQEFAQEBAR8FCQGERIIRgV6HTxIBaIUmBYk9iD6MD5MOghGFO4o?= =?us-ascii?q?sSJN7H4E4Cy8gCBkVhz10hmuBIYENAQEB?= Received: from localhost.localdomain (10.240.50.75) by cph-gen-exch02.napatech.com (10.240.1.84) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.1.845.34; Thu, 11 May 2017 12:21:27 +0200 From: Michael Lilja To: CC: Michael Lilja Date: Thu, 11 May 2017 12:21:15 +0200 Message-ID: <20170511102115.26466-1-ml@napatech.com> X-Mailer: git-send-email 2.12.2 MIME-Version: 1.0 Content-Type: text/plain X-Originating-IP: [10.240.50.75] X-ClientProxiedBy: cph-gen-exch02.napatech.com (10.240.1.84) To cph-gen-exch02.napatech.com (10.240.1.84) Content-Transfer-Encoding: quoted-printable Subject: [dpdk-dev] [PATCH v2] drivers/net/i40e/i40e_fdir.c: Improved i40e FDIR programming times X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 11 May 2017 10:21:29 -0000 During my work (https://www.napatech.com/hw-acceleration-via-rte_flow/) on a flowtable application example that use rte_flow I discovered that the rte_flow programming times on a i40e was +11ms. The patch below result in an average programming time of 22usec with a max of 60usec instead of +11ms. Could the following patch be useful? There might be a good reason for the original code, I'm unable to tell, so I will let it up to the maintainer to decide. Signed-off-by: Michael Lilja --- v2: * Code style fix --- drivers/net/i40e/i40e_fdir.c | 21 +++++++++++++-------- 1 file changed, 13 insertions(+), 8 deletions(-) diff --git a/drivers/net/i40e/i40e_fdir.c b/drivers/net/i40e/i40e_fdir.c index 28cc554f5..2162443f5 100644 --- a/drivers/net/i40e/i40e_fdir.c +++ b/drivers/net/i40e/i40e_fdir.c @@ -1296,23 +1296,28 @@ i40e_fdir_filter_programming(struct i40e_pf *pf, rte_wmb(); I40E_PCI_REG_WRITE(txq->qtx_tail, txq->tx_tail); - for (i =3D 0; i < I40E_FDIR_WAIT_COUNT; i++) { - rte_delay_us(I40E_FDIR_WAIT_INTERVAL_US); + for (i =3D 0; i < (I40E_FDIR_WAIT_COUNT * I40E_FDIR_WAIT_INTERVAL_U= S); i++) { if ((txdp->cmd_type_offset_bsz & - rte_cpu_to_le_64(I40E_TXD_QW1_DTYPE_MASK)) = =3D=3D - rte_cpu_to_le_64(I40E_TX_DESC_DTYPE_DESC_DO= NE)) + rte_cpu_to_le_64(I40E_TXD_QW1_DTYPE_MASK)) =3D=3D + rte_cpu_to_le_64(I40E_TX_DESC_DTYPE_DESC_DONE)) break; + rte_delay_us(1); } - if (i >=3D I40E_FDIR_WAIT_COUNT) { + if (i >=3D (I40E_FDIR_WAIT_COUNT * I40E_FDIR_WAIT_INTERVAL_US)) { PMD_DRV_LOG(ERR, "Failed to program FDIR filter:" - " time out to get DD on tx queue."); + " time out to get DD on tx queue."); return -ETIMEDOUT; } /* totally delay 10 ms to check programming status*/ - rte_delay_us((I40E_FDIR_WAIT_COUNT - i) * I40E_FDIR_WAIT_INTERVAL_U= S); + for (i =3D 0; i < (I40E_FDIR_WAIT_COUNT * I40E_FDIR_WAIT_INTERVAL_U= S); i++) { + if (i40e_check_fdir_programming_status(rxq) >=3D 0) { + break; + } + rte_delay_us(1); + } if (i40e_check_fdir_programming_status(rxq) < 0) { PMD_DRV_LOG(ERR, "Failed to program FDIR filter:" - " programming status reported."); + " programming status reported."); return -ENOSYS; } -- 2.12.2 Disclaimer: This email and any files transmitted with it may contain confid= ential information intended for the addressee(s) only. The information is n= ot to be surrendered or copied to unauthorized persons. If you have receive= d this communication in error, please notify the sender immediately and del= ete this e-mail from your system.