From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-qk0-f171.google.com (mail-qk0-f171.google.com [209.85.220.171]) by dpdk.org (Postfix) with ESMTP id CD0D5234 for ; Mon, 15 May 2017 14:17:16 +0200 (CEST) Received: by mail-qk0-f171.google.com with SMTP id k74so92837118qke.1 for ; Mon, 15 May 2017 05:17:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:in-reply-to:references :organization:mime-version:content-transfer-encoding; bh=BCbvSYmbpY51y5ue0tqXjW0e9yKn7ehWE9Lt1zrbAtQ=; b=KlMpzg4rvIbkCaWcrlmhQEoJuI7IaIgKuWUtIugiMObb1Awy3xGqTAKlYcVRch4byJ ZfrQA+udNdwc+qdtjul3bxvXl6LUDywV6NUll9ADuWpbF/WqGqAhB1R+/RTp38zoiYSP 3sb9Vbrx8Hohh0XWA00mGol/Yw8t1HMrXBpGq9jRGgT8jEc2Z0yJaljc6BvNJJAa2f7I TeJWO5dFqtCoPnz4KnSzaJYJgZ0aBuXqg/4Xty30Riy1m17VSM7UV5UK51RJ9sxVs7Rq O1KM8yGfdaszTIWM+c4WFA+332fi9slEf+Cir8MJuPID1FI5NIaBYSOZ0/aeo7PEWK2n F1SQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:organization:mime-version:content-transfer-encoding; bh=BCbvSYmbpY51y5ue0tqXjW0e9yKn7ehWE9Lt1zrbAtQ=; b=j3GLs+11USEA3e+5+AJ/RKo96bl8q0SP6PGKPyeKzAoXafQnpdC+67ZW71526pP0pO v//Y/1kKbOarNFFu70DTC7O9krqiCf2YHI9qrMqaFU6oabw4jiLjUAXsCP83MvYmHYgU aHY0bf7aCJBz+/FDuVNtaL9zDGc2LIo7I7XQz8CBqg2j+tAJmiMt2LGjdbSlWDINA45p KFw8qr+C7tm/zYICU6ktonqvkfN7bKM6ye7Kf3iehLFP0DR0asjNM+njSFxWzulJdYeo lVckdXYBLWticWSvmdGlcvS3FkqHDppTx/W422lOxKNwTAXzit7l+677OLST7qj0Skte pa9Q== X-Gm-Message-State: AODbwcDicPk85XkgQDmqhCd3gwk1ovPUBp0u0+chTAPtCHoARmgpsChk Wj0sWOImQMUMR2jD X-Received: by 10.80.177.240 with SMTP id n45mr4617853edd.177.1494850635191; Mon, 15 May 2017 05:17:15 -0700 (PDT) Received: from paques.dev.6wind.com (host.78.145.23.62.rev.coltfrance.com. [62.23.145.78]) by smtp.gmail.com with ESMTPSA id m9sm5102638edd.41.2017.05.15.05.17.14 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 15 May 2017 05:17:14 -0700 (PDT) Date: Mon, 15 May 2017 14:17:07 +0200 From: Pascal Mazon To: Ferruh Yigit Cc: Shepard Siegel , Ed Czeck , John Miller , John McNamara , Harish Patil , Rasesh Mody , Rahul Lakkireddy , Hemant Agrawal , Shreyansh Jain , Wenzhuo Lu , Marcin Wojtas , Michal Krawczyk , Guy Tzalik , Evgeny Schemeilin , Jing Chen , Helin Zhang , Jingjing Wu , Konstantin Ananyev , Adrien Mazarguil , Nelio Laranjeiro , Matej Vido , Yuanhan Liu , Maxime Coquelin , Shrikrishna Khare , dev@dpdk.org Message-ID: <20170515141707.3021bd9b@paques.dev.6wind.com> In-Reply-To: <20170515105946.88233-1-ferruh.yigit@intel.com> References: <20170510131053.75843-1-ferruh.yigit@intel.com> <20170515105946.88233-1-ferruh.yigit@intel.com> Organization: 6WIND X-Mailer: Claws Mail 3.11.1 (GTK+ 2.24.25; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH v2] drivers/net: document missing speed capabilities feature X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 15 May 2017 12:17:17 -0000 Hi, In the case of tap PMD, I would say it's rather partially supported (P). Best regards, Pascal On Mon, 15 May 2017 11:59:46 +0100 Ferruh Yigit wrote: > Signed-off-by: Ferruh Yigit > --- > > Please fix partially support to fully supported speed capabilities. > > Please check other features of PMD and document missing ones in features > file. > > Thanks. > > v2: > * Mark PMDs that return speed capabilities without checking real > hardware capabilities to Partially supported "P". > * Mark PMDs return fake speed capabilities to "P", like virtio and > vmxnet3. > --- > doc/guides/nics/features/ark.ini | 1 + > doc/guides/nics/features/bnx2x.ini | 1 + > doc/guides/nics/features/bnx2x_vf.ini | 1 + > doc/guides/nics/features/cxgbe.ini | 1 + > doc/guides/nics/features/dpaa2.ini | 1 + > doc/guides/nics/features/e1000.ini | 1 + > doc/guides/nics/features/ena.ini | 1 + > doc/guides/nics/features/fm10k.ini | 1 + > doc/guides/nics/features/fm10k_vec.ini | 1 + > doc/guides/nics/features/fm10k_vf.ini | 1 + > doc/guides/nics/features/fm10k_vf_vec.ini | 1 + > doc/guides/nics/features/i40e.ini | 1 + > doc/guides/nics/features/i40e_vec.ini | 1 + > doc/guides/nics/features/igb.ini | 1 + > doc/guides/nics/features/ixgbe.ini | 1 + > doc/guides/nics/features/ixgbe_vec.ini | 1 + > doc/guides/nics/features/mlx4.ini | 1 + > doc/guides/nics/features/szedata2.ini | 1 + > doc/guides/nics/features/tap.ini | 2 +- > doc/guides/nics/features/virtio.ini | 1 + > doc/guides/nics/features/virtio_vec.ini | 1 + > doc/guides/nics/features/vmxnet3.ini | 1 + > 22 files changed, 22 insertions(+), 1 deletion(-) [...] > diff --git a/doc/guides/nics/features/tap.ini b/doc/guides/nics/features/tap.ini > index 3efae75..d410409 100644 > --- a/doc/guides/nics/features/tap.ini > +++ b/doc/guides/nics/features/tap.ini > @@ -4,6 +4,7 @@ > ; Refer to default.ini for the full list of available PMD features. > ; > [Features] > +Speed capabilities = Y > Link status = Y > Link status event = Y > Jumbo frame = Y > @@ -13,7 +14,6 @@ Basic stats = Y > Flow API = Y > MTU update = Y > Multicast MAC filter = Y > -Speed capabilities = Y > Unicast MAC filter = Y > Packet type parsing = Y > Flow control = Y [...]