From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f53.google.com (mail-wm0-f53.google.com [74.125.82.53]) by dpdk.org (Postfix) with ESMTP id AF6D12C2F for ; Wed, 17 May 2017 12:32:47 +0200 (CEST) Received: by mail-wm0-f53.google.com with SMTP id b84so159590416wmh.0 for ; Wed, 17 May 2017 03:32:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=4GjfThae/Y0lNaEHDFEWtJpVlSUw0YHSr2z8BosKTuo=; b=Na2/76H59zB7uF019xKeQ4K+87sBUVuAIlZZcshtt6WyFhBhGRukn80zYcMzKDlNyC DH3AtfisAUFGbFVMum4cxR/bPjEvZaEN0vi6CB54JElZDJQbZWXuOFl/yQu7vBCfqbrd uW0rEXrUMQ+XL3TDJjwiMUTd2nOwmbMyMf2dxTjhEMIgbaD1802M4mSWvILCc+nx1alz pX6+7Fol+thdvWFHwt9TZAqP+eb4rruI6nHIvjZgoqUCLy7yud0kxOupIsPwbsn5sQ6J AevI5LEmurHJs23A5IZlfUJu81cYtv4njXWZk8T6FoxvSu7PiFqq7PIAU529Xoe4UEyy DnTg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=4GjfThae/Y0lNaEHDFEWtJpVlSUw0YHSr2z8BosKTuo=; b=H9uDtynxuWoAJCFUjY9aORnIvXGsQgKSGOt95QEeh7sOBiFq/RTjLrOZxslPyqOeC9 JcFSTS5ZWJOOZDUebYmU3kpVpy+1TDyYhOorTQQThkL5rfPmKygJIdKWHHP6kekNEPI7 Ys2ND4ZqlZuQD7q6W/Y6JCB4XuT15ayNXAOy7+o9IjqijY910Hq+cN+HvFHou5RJzOt+ 2ub8KMlW6nSAbBA7eYOu0eODhZ5fmuF0VehHuXCiwikiTi4QAihiZpUeK/9WhnyOf/M5 rKcEmRMRDkQGvY+SfoVQauLcoMXScCPGEbE/9ZVL04e5fJd0GGgMa9B6cyzxFY7pCJTf uVcw== X-Gm-Message-State: AODbwcB4N23B4ZBAczVpz6Edk/EhonFKA3mqNi2opK0P0e3lBSUb0PpH 1OUnx6I0rSvPInsN0iQ= X-Received: by 10.28.210.5 with SMTP id j5mr9393105wmg.56.1495017167431; Wed, 17 May 2017 03:32:47 -0700 (PDT) Received: from 6wind.com (host.78.145.23.62.rev.coltfrance.com. [62.23.145.78]) by smtp.gmail.com with ESMTPSA id 77sm2196384wmw.24.2017.05.17.03.32.46 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 17 May 2017 03:32:46 -0700 (PDT) Date: Wed, 17 May 2017 12:32:41 +0200 From: Adrien Mazarguil To: Qi Zhang Cc: dev@dpdk.org, wenzhuo.lu@intel.com, beilei.xing@intel.com Message-ID: <20170517103241.GD1758@6wind.com> References: <1494791406-3594-1-git-send-email-qi.z.zhang@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1494791406-3594-1-git-send-email-qi.z.zhang@intel.com> Subject: Re: [dpdk-dev] [RFC 0/2] ethdev: add new attribute for signature match X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 17 May 2017 10:32:47 -0000 On Sun, May 14, 2017 at 03:50:04PM -0400, Qi Zhang wrote: > We try to enable ixgbe's signature match with rte_flow, but didn't > find a way with current APIs, so the RFC propose to add a new flow > attribute "sig_match" to indicate if current flow is "perfect match" > or "signature match" > With perfect match (by default), if a packet does not match pattern, > actions will not be taken. (this is identical with current behavior) > With signature match, if a packet does not match pattern, it still > has the possibility to trigger the actions, this happens when device > think the signature of the pattern is matched. > Signature match is expected to have better performance than perfect > match with the cost of accuracy. > When a flow rule with this attribute set, identical behavior can ONLY > be guaranteed if packet matches the pattern, since different device > may have different implementation of signature calculation algorithm. > Driver of device that does not support signature match is not required to > return error, but just simply igore this attribute, because the default > "perfect match" still can be regarded as a speical case of > "signature match". > > Qi Zhang (2): > rte_flow: add attribute for signature match > doc/guides/prog_guide: add new rte_flow attribute > > app/test-pmd/cmdline_flow.c | 11 +++++++++++ > doc/guides/prog_guide/rte_flow.rst | 12 ++++++++++++ > lib/librte_ether/rte_flow.h | 3 ++- > 3 files changed, 25 insertions(+), 1 deletion(-) As discussed offline, modifying struct rte_flow_attr for this purpose is not ideal. We've agreed that a new meta pattern item should be defined instead, as described in the FDIR rules conversion section (8.9.7) of the documentation [1]. [1] http://dpdk.org/doc/guides/prog_guide/rte_flow.html#fdir-to-most-item-types-queue-drop-passthru -- Adrien Mazarguil 6WIND