From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pf0-f178.google.com (mail-pf0-f178.google.com [209.85.192.178]) by dpdk.org (Postfix) with ESMTP id B0DB628EE for ; Mon, 22 May 2017 18:11:08 +0200 (CEST) Received: by mail-pf0-f178.google.com with SMTP id e193so86793832pfh.0 for ; Mon, 22 May 2017 09:11:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=Z5vOmJYWdBICDi0QYgQKFgMDo4AT041Xa/h48R1m4Po=; b=Pt9kVzupRKULoPPT7VDjXQn0yBZ6jxDHrK8TGuJwyFUmzUs50D8otUcGzK25yV07rQ ab8SP7Y6AbDh5GjPTyH6zvsRHzELXgOgBTlFw7yJ6zHEzHQiAb2XD00KQP6jL6Dw4uEt N4DRxUpz2WvLSv00PSDIfoWjz6REepVpcwrnkmHWu9LanCUe9vFkRlLU86tEpcnrrRvB S1/OW/ViVKKE4QTRA1JYg1gyL1e0HqePvf/nalRAV2Xz0QfDILsFLchvuKYGC/kcUlY5 pipc6o5ddl87KvPY0W9W/85L4DM/yyWJ8cRNyPzDx0mmQuaEK85wsRTZHHBc049YeJjR YfnA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=Z5vOmJYWdBICDi0QYgQKFgMDo4AT041Xa/h48R1m4Po=; b=PK7HTrt2J1FdpQG49K1/L9DwE7F+rEF3WVddUi+VlZ7IfJlhj1yyHrDIV0lB8e4R/E P4KCwtljGJ64Vw2kNEJ8byOIDX09ArV8g1swqYd6LhD+6a++VUOrgvfNNhplfX1za74e PzA1wKsY+fUXAUr16MaGxUC62nN4IAjO6RPoMS9TeGCrsHHN2qs3ANlcuGg//9nGadma /FrAsrmUAoyRvi0yogFoYJOSpDcpmQ3pHIW5A2ON9WkrlhmTo8SLV0Pb+mDthV/pNBxZ IMfXc5q4J9i6uYfpZSguVW1mVG2ozbIdSCbv/5YrQx6C8IOusCSsYbddGeA+HrRLIUTz jsZQ== X-Gm-Message-State: AODbwcC3pjuNhsphWAksNAe9G0qroam7wS9aVvVnDug+om0vpc0AkXlQ P8WNMep3dilEqCng X-Received: by 10.99.0.3 with SMTP id 3mr26173491pga.57.1495469467531; Mon, 22 May 2017 09:11:07 -0700 (PDT) Received: from xeon-e3 (76-14-207-240.or.wavecable.com. [76.14.207.240]) by smtp.gmail.com with ESMTPSA id f72sm27155569pff.78.2017.05.22.09.11.07 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 22 May 2017 09:11:07 -0700 (PDT) Date: Mon, 22 May 2017 09:11:00 -0700 From: Stephen Hemminger To: Michal Jastrzebski Cc: dev@dpdk.org, reshma.pattan@intel.com, deepak.k.jain@intel.com, harry.van.haaren@intel.com Message-ID: <20170522091100.27f080e3@xeon-e3> In-Reply-To: <20170522143202.22424-1-michalx.k.jastrzebski@intel.com> References: <20170522143202.22424-1-michalx.k.jastrzebski@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH 0/3] drivers/net: add support for IF-MIB and EtherLike-MIB X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 22 May 2017 16:11:09 -0000 On Mon, 22 May 2017 16:31:59 +0200 Michal Jastrzebski wrote: > Extend Intel NICs (i40e, ixgbe, e1000) xstats for IF-MIB and > EtherLike-MIB. > > If-MIB xstats: > ifNumber > ifIndex > ifType > ifMtu > ifSpeed > ifPhysAddress > ifOperStatus > ifLastChange > ifHighSpeed > ifConnectorPresent > ifCounterDiscontinuityTime > > EtherLike-MIB xstats: > dot3PauseOperMode > dot3StatsDuplexStatus > dot3StatsRateControlAbility > dot3StatsRateControlStatus > dot3ControlFunctionsSupported > > Michal Jastrzebski (3): > drivers/net: add support for IF-MIB and EtherLike-MIB for e1000 > drivers/net: add support for IF-MIB and EtherLike-MIB for i40e > drivers/net: add support for IF-MIB and EtherLike-MIB for ixgbe > > drivers/net/e1000/e1000_ethdev.h | 59 ++++++++ > drivers/net/e1000/igb_ethdev.c | 296 ++++++++++++++++++++++++++++++++++---- > drivers/net/i40e/i40e_ethdev.c | 171 +++++++++++++++++++++- > drivers/net/i40e/i40e_ethdev.h | 60 ++++++++ > drivers/net/ixgbe/ixgbe_ethdev.c | 275 ++++++++++++++++++++++++++++++++--- > drivers/net/ixgbe/ixgbe_ethdev.h | 59 ++++++++ > 6 files changed, 878 insertions(+), 42 deletions(-) > Having all the SNMP MIB information is a worth goal. Thank you for starting the effort. But you need to rethink how you are implementing this. Doing it in a driver specific manner is not helpful to application writers. All API's for features like this should be at ethdev level, and be supported by generic code. If you are going to add something like this it has to work for all devices virtual, physical, layered and not just Intel hardware. It is a much bigger task.