From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f44.google.com (mail-wm0-f44.google.com [74.125.82.44]) by dpdk.org (Postfix) with ESMTP id E04252C29 for ; Tue, 23 May 2017 08:51:51 +0200 (CEST) Received: by mail-wm0-f44.google.com with SMTP id 123so16117460wmg.1 for ; Mon, 22 May 2017 23:51:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:in-reply-to:references :organization:mime-version:content-transfer-encoding; bh=ZXLGYou7mLq86N+1Fhdumfn+G9ROcxNL2QrYfBzItc0=; b=IJp9/2V7P10gs+qZpBDlfsBQc5NAvJKVzjkwjFxD+8tz8H9TOPN3VbC5K49dSZEnzP Z8jog0IscE0X7VgzEpnpyxMZfEVNgy2TfwEAJdYG1Vy3Z18vBJAifaWmChu4C0d59FMI if7d0owmKhzUOq3NxeN82J53v3LRsTTZN633USsjR3viFiFiAlACttnA60K/0N2ADpTB nW0ABfzl8Ew5ZUrIcS+DkPOIDsLEjbFDlX1Jxzz0geqHTbUiKArDUfbbd+0G1f00nZ0o /zKadJRi078wN8uF5Bhh1HPHJM1wgRZUfEOx6PzmrW/B7tFRQA76zhs0YnAX+nyS4yQr dZ/Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:organization:mime-version:content-transfer-encoding; bh=ZXLGYou7mLq86N+1Fhdumfn+G9ROcxNL2QrYfBzItc0=; b=HKiv7uxm9EZ8yOZGXx1WUHwJ+BsSyeFymhdnjngHUqN9y96v1OwyH+jFcdCB4uK1u9 8R+RD078JikajT/T1Pf9IHunz0GP47G8JC3mAOBeKCqjuyN5l7v0dwPkUTaYmR8OVS2X dhkuq1YL3bObhbppEhfYupGKZVMaUAk2F5huhgDyekL9julI/QyG/o8LYU8QPeagJ5vX qG+wocyqG+z3ZciLLN4Wq+e9O1xpiLmIaqB8I6RTRiL+qSP6O1WqQrg5fbpdHml+X0Xy dZia8mJ8oIG/+WvUQTggcTcrRYcDVXXlBV8Ay5dZLrtgwoK8IpgRAe4YDkfvFumk5p98 dplQ== X-Gm-Message-State: AODbwcAxSK3942og+Je1k5DnNGgg10wmkiChxeUng7MNaLfvm/ZMUDYc SobY9mOUcOZdURT0zTU= X-Received: by 10.28.22.12 with SMTP id 12mr931626wmw.97.1495522311654; Mon, 22 May 2017 23:51:51 -0700 (PDT) Received: from paques.dev.6wind.com (host.78.145.23.62.rev.coltfrance.com. [62.23.145.78]) by smtp.gmail.com with ESMTPSA id z77sm7459631wrc.22.2017.05.22.23.51.51 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 22 May 2017 23:51:51 -0700 (PDT) Date: Tue, 23 May 2017 08:51:43 +0200 From: Pascal Mazon To: Ferruh Yigit Cc: dev@dpdk.org Message-ID: <20170523085143.73bb3f50@paques.dev.6wind.com> In-Reply-To: <6acb1c97-0c27-da98-5c4f-292b0f87e29a@intel.com> References: <172025985dc6ca989008cc2d93008e38ac3fff39.1495452020.git.pascal.mazon@6wind.com> <6acb1c97-0c27-da98-5c4f-292b0f87e29a@intel.com> Organization: 6WIND X-Mailer: Claws Mail 3.11.1 (GTK+ 2.24.25; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH] net/tap: add Rx/Tx checksum offload support X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 23 May 2017 06:51:52 -0000 Hi Ferruh, I'm not sure it would actually be so useful for other vPMDs. Virtio and vmxnet3 for instance have their own mechanisms for handling offloading. Software offload is especially relevant for tap as packets may come from anywhere (from another process, from a remote netdevice), and the application would be interested in knowing how good the packet is. At first, I'd rather keep the code as-is in tap, which is generic enough to be easily moved later when actual need arise. Best regards, Pascal On Mon, 22 May 2017 13:24:41 +0100 Ferruh Yigit wrote: > Hi Pascal, > > On 5/22/2017 12:20 PM, Pascal Mazon wrote: > > This patch adds basic offloading support, widely expected in a PMD. > > > > Verify IPv4 and UDP/TCP checksums upon packet reception, and set > > ol_flags accordingly. > > > > On Tx, set IPv4 and UDP/TCP checksums when required, considering > > ol_flags. > > These are not specific to tap and can be used by any virtual PMD, right? > > What do you think moving implementation into more generic location (I > don't know where right now) and use from there, and other PMDs also can > benefit from these? > > Thanks, > ferruh > > > > > Signed-off-by: Pascal Mazon > > <...> >