From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <jfreiman@redhat.com>
Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28])
 by dpdk.org (Postfix) with ESMTP id A2D9E7CA3
 for <dev@dpdk.org>; Wed, 24 May 2017 10:36:09 +0200 (CEST)
Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com
 [10.5.11.15])
 (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by mx1.redhat.com (Postfix) with ESMTPS id 7833C804FB;
 Wed, 24 May 2017 08:36:03 +0000 (UTC)
DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 7833C804FB
Authentication-Results: ext-mx03.extmail.prod.ext.phx2.redhat.com;
 dmarc=none (p=none dis=none) header.from=redhat.com
Authentication-Results: ext-mx03.extmail.prod.ext.phx2.redhat.com;
 spf=pass smtp.mailfrom=jfreiman@redhat.com
DKIM-Filter: OpenDKIM Filter v2.11.0 mx1.redhat.com 7833C804FB
Received: from localhost (dhcp-192-218.str.redhat.com [10.33.192.218])
 by smtp.corp.redhat.com (Postfix) with ESMTPS id 105C8183E4;
 Wed, 24 May 2017 08:36:02 +0000 (UTC)
Date: Wed, 24 May 2017 10:36:01 +0200
From: Jens Freimann <jfreiman@redhat.com>
To: Yuanhan Liu <yuanhan.liu@linux.intel.com>
Cc: "Wang, Zhihong" <zhihong.wang@intel.com>, "dev@dpdk.org" <dev@dpdk.org>
Message-ID: <20170524083601.sd7sueoskpfeyxt7@dhcp-192-218.str.redhat.com>
References: <1495483268-60184-1-git-send-email-zhihong.wang@intel.com>
 <20170523115335.gtykyluswrsjuls3@dhcp-192-218.str.redhat.com>
 <8F6C2BD409508844A0EFC19955BE09415127D9EE@SHSMSX103.ccr.corp.intel.com>
 <20170524081419.GU2276@yliu-dev>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20170524081419.GU2276@yliu-dev>
User-Agent: NeoMutt/20170428 (1.8.2)
X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15
X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16
 (mx1.redhat.com [10.5.110.27]); Wed, 24 May 2017 08:36:08 +0000 (UTC)
Subject: Re: [dpdk-dev] [PATCH] vhost: support rx_queue_count
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Wed, 24 May 2017 08:36:10 -0000

On Wed, May 24, 2017 at 04:14:19PM +0800, Yuanhan Liu wrote:
> On Tue, May 23, 2017 at 12:51:56PM +0000, Wang, Zhihong wrote:
> > 
> > 
> > > -----Original Message-----
> > > From: Jens Freimann [mailto:jfreiman@redhat.com]
> > > Sent: Tuesday, May 23, 2017 7:54 PM
> > > To: Wang, Zhihong <zhihong.wang@intel.com>
> > > Cc: dev@dpdk.org; yuanhan.liu@linux.intel.com
> > > Subject: Re: [dpdk-dev] [PATCH] vhost: support rx_queue_count
> > > 
> > > On Mon, May 22, 2017 at 04:01:08PM -0400, Zhihong Wang wrote:
> > > > This patch implements the ops rx_queue_count for vhost PMD by adding
> > > > a helper function rte_vhost_rx_queue_count in vhost lib.
> > > >
> > > > The ops ops rx_queue_count gets vhost RX queue avail count and helps
> > > 
> > > s/ops ops/ops/ ?
> > 
> > Thanks a lot!
> 
> Seems you overlooked other comments, such as:
> 
> > > > +	vq = dev->virtqueue[qid];
> > > 
> > > check for vq == NULL?
> > > 
> > > regards,
> > > Jens
> 
> Besides, Jens, I'm not a big fan of "dev == NULL" over "!dev". I accept
> both :)

Personally I'm with you on this, but it says different in http://dpdk.org/doc/guides/contributing/coding_style.html
Anyway, up to you :)

regards,
Jens