From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pf0-f175.google.com (mail-pf0-f175.google.com [209.85.192.175]) by dpdk.org (Postfix) with ESMTP id C3214999C for ; Thu, 25 May 2017 19:40:41 +0200 (CEST) Received: by mail-pf0-f175.google.com with SMTP id e193so173672318pfh.0 for ; Thu, 25 May 2017 10:40:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=09nyvSQVr1qZIUIFHri3VkimiqAQ9k+qXMHR2G+HXI0=; b=z8sCVlW/tD8m2vA4rYZIuKpAbY0DfxUQQt+jj3xqec92cRi/Bu3deu0yLNiPcbL+KV Bnqv+uutlrdOhB2mTPHyDaeOKvVxu9X+frIZjuVjmbDNKIYfVs9V9WtH66HTJcNQ2uQo yDIpXpOKJi7CLOGe2gKkAI7L+6+ywVU/FO9kow1HrdsWzeyjd9K/JxBP6bRoZmrRNsxS 6TQ0WZd4FrVoODY7Rbq573rZLW2K8a9SYOJOAgEKkwfhFp4dpY7yEkGWD51w7jgayfVK xiF1If1GgdWV514h28EUBKThEiiS2VW8IF/0k1Iqpk1JSfiEhRM55ReLzKPiEwo1EfJ+ zU+g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=09nyvSQVr1qZIUIFHri3VkimiqAQ9k+qXMHR2G+HXI0=; b=MWs9ewoVWAd623e3gMCT5+yBLew08InFEZbcBsaAKty+AT00FCyC9QqABN/oczgr5Y w4tLtt9QqbG3umXiaEOIw1exlevlotLSj/BPoXkMg9KxZZX/TgMaawqpcxY6FqcrBNoh 7VtCugQikk2M7k4SixcdGi4DCcwL/oULVFPyQONbeueC/AJv5Fi+f7oYZ9Brz1hlKIJP Mfr4ws5S0X0h9Bh8hLs6DduUPSHkji8ALLj7b2VRGVkecxQApmotWjLsn3hZHfddXk6v td5Uk7EbkeL+UHXcW8EhypdnRKSvWL4QPBuKnO9jgGXOuvdFkviWyjoA6f5oUzhV4Gwo e32Q== X-Gm-Message-State: AODbwcDCTO7WXF/2SfPOX6mtmGeAVG6n0+EsYVG+4ebDZgKugS7QrYY3 mNteJlkAcEkSKzNq X-Received: by 10.98.214.90 with SMTP id r87mr46101676pfg.204.1495734040916; Thu, 25 May 2017 10:40:40 -0700 (PDT) Received: from xeon-e3 (76-14-207-240.or.wavecable.com. [76.14.207.240]) by smtp.gmail.com with ESMTPSA id o66sm16779880pga.64.2017.05.25.10.40.40 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Thu, 25 May 2017 10:40:40 -0700 (PDT) Date: Thu, 25 May 2017 10:40:33 -0700 From: Stephen Hemminger To: Andrew Rybchenko Cc: , Sergio Gonzalez Monroy , Remy Horton , Jianfeng Tan , Declan Doherty , Ferruh Yigit , Yuanhan Liu , Maxime Coquelin , Konstantin Ananyev , Bruce Richardson , Reshma Pattan , Cristian Dumitrescu , Byron Marohn , Pablo de Lara Guarch , Pawel Wodkowski , Tomasz Kantecki , John McNamara , Daniel Mrzyglod , Roman Zhukov Message-ID: <20170525104033.43a6e02f@xeon-e3> In-Reply-To: <1495727874-10892-1-git-send-email-arybchenko@solarflare.com> References: <1488459935-13273-2-git-send-email-arybchenko@solarflare.com> <1495727874-10892-1-git-send-email-arybchenko@solarflare.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH 1/2] ethdev: add function to adjust number of descriptors X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 25 May 2017 17:40:42 -0000 On Thu, 25 May 2017 16:57:53 +0100 Andrew Rybchenko wrote: > From: Roman Zhukov > > Check that numbers of Rx and Tx descriptors satisfy descriptors limits > from the Ethernet device information, otherwise adjust them to boundaries. > > Signed-off-by: Roman Zhukov > Signed-off-by: Andrew Rybchenko Seems like new added complexity. Why not just allow devices to take the request as a hint and truncate or pad as needed. IMHO to be successful DPDK must have as simple as possible API for application. Good enough and as little more as possible. But other people seem to think that having the richest and most complex possible API is a good thing.