From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <stephen@networkplumber.org>
Received: from mail-pf0-f178.google.com (mail-pf0-f178.google.com
 [209.85.192.178]) by dpdk.org (Postfix) with ESMTP id 4619499D5
 for <dev@dpdk.org>; Thu, 25 May 2017 20:42:50 +0200 (CEST)
Received: by mail-pf0-f178.google.com with SMTP id n23so174903494pfb.2
 for <dev@dpdk.org>; Thu, 25 May 2017 11:42:50 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=networkplumber-org.20150623.gappssmtp.com; s=20150623;
 h=date:from:to:cc:subject:message-id:in-reply-to:references
 :mime-version:content-transfer-encoding;
 bh=3bj98wof9/3tJTymhL/ZWp9vkbo8sEod/Js5xlPkHzk=;
 b=fpI0Nh+KfHkidYuU1Wi6quVdRmi0n4NwCvz6sUpMgl1++P25JEnb8ys6lKb9YJKwBj
 SLAjBV8T1w3VjqMywqp+BZswb45S934i8IU3fCzwhyTxE0pBNIIUxHw8bGwpUPnPHdIC
 izbNHhBjddwETc7piQuUv9QJmhkJ2iphoZznFvjLZVW1U/P6V0aMLLF91CFAsZDAf3Rv
 WkihxviS/FgSRlJOxPugGQqE0JTkMfBH5ck6j7muba1AQc0P4FwtY02IbBmayU7o67jW
 pJakBzH9qLXJUdYCSoSrH+f92MYxjnBaTXHJfQz+xrT9HWcUt8BklxxDTHw/mOBGd/5H
 Vp2g==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20161025;
 h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to
 :references:mime-version:content-transfer-encoding;
 bh=3bj98wof9/3tJTymhL/ZWp9vkbo8sEod/Js5xlPkHzk=;
 b=aD9bOiIY5qoGfjeS9MAWa7NFEQJBiVATu9ABsTii+6P9rZZv9jlGZO2+GaBvV5HWzX
 2RbHnUYr8EstMmhO59ziIwbu9BASQPSTQAjSpsgjZp4B8+cr+B4BHKx0TxGy5LJije7B
 bJp/tRV5P8GqXR5SxbpsCWZB8UegR8ojQqxk8degmmptoO+qy+NbNc2SVHrJDW74mVLh
 8WpQma0y3gh6YuKBKzCJh+xiOROXzIEmKVjEJrpJdVYf0gO9oUgjv7VFk+uLNC+imYvE
 amnn05FOaY+0sxoYgKKUdPJ7LVENQB+e/L1mriqeMJcc84SEap0XnCQaF2144iteKpo4
 EhMw==
X-Gm-Message-State: AODbwcD7fMPKaEocoQqz3NmyJRIaWvHARSMyB3MF3psZi0jel/1d6/bq
 cTJasq0q6pFZmnWkz4aoYg==
X-Received: by 10.98.42.7 with SMTP id q7mr16499729pfq.165.1495737769523;
 Thu, 25 May 2017 11:42:49 -0700 (PDT)
Received: from xeon-e3 (76-14-207-240.or.wavecable.com. [76.14.207.240])
 by smtp.gmail.com with ESMTPSA id o66sm16936539pga.64.2017.05.25.11.42.49
 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256);
 Thu, 25 May 2017 11:42:49 -0700 (PDT)
Date: Thu, 25 May 2017 11:42:42 -0700
From: Stephen Hemminger <stephen@networkplumber.org>
To: Gregory Etelson <gregory@weka.io>
Cc: dev@dpdk.org, Ferruh Yigit <ferruh.yigit@intel.com>, Qi Zhang
 <qi.z.zhang@intel.com>, Wenzhuo Lu <wenzhuo.lu@intel.com>
Message-ID: <20170525114242.3c6ac1b7@xeon-e3>
In-Reply-To: <106841857.Z7q1jSDIte@polaris>
References: <106841857.Z7q1jSDIte@polaris>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Subject: Re: [dpdk-dev] i40e igb_uio: reset pci on process exit
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Thu, 25 May 2017 18:42:50 -0000

On Wed, 24 May 2017 14:22:11 +0300
Gregory Etelson <gregory@weka.io> wrote:

>  
> +static int
> +igbuio_pci_release(struct uio_info *info, struct inode *inode)
> +{
> +       int ret;
> +       struct rte_uio_pci_dev *udev = info->priv;
> +       struct pci_dev *dev = udev->pdev;
> +       ret = __pci_reset_function(dev);
> +       dev_info(&dev->dev, "pci_reset_function %s \n",
> +                 ret == 0 ? "succeded" : "failed");
> +       return 0;
> +}
> +
> +

Patch in general looks ok, but:
 * no Signed-off
 * whitespace issues
 * doesn't pass kernel coding style
 * don't log on success, why log at all??