From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from NAM03-DM3-obe.outbound.protection.outlook.com (mail-dm3nam03on0070.outbound.protection.outlook.com [104.47.41.70]) by dpdk.org (Postfix) with ESMTP id 8386699DA for ; Fri, 26 May 2017 08:05:29 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=CAVIUMNETWORKS.onmicrosoft.com; s=selector1-cavium-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=lBjc+iQsa5edLNOpay8osCbLT4C4CiyG0YEPmJOzf6s=; b=DpB3gLgjSuChbrGhbqj9PQtbsEp7G7ulBhwNfDBLMPlo/pIoC4+RZeSZPK2BSnEI5l5qamrjOnP9mlCIpFPVFoROKrVz7MmgjghhqjnuCFapr+u1lj2jqiqaZnC9fXvFQ/byZkRhWxuEfh4lSIbHxKUgP+HE8/DfH6etgKTN0sM= Authentication-Results: weka.io; dkim=none (message not signed) header.d=none; weka.io; dmarc=none action=none header.from=caviumnetworks.com; Received: from localhost.localdomain (14.140.2.178) by MWHPR07MB3071.namprd07.prod.outlook.com (10.172.97.13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1124.9; Fri, 26 May 2017 06:05:25 +0000 Date: Fri, 26 May 2017 11:35:11 +0530 From: Shijith Thotton To: Gregory Etelson Cc: Stephen Hemminger , dev@dpdk.org, Ferruh Yigit , Qi Zhang , Wenzhuo Lu Message-ID: <20170526060509.GA5157@localhost.localdomain> References: <106841857.Z7q1jSDIte@polaris> <20170525114242.3c6ac1b7@xeon-e3> <2080347.1TTqQevoe3@polaris> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <2080347.1TTqQevoe3@polaris> User-Agent: Mutt/1.5.21 (2010-09-15) X-Originating-IP: [14.140.2.178] X-ClientProxiedBy: MA1PR01CA0076.INDPRD01.PROD.OUTLOOK.COM (10.174.56.16) To MWHPR07MB3071.namprd07.prod.outlook.com (10.172.97.13) X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: MWHPR07MB3071: X-MS-Office365-Filtering-Correlation-Id: 7b3c386e-e299-4081-90cf-08d4a3fd34d1 X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(22001)(201703131423075)(201703031133081); SRVR:MWHPR07MB3071; X-Microsoft-Exchange-Diagnostics: 1; MWHPR07MB3071; 3:Mq/FIyniYTfciZbNd9XuJMP9HZDoa9NhOolCsdswOOQsdNvPPofTXzzFLXy/CT0GGvK693tjcJ1GJTk6dq89fv2HHz1oOVA01W4hYeBXMQNJYqRySbqEb1+osXgEqjduELful6aqUz0WqJGgsrfmXNLH65+L2r42xQ51ar1Ipye37X8QAi6eBvp8YBNfcnF7zcLTiUIG/ZXows0cXhmgQtCouTjjjhQmYBS2DWWpTpD+Mh0s290CGK++aCBYyDI9TlvdIWyqIPjzIcaAfaAVgACLjBaShEq4PIN0U1mLQwn93704XbXxkcRV9yQopr/vEs6ei/w7WD+jobrU2G7GSA==; 25:idNuX1dwgHgiZUKuMDRXbiFXuMAMaA7f34/ma/hs2sAZKTD423wAVctPLZ8qTSQgxAWQiruKiZ5vX0XjksCUulaubuHBHmKyXj0KF4TbwfWAb05dHPLFMMzClUjJrPB6igjuB7+0tQ+EKHwpflY9h12vT1cbReO9qyoDJ72FJULiKWk02+nhJpliJQjJVc2mJzHlMV0ef8lc+69nSNfImOuAjDdgWGYWuuNeqkwVH6UInqEjAFwopVynKSC63Jfnv0Yg7i/ipSZxcReCwn++p7E5HtNT2Q3Irw2CpfNA1zSRmxIQs9oHy18RG9sEWKdQ5mUF41Qy3CJ/QkgNwrkjRFnxHAzi67t2Li23xxQW9cP4PHNbUukhY+I5Tm0OYW+WmHPfBaNkpJXL3BOJOeW/FTTeM9hiMrdAFkYINm4l72hbI31M8jRjSGYRIYu+wHEV84sXkXrGybpElDtJIkcNXmxKWyacWWAFmElI2HP8nw8= X-Microsoft-Exchange-Diagnostics: 1; MWHPR07MB3071; 31:5ZBWNzsaCxhkKVZTzMZw/dFrXQh8HNe3brOi9k9CJLIiz1GIxq0p9sW7tjRqU2nUKPrV78xrZYF+e1BZzTEE5n+ax7codOasIxreuXAijv2Ww2QHQgRsRrxeNaM6VDOIfDrSYC/dcZhmsV7KFgEzik8h0VR197G0z8PbAmEN/+VfFUpqc0AAsN6Xkb5jBuhNGeW6B0mRNa+mrEYSnbi0wt8G1OUJvgaM35IvglQhU3zx9OnLBL5rqsfMl6GK8r/NCOau5pPMMUxREr1hiA+6gw==; 20:5G3XxJ8kDTJ1RKJue5exwy6znCjMX3F8E2TGNyTpFYlV5qLhmRt7sgs6n70xH+YbH+e3/Eon5HSuDnWYCpbYEYr6qn9Rc7STA4usTbT99oDlSXq7nEaIEHOKbvhybqocE0asJmLEXlFvmXtdpBVHnI3DC6M1sVKfJnaCfAvSejPZjSItHXPaOgrtOzNmyeBczSHm4A3pFagjsEsktlF6bs6CZnRlB6kg1mqPPm4Fx07oPJTsyuwM2Wv2f+7PvuBf9ZRy2Z1ZPV5SE4eyiu6JwwuPqUe8OMN8exSXPMI71nL4286y1g4SKaYvO3t5nRhLv11mdCxRAkYyeUPkxrWfGFC5hWn4c5TF2c+Pqo1d2xBvcukbyLpNcbhUY3EG3uQ2jS8DtCZ0zIQtKPF0waT27dMfPtayd9xy9fVUh/Til5jpnnrk5X6aujd+FSGzhZFrfUJ9tz0jCv8dHq/AtmqywgQSnBNjzY31IU0F4FQVqB9p8BhNuw/E2Y4ICQvkAmPfz6yy3zDQ/c1uhzIbCJxZlJ4WcTStlAX0bDu1cQIKVKXlyK1kTnNGmNMTY8bGjXkyIuaU/i+PWgQM3OnsLka7WJrrsyjHWsaIAVtQAnrFQPo= X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(100000700061)(100105000095)(100000701061)(100105300095)(100000702061)(100105100095)(6040450)(601004)(2401047)(8121501046)(5005006)(10201501046)(3002001)(100000703061)(100105400095)(93006095)(6041248)(20161123560025)(20161123562025)(20161123564025)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(20161123558100)(20161123555025)(6072148)(100000704061)(100105200095)(100000705061)(100105500095); SRVR:MWHPR07MB3071; BCL:0; PCL:0; RULEID:(100000800061)(100110000095)(100000801061)(100110300095)(100000802061)(100110100095)(100000803061)(100110400095)(100000804061)(100110200095); SRVR:MWHPR07MB3071; X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; MWHPR07MB3071; 4:CeCOh+1P3BU74b3qnEWdgAW/ekINap68GydYDSEpGg?= =?us-ascii?Q?v33rgFiar4QtwFyvVx7bG5PmSNO7x+e08XKRJWeCD7rT52GBP3G4A1o7x4cs?= =?us-ascii?Q?QiMgm/ch2B20VAn/sbZGVV8v+Ln+/hlaaXe6nLAACMzz752NSe8wHTsA7i8H?= =?us-ascii?Q?fxFDnBt5jgkxRvgGjXs+sd1oTLJ5S5e2UImll6LEqnVM7avyTy41Pnmb2D8t?= =?us-ascii?Q?gK8noC33CjgrXt2QPG54VPewwtbgzq421a7YZarOtTZ4ln2ib0tJ2piLMEOJ?= =?us-ascii?Q?R5pBI7QKlUwh80BXPWyL0cq6K5e0wFNGJLlSBSjBGwSUHnbnsFn3h+IHI7V2?= =?us-ascii?Q?RnCktJMt9uWzFzS5ZQu+zM7iaQNQoWlO9ShhweYW/t1ZPthRyYUXZ9RcdP9/?= =?us-ascii?Q?Dyf7sbYiZZHHJekCvPaFvc1bVj80JQqPAQ9+mmivyfb+AtZVmmCRhYO8KYKq?= =?us-ascii?Q?uzwLjqWLzJytLmwNe2sUih+VbUqowOJbQkYMEfNIoDUNOWwk4Rl8FFQTCqwt?= =?us-ascii?Q?jULO9wsNZSebOkKk0cDT9u03NvSllceZfpKSpcjfoDKwEAC5lesiRhItP0oy?= =?us-ascii?Q?82GA/+AZyeOLAdgfI504dAdOQVZQH94awkiyrWfzB2tWWk4wfis3hNcZxFMH?= =?us-ascii?Q?HP6d7Xd3HtiOu9/NCiNQ0aR9q6AJq8QEUuR9TxhA4mkp6TuYvYLfzC2MmrdA?= =?us-ascii?Q?ONhb4AKHuABKmxD/z41xfZp2AScYaZZvGjEDKtS0hzL8JmpCq9DHDlF2407T?= =?us-ascii?Q?N12IKgRF6FnoGcQtiAd3F5gXvO4PgF/d5u7A4omCRej1mdxATzQ2p7xHH1h7?= =?us-ascii?Q?O7FiA2QzhSyT9gff7oBQiE49MusqXCmVsyCsICjhszujIXswK5ajF4SZ2uet?= =?us-ascii?Q?Bxdt/TUKj5hf2+mXoQIblJLSg96SUS7T6zlRU8IeHDwycqJhYm3LeUfiDody?= =?us-ascii?Q?HAX6Vgqz91KRp/kntQCDDgFGb54OdtUI83pdmqtHYurH4lQsE/d0SbVxULb/?= =?us-ascii?Q?rcKXz6gjcVp5crMg2jee8Wvxa2Nao8jOFpUyGL64oJvZXG3QerW8q3/gzAfb?= =?us-ascii?Q?kDqpBUXMxpNAuxD9hHZjnswr907SyHaS6cYJHEJFrChm3dypy5hXog84Wh0C?= =?us-ascii?Q?KVMYr09ew=3D?= X-Forefront-PRVS: 031996B7EF X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(4630300001)(6009001)(6069001)(39410400002)(39400400002)(39850400002)(39840400002)(39450400003)(24454002)(189998001)(42186005)(53936002)(305945005)(8676002)(50466002)(81166006)(81156014)(50986999)(54356999)(25786009)(76176999)(55016002)(6506006)(54906002)(4326008)(6246003)(7736002)(83506001)(110136004)(38730400002)(61506002)(2906002)(4001350100001)(47776003)(66066001)(2950100002)(9686003)(5009440100003)(23726003)(33656002)(1076002)(6116002)(478600001)(6666003)(229853002)(42882006)(3846002)(6916009)(72206003)(5660300001)(110426004)(18370500001); DIR:OUT; SFP:1101; SCL:1; SRVR:MWHPR07MB3071; H:localhost.localdomain; FPR:; SPF:None; MLV:nov; PTR:InfoNoRecords; LANG:en; X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; MWHPR07MB3071; 23:m1XRpbTEv78+PKbevg4/ZPNuOiKaUt9yX99ux2l9J?= =?us-ascii?Q?J5L/x8mr7PSjttJyOtZZHfFoNnn3V15ycZ2MLB+LOk0YJCVKWDT+viaMCV2d?= =?us-ascii?Q?ZAO4iTDBCru9Nb4Edt8H6vtnAIZvckz0qoEzx4kP3q9ORQoLXXWKwPd8xrPs?= =?us-ascii?Q?L5EAaTrioiYpCxV/euR7wfwRwOepURkqvN56ZmUe6tmL1kYZGnGXreCrY45A?= =?us-ascii?Q?mvK56DNbnUJKi54ftd71e8tuyJuqgbeGUtyzyPXRrRjEMbdJQ0dWhacm4+hQ?= =?us-ascii?Q?dcbgD9FQfos0gWzwq3Ho1SDBfqA9NZrStXT5at9wWTN1sw5eDgpR1hudrNG+?= =?us-ascii?Q?ecBWOKNKm6vyuVv4CRNSC8QxSCW/SefJyM70VZfScx+s9fCPc+U0tl2n6vJ6?= =?us-ascii?Q?0LcSbGlGly6O0cK88fVT5nnzz8rEaH4ZRB0ruylbWbaD9s4vxVMK2kC07g6m?= =?us-ascii?Q?uhtrjYalZ3ki0SDZyNwqjw08IPswsYOv+33IvmpdsLOc0wp1nafmWtKU2x1X?= =?us-ascii?Q?U3YqyXDE99B0lHcMvIbHN8unAMFTHKLf8h7xfF43o/YRV7Gth86L8RsSPgBp?= =?us-ascii?Q?iOZkehrS+BNob+gMGmNFZwudo7TOL+3C/DVWM1lGFy6KTAhL3wPCqSZbTaNc?= =?us-ascii?Q?8vGlJkuuVn6fXwnxOhJLfM68eIfQw7ozXdtud+C5wTxnBepoEUcgT9C3dsIh?= =?us-ascii?Q?I1oZ0efm8n7HrnQLBfUuH7YD4wADzf/8xfXSBq9ZPyV8YwUNuG4/vciy9coT?= =?us-ascii?Q?h/O++h6RGJft75Y28qdbTB6+fYsR3i4zQfK/iLye/KOtHnz/TWj25rYGtUXp?= =?us-ascii?Q?1apakvWJlg5qfDNz5kclNt3WEKS3RYTMInhl6pyjfcWCpAvpHht4jOLZ8axw?= =?us-ascii?Q?VwUyLQT2kN1WuE+ixO+KphC1zjKdQ5gRiwZv+DjtY5z5M+h1ILox1BEfXH9i?= =?us-ascii?Q?rqG0daM7vtm1NeBdFqnfh1bOC5zyXoe+yJF5+l7ptk1diRmX7kconUuXAGi/?= =?us-ascii?Q?HKJai3/LANKU0PhYpSPDTKpmjstfahA5qAZINy47TdLdOIeJCgdQUu4+JD8M?= =?us-ascii?Q?jCNLDNbw7e/q5aWAEYvYePPLogDu/lCrkFfeUDLFER/5GCp6yFHmBo8jAEdA?= =?us-ascii?Q?yvTtrvE1qLTYLNxN9ALtSNpTc3LEA9EY2djVHD9PcIZIfbBTzYlYAyYJBwiW?= =?us-ascii?Q?1QNxnPnPfHpKfK2Mgu34QLONLBUAG6yguNPox8vHhFX4cqRxHdPqnyWIX3oI?= =?us-ascii?Q?M3eptk1Sk0lvw5dztCx1RCvwhD5DaIAW0UvXfGSx2ESCMFWyOaPH67AlfZWp?= =?us-ascii?B?dz09?= X-Microsoft-Exchange-Diagnostics: 1; MWHPR07MB3071; 6:rleztR0/jDWj1UAP0kYsHkZQdCtYMbNi9FxMjjQpmDkelQ/IZUGn31fuS8BAZSnPq9VMYnvWKiPv79Qww7GVwiMXfJiPst+zbKp7PN0GJXnm4xwI6HJa+RcUdzBDZTM7Qu8yiBJWXxGoeqsi0pfAXIaK20kxwMbLw7gIZUnqTnTomSydUDwqCgSnc/apyRgvW5Rv8pTj6hst1DJ+rl4TtYQQfo8t6G4oqW07HkV4kxD/ZVeLiN8Kyrj36Ys3G9K8eLqzE2BHz01em2c7Sa2DmQbDrbUkdpvfyUHiQdFf2XT6ZgO0XsHNRZ1WzTAFAR9OjYaiL5StSqHhCTsfn8vU5cyWlkmwz1GWz7PHoXEYlv41Is42kqwtdf9PnF8rloFn2s4fWMZzsjvzVjflE5JMs4xVSlr6JAz2xZnX7XS//HJkn0LlkZavJFYD04/ISlng4Rv25fExEqWNBznDpBiKdb7I9M6GbJr2IW7rKpHLiMWqnjCNoOjfFCj8ckG2I6oJUpCZyS7ZcMvweJfW61NL6g== X-Microsoft-Exchange-Diagnostics: 1; MWHPR07MB3071; 5:Knfal3CLyPVCoeIzrx4Zp5bZMbW3XGwpKvYqyOWT7AriG/0yyJWBQub3fiWk/i8cm48wcdzFz32xymgI3w3ZiqSvtv8EC4lEnPWiSHmj05+y5Orp3sl+1iMRFWWBVmRCJ5xdbBhEb7GvEWxz0ncMkPeN/fKfSNTEGoasvU+IviWh4NeJOQndYry5d/OC/u/rxR9/YjWp83tnQgumtU3jAd929hgi6n0XmNeRbNQdFe3TJ41QB9Hyx5tsUkmF2EjgcMGNobTd/qlDcn1ggk/4xkN/oZtnKqKmfgW0DnbHn5uswQYRYHrd3g+ewkZHCThBEP4rIJWadjqlEpwSN34yFjXr1d0jjkQKjMQNdd1aMviQhaPjYLLezK409VmGkjDMF5V6l99rKMFKQsHcl6VxrB3rSuYp2bVa7y+PDU8mI7ZXeHRvP39KrO5mIDzrsE0zDM46sZgJqnMcSXSpQYLrjw==; 24:GYZi0UY7U3ndbxgAoXKQYjYXumXZFRWV1wbsXerPrrokHcfJ3wp7H1P0KVKpxNO86pRHnw8fmcZMJg7rgtPp2//25Dg2/o/aRDk35JFc+r4=; 7:V5cMI74SBpRStUaU9xR9oz/XvvqGXLahxtLQrBXKenTEnN4n7dioqmvjBjh4TpRW3o3owz5e8RyuPAxF4L1GM1hx+qvP8bYOUcj5bnn0d4oYEQit2oBmkCr8hDoATsh31OD3p+rd5WDusLWG74oKjzh21r9e4Fhj4oGYWheY6lDy6Qxi8kCHv5m7EnSJEx13HVJUV/L+fcBbnpM+5HfRrZKmUw8HFsLUW3hA6Iuuxde2Ysok5uwehUPSVmNQ//JW9c6THNrZQjzulcOxyTwJ/+obAPt83+8lBa0jsWav2Sf5gdExA65bgXfRwkIHd0RUczq5xKClud2/BDvIOc5LIg== SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: caviumnetworks.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 May 2017 06:05:25.5509 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR07MB3071 Subject: Re: [dpdk-dev] i40e igb_uio: reset pci on process exit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 26 May 2017 06:05:30 -0000 On Fri, May 26, 2017 at 07:30:58AM +0300, Gregory Etelson wrote: Hi Gregory, The patch is useful for LiquidIO PMD as we can avoid VF FLR request to PF. One comment inline.. [..] > > > > > > +static int > > > +igbuio_pci_release(struct uio_info *info, struct inode *inode) > > > +{ > > > + int ret; > > > + struct rte_uio_pci_dev *udev = info->priv; > > > + struct pci_dev *dev = udev->pdev; > > > + ret = __pci_reset_function(dev); s/__pci_reset_function/pci_reset_function > > > + dev_info(&dev->dev, "pci_reset_function %s \n", > > > + ret == 0 ? "succeded" : "failed"); > > > + return 0; > > > +} [..] Thanks, Shijith