From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <stephen@networkplumber.org>
Received: from mail-pf0-f180.google.com (mail-pf0-f180.google.com
 [209.85.192.180]) by dpdk.org (Postfix) with ESMTP id 7824AA0E4
 for <dev@dpdk.org>; Fri, 26 May 2017 17:53:24 +0200 (CEST)
Received: by mail-pf0-f180.google.com with SMTP id e193so15287709pfh.0
 for <dev@dpdk.org>; Fri, 26 May 2017 08:53:23 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=networkplumber-org.20150623.gappssmtp.com; s=20150623;
 h=date:from:to:cc:subject:message-id:in-reply-to:references
 :mime-version:content-transfer-encoding;
 bh=MOq5853MsV4lQJWmh1RErDXS7yQRngY6GKcknDMBbbs=;
 b=JLs3tYrDkB5igXe08veY4oJRxIBe29siJLOD9o6Q4jd/JVn5SihlBwWX+O55rIy5wU
 6Cl5tcGmXMpPt26OnhZuFgTZUqWdeanV5eIQJkIF+OzGz6Ci1qGf8JB7lS5veZ0QrIE2
 H5aNfhKcxa3SSwGRTB0EKFIgk3Qw0MbCOrQ2XHlK8qTtwKLEyUXvDghnEaqBZDnUMv8M
 hWBFAj2dlMVRZMmC6/dl5RyF4Yzt7EvwOxZ2hgDcOdfncK/EEo1oEIeuJOJs/wQWOjxW
 68J4KnHBVhgeVzz3sLXtjyC6WKyZY8TGqJ1nLkjJNe9X9UqwQQ8bepKctozc/ibmSIz5
 yCMw==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20161025;
 h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to
 :references:mime-version:content-transfer-encoding;
 bh=MOq5853MsV4lQJWmh1RErDXS7yQRngY6GKcknDMBbbs=;
 b=eManHqtdjvM9iEaHgCuJU9GM2L3DbvxBBo51z8gv0v/u4MbHXVpr36omKc7gGRrhlu
 RfROtuqDxK/MLeRWqpju+rybbjJ5HHbBm31vu9lCFDWHepVkjJWnsNKPpIpPVlzSn13D
 geGn2JdUraoMb318c+ODOgH5tVTSOkEW0DY45xBPSy+AD4hF+0LBqmzVSizpRiP6MsU8
 /cANpBti548zOcfeQpK52UBMyzRPLx6xKi5gwKPJLxNv5EpfNH3B7NwiNE3ksfKPuobw
 w9MUsxaea3/xAV7onlDB30M2mf1ySSQ4qUfq+m1+QEiVXzRFnpYxZffBWKeTDGUNXdaG
 3ANQ==
X-Gm-Message-State: AODbwcDjfaT9fCvWPa9fjkTriZAjXjiVFBVkI7h5TkS0ok2VQHk+TRt9
 8xi8oZZZb+naa9xf
X-Received: by 10.99.95.88 with SMTP id t85mr3352524pgb.50.1495814003246;
 Fri, 26 May 2017 08:53:23 -0700 (PDT)
Received: from xeon-e3 (76-14-207-240.or.wavecable.com. [76.14.207.240])
 by smtp.gmail.com with ESMTPSA id b2sm2305495pgc.16.2017.05.26.08.53.22
 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256);
 Fri, 26 May 2017 08:53:23 -0700 (PDT)
Date: Fri, 26 May 2017 08:53:21 -0700
From: Stephen Hemminger <stephen@networkplumber.org>
To: Gregory Etelson <gregory@weka.io>
Cc: Shijith Thotton <shijith.thotton@caviumnetworks.com>, dev@dpdk.org,
 Ferruh Yigit <ferruh.yigit@intel.com>, Qi Zhang <qi.z.zhang@intel.com>,
 Wenzhuo Lu <wenzhuo.lu@intel.com>
Message-ID: <20170526085321.75582301@xeon-e3>
In-Reply-To: <2910302.37N35vC6kd@polaris>
References: <106841857.Z7q1jSDIte@polaris> <2080347.1TTqQevoe3@polaris>
 <20170526060509.GA5157@localhost.localdomain>
 <2910302.37N35vC6kd@polaris>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Subject: Re: [dpdk-dev] i40e igb_uio: reset pci on process exit
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Fri, 26 May 2017 15:53:24 -0000

On Fri, 26 May 2017 09:17:33 +0300
Gregory Etelson <gregory@weka.io> wrote:

> Thank you.
> 
> Regards,
> Gregory
> 
> On Friday, 26 May 2017 09:05:11 IDT Shijith Thotton wrote:
> > On Fri, May 26, 2017 at 07:30:58AM +0300, Gregory Etelson wrote:
> > 
> > Hi Gregory,
> > 
> > The patch is useful for LiquidIO PMD as we can avoid VF FLR request to
> > PF. One comment inline..
> > 
> > [..]
> > > > >  
> > > > > +static int
> > > > > +igbuio_pci_release(struct uio_info *info, struct inode *inode)
> > > > > +{
> > > > > +       int ret;
> > > > > +       struct rte_uio_pci_dev *udev = info->priv;
> > > > > +       struct pci_dev *dev = udev->pdev;
> > > > > +       ret = __pci_reset_function(dev);
> > 
> > s/__pci_reset_function/pci_reset_function
> > 
> > > > > +       dev_info(&dev->dev, "pci_reset_function %s \n",
> > > > > +                 ret == 0 ? "succeded" : "failed");
> > > > > +       return 0;
> > > > > +}
> > [..]
> > 
> > Thanks,
> > Shijith
> > 
> 

What does VFIO do?

It looks like in vfio case pci_enable is held off until open and pci_disable is done
on close. There are other things that may need to be done to make close work
correctly. Like turning of msix. Also reset may not always be possible.