From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f42.google.com (mail-wm0-f42.google.com [74.125.82.42]) by dpdk.org (Postfix) with ESMTP id 6A7F023B for ; Tue, 30 May 2017 15:29:39 +0200 (CEST) Received: by mail-wm0-f42.google.com with SMTP id m7so27805916wmg.0 for ; Tue, 30 May 2017 06:29:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=jNhSRO0mdZagjYidgsnApKoNs9siFYjLPtP14a4XSqQ=; b=PU6Xn95h9rIRJiw5Da7tabN5CSNcchjbbevDSjdt3y+BXEnwHYvKPpVqc2qs6mY9PP B863SkHdKiX6aww+rIwJ3q9HsM/O0Qs0VrAUqzxEv2dLjO4Tr2Gf2o9RyEnOlJpHiL2/ zrE8rPb3rUxU3qllODebS9CPJ4Na67mIEUgS52yCSQVBbUW7vMW5mqA+62EtatgkhOwR z2E845Wb4kSbbYBjDWv+PucOjRHraUg3+COyNc1iKd0PPE6aTvVPSbj3uKRAXJMlkbkI sgcKaRkcomNbb9650NPu6Of4xrUoPteK1ljpwonKB3taprUu/3IV85BvC9NVvk0wNNJ1 MihA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=jNhSRO0mdZagjYidgsnApKoNs9siFYjLPtP14a4XSqQ=; b=LXVYWucPZn646THmqjH6oYzjO0dAE8AYFEwB6AxCaZWKbbX5xAjbf1UY0eGaOe8qza uaDJcQCA6wg/OFVeWLcPHaU6BLP8sCdql9rfsZs0qS2xMTrxNuGE/t25FtctcRj5uAXY Xtq3Z4OSObcLZUVoOUqxR6SvarpXTnh2LRHweum4AFEX6OpDcll7Hw9K2R0v+H+ch7zm X7LBqisMs3eN22HWs26PhzExV2wJK2KgcCDLwBdoBS0e7zPK2y4tjz6urmSlo2IHLZeA I/m/BYtKiWnMKZxbCjEAQcLsddsAcXzNrUFb1O7D49APp7QhOfdkod24pqOMpMrraMug /a3g== X-Gm-Message-State: AODbwcChdHGci5aMx0MZXd09JtpmtXhmDB1WI0iaYT/B2mbRwv4eB9hT xGsX6Xt5MS/AbSwR1EI= X-Received: by 10.28.206.67 with SMTP id e64mr1861933wmg.104.1496150979030; Tue, 30 May 2017 06:29:39 -0700 (PDT) Received: from 6wind.com (host.78.145.23.62.rev.coltfrance.com. [62.23.145.78]) by smtp.gmail.com with ESMTPSA id r186sm11024074wmr.30.2017.05.30.06.29.37 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 30 May 2017 06:29:38 -0700 (PDT) Date: Tue, 30 May 2017 15:29:32 +0200 From: Adrien Mazarguil To: Moti Haimovsky Cc: dev@dpdk.org, vasilyf@mellanox.com Message-ID: <20170530132932.GB1758@6wind.com> References: <1495984291-66861-1-git-send-email-motih@mellanox.com> <1495987898-70002-1-git-send-email-motih@mellanox.com> <1495987898-70002-2-git-send-email-motih@mellanox.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1495987898-70002-2-git-send-email-motih@mellanox.com> Subject: Re: [dpdk-dev] [PATCH v2] net/mlx4: support user space rxq interrupt event X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 30 May 2017 13:29:39 -0000 On Sun, May 28, 2017 at 07:11:38PM +0300, Moti Haimovsky wrote: > Implement rxq interrupt callbacks > > Signed-off-by: Moti Haimovsky Hi Moti, While this patch is almost identical to its mlx5 counterpart, I have one minor nit (see below). Besides that: Acked-by: Adrien Mazarguil > --- > doc/guides/nics/features/mlx4.ini | 1 + > doc/guides/rel_notes/release_17_08.rst | 5 + > drivers/net/mlx4/mlx4.c | 218 ++++++++++++++++++++++++++++++++- > drivers/net/mlx4/mlx4.h | 1 + > 4 files changed, 219 insertions(+), 6 deletions(-) [...] > diff --git a/drivers/net/mlx4/mlx4.c b/drivers/net/mlx4/mlx4.c > index ec4419a..95ab325 100644 > --- a/drivers/net/mlx4/mlx4.c > +++ b/drivers/net/mlx4/mlx4.c > @@ -75,6 +75,7 @@ > #include > #include > #include > +#include > > /* Generated configuration header. */ > #include "mlx4_autoconf.h" > @@ -127,6 +128,30 @@ struct mlx4_conf { > NULL, > }; > > +static void > +mlx4_dev_link_status_handler(void *); > + > +static void > +mlx4_dev_interrupt_handler(void *); > + I understand the need for a clean up, however these definitions are not related to this patch. [...] > > -static void > -mlx4_dev_link_status_handler(void *); > -static void > -mlx4_dev_interrupt_handler(void *); > - Please leave them here. -- Adrien Mazarguil 6WIND