From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f53.google.com (mail-wm0-f53.google.com [74.125.82.53]) by dpdk.org (Postfix) with ESMTP id E1781911D for ; Wed, 31 May 2017 09:51:36 +0200 (CEST) Received: by mail-wm0-f53.google.com with SMTP id 7so109435137wmo.1 for ; Wed, 31 May 2017 00:51:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to :user-agent; bh=zJXQXPRceewSA5t00i96LNBrtXIgBKk1vMjZgdjssvM=; b=MP3FwbsCs3SSky3KyNP4TrTwxBmkP0eFm9a1SEeYd5g3fz3xFNUHKOAZR433ajEKv+ ebc4419udcH8tds3xLXfFPYYyZXIfrxnokQNQjM+EG/nfqhNQVJMY/Z8WSqehnnNZJ6X tsUw9/zAdmXOqd3NdWInuFAowFRiJjtljaTJGD5vWfS2gThikdXw77ScatISyS5QZFoz TNn4bcqSqA+bY9kzmYmRw/rgDvSDGBB94H3dHQAS+0d4icl1VtzL9Xz2kCyaECf+Af9U QroQIszHaFp5XMvwYHgxZk8GAwlSOCw44wd5bGB1uCfCnZqAGhPx/w5Eal9GAOaIoGR3 qaKw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to:user-agent; bh=zJXQXPRceewSA5t00i96LNBrtXIgBKk1vMjZgdjssvM=; b=DrleFOWNmOlGWezaOXhM0di4dYJ6kOy9TS2R+SQ//RqF6waVkgUjLe8pICXHEDgMV0 jVATHBYOc0xKywFwpkSx2k0xrQ7cLOL5GH3RP1Ha4dpjOtUTY6fiF6ro0pptM3Y9ckx/ x0kQYCgEJVE5j/nhvCSLbdGBvC2a/TT7Yy7V45X0cUHpKYwFBwBA8ZsGqE6AqSasGUgR nQihKNYBpcXEAPtV99KNJ4bEy0fYbtCgd9JQLfFHrxGic9A29dKaJLRkc+GqvFHuKLcS jJSwfZM6Jh2G/EpH+0o7qeC0GaelpBtlpXP01SwrVjnxNmxzJYZPg3crXkIB0WXgHKWr dZog== X-Gm-Message-State: AODbwcC4mEFReQoIGJVPxeIkuQ9/VZ8tJPNYUvL1+Cc/I8MG77rCAN2L GPZVZw7SzyV96tOUr70= X-Received: by 10.28.236.71 with SMTP id k68mr4469812wmh.107.1496217096664; Wed, 31 May 2017 00:51:36 -0700 (PDT) Received: from bidouze.vm.6wind.com (host.78.145.23.62.rev.coltfrance.com. [62.23.145.78]) by smtp.gmail.com with ESMTPSA id 140sm11944913wmu.23.2017.05.31.00.51.35 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 31 May 2017 00:51:35 -0700 (PDT) Date: Wed, 31 May 2017 09:51:30 +0200 From: =?iso-8859-1?Q?Ga=EBtan?= Rivet To: Qi Zhang , dev@dpdk.org Cc: Adrien Mazarguil , "Mcnamara, John" Message-ID: <20170531075129.GP14914@bidouze.vm.6wind.com> References: <1495582134-13665-1-git-send-email-qi.z.zhang@intel.com> <20170530124630.GA1758@6wind.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1; format=flowed Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20170530124630.GA1758@6wind.com> User-Agent: Mutt/1.5.23 (2014-03-12) Subject: Re: [dpdk-dev] [PATCH] ethdev: add roughly match pattern X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 31 May 2017 07:51:37 -0000 On Tue, May 30, 2017 at 02:46:30PM +0200, Adrien Mazarguil wrote: >Hi Zhang, > >You should cram "flow API" somewhere in the title of such commits. > >On Tue, May 23, 2017 at 07:28:54PM -0400, Qi Zhang wrote: >> Add new meta pattern item RTE_FLOW_TYPE_ITEM_ROUGHLY. >> >> This is for device that support no-perfect match option. >> Usually a no-perfect match is fast but the cost is accuracy. >> i.e. Signature Match only match pattern's hash value, but it is >> possible two different patterns have the same hash value. >> >> Matching accuracy level can be configure by subfield threshold. >> Driver can divide the range of threshold and map to different >> accuracy levels that device support. >> >> Signed-off-by: Qi Zhang > >While I really like the "roughly" pattern item name since it perfectly >describes its intended purpose in my opinion, perhaps some may not find this >name appropriate. I would like to hear other people's opinion on the matter >and not be the only one to ack this patch. "no-perfect" has been used a few times in the documentation. How about "IMPERFECT" as item name? -- Gaëtan Rivet 6WIND