From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <stephen@networkplumber.org>
Received: from mail-pg0-f50.google.com (mail-pg0-f50.google.com [74.125.83.50])
 by dpdk.org (Postfix) with ESMTP id 7531D7CDA
 for <dev@dpdk.org>; Wed, 31 May 2017 17:29:11 +0200 (CEST)
Received: by mail-pg0-f50.google.com with SMTP id u13so37619pgb.0
 for <dev@dpdk.org>; Wed, 31 May 2017 08:29:11 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=networkplumber-org.20150623.gappssmtp.com; s=20150623;
 h=date:from:to:cc:subject:message-id:in-reply-to:references
 :mime-version:content-transfer-encoding;
 bh=bVg2vdMRrHemmAbh1qXkXYndWlDNQt5rnc1ni3DXcaw=;
 b=nVIDd1PVaY6pPf6NAEgi6Ki5Qj+FHkVqQEY8nWJ0S9geUOq0AegL96IQkR+Keq1yjI
 BwYI1jOxISxJRKdAiSXhYEL4s9AEVo3y8yawSmessetT+Q4vHpoVfzzpt1lz4PvBgBy0
 ZLE2vmpxA/4mwZc/bkn3BWXhkM9cyf88YTZhgbouU80tjNZccRNPZQoZpjnoVzYTMKzt
 v7nBTyThU7kfI3zqFVPV1G+IJ4LNouAp695MJX82Mi092X+o3w4h7ho1g0wKFtOEIynn
 Yd3512yZBeN1TNi83cHWn5Onorivj3xKuB5EH+e7EubhzF57rZQ6Z7QjbBWrtA/MsZht
 gUpw==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20161025;
 h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to
 :references:mime-version:content-transfer-encoding;
 bh=bVg2vdMRrHemmAbh1qXkXYndWlDNQt5rnc1ni3DXcaw=;
 b=lHSV/NRLzahJ0tXaqh0apwI8xG+pXgWeIHeJwmtA9MHutTQSKmXq5iHwJiDNqopl4b
 JMV+IS8CqkNB4ZMR/pgvVBoMWeeEG4GLARU81w45oCQf3UU0lBSPNo+wcr3cnVE0miSO
 +mnEO2M1R7NcV9tbhUszU5qkh41Rrc2A5mgfOpK6j5taD2N1phm1iQgIsEu5W0SXHbRB
 jwfLxlUFI0HWZp1KfcyP0o2l7U9hOsIGJ0RCP8QgGUlsV2Jww8hNMifTa2oOr5dfCwmN
 +AX3ExKbWasLXywyi6huYx7AOELFMUjwVvPRHniUIjq+raH2ZYlzqaT1iAkN4DaPeUzD
 2ArA==
X-Gm-Message-State: AODbwcBJL8nTw0yeKoDQe4SnpiEomiFiaOe5ukuFqeUSfglZz9UxkZ9Z
 4AacUMd9rJ73tq2+rSUWEw==
X-Received: by 10.98.198.130 with SMTP id x2mr30811129pfk.232.1496244550561;
 Wed, 31 May 2017 08:29:10 -0700 (PDT)
Received: from xeon-e3 (76-14-207-240.or.wavecable.com. [76.14.207.240])
 by smtp.gmail.com with ESMTPSA id b72sm29062961pfd.118.2017.05.31.08.29.10
 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256);
 Wed, 31 May 2017 08:29:10 -0700 (PDT)
Date: Wed, 31 May 2017 08:29:08 -0700
From: Stephen Hemminger <stephen@networkplumber.org>
To: Shijith Thotton <shijith.thotton@caviumnetworks.com>
Cc: Gregory Etelson <gregory@weka.io>, dev@dpdk.org, Ferruh Yigit
 <ferruh.yigit@intel.com>, Qi Zhang <qi.z.zhang@intel.com>, Wenzhuo Lu
 <wenzhuo.lu@intel.com>, Thomas Monjalon <thomas@monjalon.net>
Message-ID: <20170531082908.5f649efc@xeon-e3>
In-Reply-To: <1496228966-18573-1-git-send-email-shijith.thotton@caviumnetworks.com>
References: <1748341.rbpcFmWp0q@polaris>
 <1496228966-18573-1-git-send-email-shijith.thotton@caviumnetworks.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Subject: Re: [dpdk-dev] [RFC PATCH] igb_uio: issue FLR during open and
 release of device file
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Wed, 31 May 2017 15:29:11 -0000

On Wed, 31 May 2017 16:39:26 +0530
Shijith Thotton <shijith.thotton@caviumnetworks.com> wrote:

> +	/* reset the pci device */
> +	pci_reset_function(dev);

It is not considered best practice to comment the obvious.
This comment borders on being the classic /* add one to i */