[dpdk-dev] [PATCH] eventdev: clarify the worker thread workflow

[dpdk-dev] [PATCH] eventdev: clarify the worker thread workflow

[Jerin Jacob]

If the RTE_EVENT_DEV_CAP_DISTRIBUTED_SCHED capability flag
is not set indicates the device is centralized and thus needs
a dedicated scheduling thread that repeatedly calls
rte_event_schedule().

Update the worker thread code snippet to match
the description.

Signed-off-by: Jerin Jacob <jerin.jacob@caviumnetworks.com>
---
 lib/librte_eventdev/rte_eventdev.h | 23 +++++++++--------------
 1 file changed, 9 insertions(+), 14 deletions(-)

diff --git a/lib/librte_eventdev/rte_eventdev.h b/lib/librte_eventdev/rte_eventdev.h
index 94284337d..a248fe90e 100644
--- a/lib/librte_eventdev/rte_eventdev.h
+++ b/lib/librte_eventdev/rte_eventdev.h
@@ -199,20 +199,6 @@
  * operation. Instead, Event drivers export Poll-Mode enqueue and dequeue
  * functions to applications.
  *
- * An event driven based application has following typical workflow on fastpath:
- * \code{.c}
- *	while (1) {
- *
- *		rte_event_schedule(dev_id);
- *
- *		rte_event_dequeue(...);
- *
- *		(event processing)
- *
- *		rte_event_enqueue(...);
- *	}
- * \endcode
- *
  * The events are injected to event device through *enqueue* operation by
  * event producers in the system. The typical event producers are ethdev
  * subsystem for generating packet events, CPU(SW) for generating events based
@@ -237,6 +223,15 @@
  * indicates the device is centralized and thus needs a dedicated scheduling
  * thread that repeatedly calls rte_event_schedule().
  *
+ * An event driven worker thread has following typical workflow on fastpath:
+ * \code{.c}
+ *	while (1) {
+ *		rte_event_dequeue_burst(...);
+ *		(event processing)
+ *		rte_event_enqueue_burst(...);
+ *	}
+ * \endcode
+ *
  */
 
 #ifdef __cplusplus
-- 
2.13.0

Re: [dpdk-dev] [PATCH] eventdev: clarify the worker thread workflow

[Bruce Richardson]

On Thu, May 18, 2017 at 04:40:41PM +0530, Jerin Jacob wrote:
> If the RTE_EVENT_DEV_CAP_DISTRIBUTED_SCHED capability flag
> is not set indicates the device is centralized and thus needs
> a dedicated scheduling thread that repeatedly calls
> rte_event_schedule().
> 
> Update the worker thread code snippet to match
> the description.
> 
> Signed-off-by: Jerin Jacob <jerin.jacob@caviumnetworks.com>
> ---
Acked-by: Bruce Richardson <bruce.richardson@intel.com>

Re: [dpdk-dev] [PATCH] eventdev: clarify the worker thread workflow

[Jerin Jacob]

-----Original Message-----
> Date: Thu, 18 May 2017 12:20:59 +0100
> From: Bruce Richardson <bruce.richardson@intel.com>
> To: Jerin Jacob <jerin.jacob@caviumnetworks.com>
> CC: dev@dpdk.org, harry.van.haaren@intel.com, hemant.agrawal@nxp.com,
>  gage.eads@intel.com, nipun.gupta@nxp.com, narender.vangati@intel.com
> Subject: Re: [dpdk-dev] [PATCH] eventdev: clarify the worker thread workflow
> User-Agent: Mutt/1.8.0 (2017-02-23)
> 
> On Thu, May 18, 2017 at 04:40:41PM +0530, Jerin Jacob wrote:
> > If the RTE_EVENT_DEV_CAP_DISTRIBUTED_SCHED capability flag
> > is not set indicates the device is centralized and thus needs
> > a dedicated scheduling thread that repeatedly calls
> > rte_event_schedule().
> > 
> > Update the worker thread code snippet to match
> > the description.
> > 
> > Signed-off-by: Jerin Jacob <jerin.jacob@caviumnetworks.com>
> > ---
> Acked-by: Bruce Richardson <bruce.richardson@intel.com>

Applied to dpdk-next-eventdev/master. Thanks.

>