From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by dpdk.org (Postfix) with ESMTP id 33B467CFC; Fri, 2 Jun 2017 10:20:43 +0200 (CEST) Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 565E4CED6; Fri, 2 Jun 2017 08:20:42 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 565E4CED6 Authentication-Results: ext-mx06.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx06.extmail.prod.ext.phx2.redhat.com; spf=pass smtp.mailfrom=jfreiman@redhat.com DKIM-Filter: OpenDKIM Filter v2.11.0 mx1.redhat.com 565E4CED6 Received: from localhost (dhcp-192-218.str.redhat.com [10.33.192.218]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 1B6A760A99; Fri, 2 Jun 2017 08:20:39 +0000 (UTC) Date: Fri, 2 Jun 2017 10:20:38 +0200 From: Jens Freimann To: Yuanhan Liu Cc: dev@dpdk.org, Maxime Coquelin , stable@dpdk.org Message-ID: <20170602082038.cnuizul6wrfgdesi@dhcp-192-218.str.redhat.com> References: <1496362486-1741-1-git-send-email-yuanhan.liu@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1496362486-1741-1-git-send-email-yuanhan.liu@linux.intel.com> User-Agent: NeoMutt/20170428 (1.8.2) X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.30]); Fri, 02 Jun 2017 08:20:42 +0000 (UTC) Subject: Re: [dpdk-dev] [PATCH] vhost: fix crash on NUMA X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 02 Jun 2017 08:20:43 -0000 On Fri, Jun 02, 2017 at 08:14:46AM +0800, Yuanhan Liu wrote: > The queue allocation was changed, from allocating one queue-pair at a > time to one queue at a time. Most of the changes have been done, but > just with one being missed: the size of coping the old queue is still s/coping/copying/ ? > based on queue-pair at numa_realloc(), which leads to overwritten issue. > As a result, crash may happen. > > Fix it by specifying the right copy size. Also, the net queue macros > are not used any more. Remove them. > > Fixes: ab4d7b9f1afc ("vhost: turn queue pair to vring") > > Cc: stable@dpdk.org > Reported-by: Ciara Loftus > Signed-off-by: Yuanhan Liu > --- > lib/librte_vhost/vhost_user.c | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) > Reviewed-by: Jens Freimann