From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pg0-f66.google.com (mail-pg0-f66.google.com [74.125.83.66]) by dpdk.org (Postfix) with ESMTP id DE49C7CDF for ; Sun, 4 Jun 2017 05:08:37 +0200 (CEST) Received: by mail-pg0-f66.google.com with SMTP id v14so2331406pgn.1 for ; Sat, 03 Jun 2017 20:08:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fridaylinux-org.20150623.gappssmtp.com; s=20150623; h=from:date:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=m94h/rNg176O5e5UkqUmknEXY/oNUJ3H5DwK0Dg8TkU=; b=llDN6oT6ajTfYIgza7pHVsEIS25F4A5nsN1b6+yehit2vC/MF0/zJSQmjpiuGs03Uo 7iVC3/VyYMLZL7rdlFT5UKzENPsBJ2PwI7taztd2kEMb5DR9V7GQZaFMTbCxxpEf+bmt sRGAe0VFGGezb/uKCJ09Zy5ZYMiNmmace62SeLPGMEGwakutc66RVmHBaD3J//vnx2pM fNENKfNL6VzCH49xAJU6UxBh+bs2ibWNYLg9vARIO1aog7ZfzkPksgtDPwIaXkxuNdsT soN2dDuFZXkvN+iVoku7EWi1vXmVihU0VuuDWh2g2USpy3r1rqv3IGMLdvcUIqNCuY4+ opgw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:date:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=m94h/rNg176O5e5UkqUmknEXY/oNUJ3H5DwK0Dg8TkU=; b=HD6x0Dx+MxUCrG7BXDrRvfABFgdQo3mTtsIPQ1e0RMjEEKIGSSMIAmp1U+WO3my4D7 VACJxTRfwz1SxFoGyFu1xWyUYlSmkYW8rP6LFP8SwwqLFLgT5pJPdv+t4XJHyfVdZdc1 vhs4WaEQRXUosksfqkhQ8XQtfBtUSntukv1Ov0KXBCZuUQkzP8d0q3i8jyYnY1Lz0R4o o+Zlm6MC0nR2VC57HTFEUUXahmxLDLz1teLMcoVs9StlCO9nsyZFwdb+dI2SxlUH6NXf PJaScnW4ufDTvDVxq+faFrLTrK90rgOgYkY81FGpi7JR/vewN682Hk+qEx5AL7cfHDCJ J8GA== X-Gm-Message-State: AODbwcA5zr+SNRPHwqBi2GD9NCClWTbNSHqu5uGtU+UwzUH5G0E6oucF DyKSF6NH+kQcoBnl X-Received: by 10.99.163.110 with SMTP id v46mr14957651pgn.210.1496545716965; Sat, 03 Jun 2017 20:08:36 -0700 (PDT) Received: from yliu-home ([45.63.61.64]) by smtp.gmail.com with ESMTPSA id m80sm48180406pfg.107.2017.06.03.20.08.34 (version=TLS1 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Sat, 03 Jun 2017 20:08:35 -0700 (PDT) From: Yuanhan Liu X-Google-Original-From: Yuanhan Liu Date: Sun, 4 Jun 2017 11:08:29 +0800 To: Jens Freimann Cc: dev@dpdk.org, Maxime Coquelin , stable@dpdk.org Message-ID: <20170604030430.GA10168@yliu-home> References: <1496362486-1741-1-git-send-email-yuanhan.liu@linux.intel.com> <20170602082038.cnuizul6wrfgdesi@dhcp-192-218.str.redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170602082038.cnuizul6wrfgdesi@dhcp-192-218.str.redhat.com> User-Agent: Mutt/1.6.1 (2016-04-27) Subject: Re: [dpdk-dev] [dpdk-stable] [PATCH] vhost: fix crash on NUMA X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 04 Jun 2017 03:08:38 -0000 On Fri, Jun 02, 2017 at 10:20:38AM +0200, Jens Freimann wrote: > On Fri, Jun 02, 2017 at 08:14:46AM +0800, Yuanhan Liu wrote: > > The queue allocation was changed, from allocating one queue-pair at a > > time to one queue at a time. Most of the changes have been done, but > > just with one being missed: the size of coping the old queue is still > > s/coping/copying/ ? right, thanks. > > > based on queue-pair at numa_realloc(), which leads to overwritten issue. > > As a result, crash may happen. > > > > Fix it by specifying the right copy size. Also, the net queue macros > > are not used any more. Remove them. > > > > Fixes: ab4d7b9f1afc ("vhost: turn queue pair to vring") > > > > Cc: stable@dpdk.org > > Reported-by: Ciara Loftus > > Signed-off-by: Yuanhan Liu > > --- > > lib/librte_vhost/vhost_user.c | 4 +--- > > 1 file changed, 1 insertion(+), 3 deletions(-) > > > > Reviewed-by: Jens Freimann Applied to dpdk-next-virtio. --yliu