Re: [dpdk-dev] [PATCH] mk: allow exec-env specific targets

[Jerin Jacob <jerin.jacob@caviumnetworks.com>]

-----Original Message-----
> Date: Tue, 06 Jun 2017 09:16:34 +0200
> From: Thomas Monjalon <thomas@monjalon.net>
> To: Jerin Jacob <jerin.jacob@caviumnetworks.com>
> Cc: dev@dpdk.org
> Subject: Re: [dpdk-dev] [PATCH] mk: allow exec-env specific targets
> 
> 06/06/2017 09:02, Jerin Jacob:
> > From: Thomas Monjalon <thomas@monjalon.net>
> > > 06/06/2017 08:36, Jerin Jacob:
> > > > Add a hook in generic rte.sdkbuild.mk file
> > > > to include exec-env specific targets.
> > > > 
> > > > Signed-off-by: Jerin Jacob <jerin.jacob@caviumnetworks.com>
> > > > ---
> > > > Useful in integrating some custom targets in nonstandard execution environments.
> > > > For example, a bare-metal-simulator exec execution environment may need
> > > > a target to run the dpdk applications.
> > > > ---
> > > 
> > > This patch is just including an empty file.
> > 
> > Do you like to add check for the file is present or not ? and if present,
> > invoke the file.
> 
> The dash prefixing does the check:
> -include

OK

> 
> > > Please explain how it can help with a real example.
> > 
> > We are evaluating on running DPDK on a nonstandard execution environment like
> > bare metal where I would to keep all my execution environment specific
> > change at following location. So that I can easy move around different
> > version of DPDK without merge conflict.
> > 
> > $(RTE_SDK)mk/exec-env/my-exec-env
> > $(RTE_SDK)lib/librte_eal/my-exec-env
> > 
> > I believe, The existing target like "exec-env-appinstall" in mk/exec-env/linuxapp/rte.app.mk,
> > solves the same purpose.
> 
> I do not understand.
> If you want to add a new environment, why not just adding it?

I do not understand it either. In exiting makefile infrastructure,
How do you add an exec environment specific target(s) with out changing
the common code?

>