Re: [dpdk-dev] [PATCH] eventdev: remove PCI dependency

[Jerin Jacob <jerin.jacob@caviumnetworks.com>]

-----Original Message-----
> Date: Tue, 6 Jun 2017 10:09:21 +0200
> From: Gaëtan Rivet <gaetan.rivet@6wind.com>
> To: Jerin Jacob <jerin.jacob@caviumnetworks.com>
> Cc: dev@dpdk.org, bruce.richardson@intel.com, harry.van.haaren@intel.com,
>  hemant.agrawal@nxp.com, gage.eads@intel.com, nipun.gupta@nxp.com
> Subject: Re: [dpdk-dev] [PATCH] eventdev: remove PCI dependency
> User-Agent: Mutt/1.5.23 (2014-03-12)
> 
> On Tue, Jun 06, 2017 at 08:35:48AM +0530, Jerin Jacob wrote:
> > -----Original Message-----
> > > Date: Mon, 5 Jun 2017 14:55:55 +0200
> > > From: Gaëtan Rivet <gaetan.rivet@6wind.com>
> > > To: Jerin Jacob <jerin.jacob@caviumnetworks.com>
> > > Cc: dev@dpdk.org, bruce.richardson@intel.com, harry.van.haaren@intel.com,
> > >  hemant.agrawal@nxp.com, gage.eads@intel.com, nipun.gupta@nxp.com
> > > Subject: Re: [dpdk-dev] [PATCH] eventdev: remove PCI dependency
> > > User-Agent: Mutt/1.5.23 (2014-03-12)
> > > 
> > > Hi Jerin,
> > 
> > Hi Gaëtan,
> > 
> > > 
> > > On Thu, Jun 01, 2017 at 10:11:46PM +0530, Jerin Jacob wrote:
> > > > Remove the PCI dependency from generic data structures
> > > > and moved the PCI specific code to rte_event_pmd_pci*
> > > > 
> > > 
> > > Thanks for working on this.
> > > 
> > > Do you plan on removing rte_pci.h in rte_eventdev_pmd.h? Do you think it
> > > would be feasible?
> > 
> > That is for PCI PMD specific probe(rte_event_pmd_pci_probe() and rte_event_pmd_pci_remove()),
> > More like, lib/librte_ether/rte_ethdev_pci.h functions in ethdev.
> > So, I think, It is OK to keep rte_pci.h for PMD specific functions.
> > 
> > 
> 
> Ok, sure. However rte_eventdev.c includes both rte_pci.h and
> rte_eventdev_pmd.h. Can it be made independent from the PMD specific
> include?

Sure. I will remove rte_pci.h from rte_eventdev.c and send the v2.