From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wr0-f181.google.com (mail-wr0-f181.google.com [209.85.128.181]) by dpdk.org (Postfix) with ESMTP id 9295123B for ; Wed, 7 Jun 2017 11:27:33 +0200 (CEST) Received: by mail-wr0-f181.google.com with SMTP id q97so3414251wrb.2 for ; Wed, 07 Jun 2017 02:27:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to :user-agent; bh=T1UkNBTUF37pyhUmFNJ5V3Fp66WXmaKWtlOFlQTJfWw=; b=tRcFaNt2dzM6IgbhhroijP1PxK4m3S6ue01kLqRb27FaRAAUoBXQai9ke2a8SQYfgj UmlwjZPLT2kGzpzb9kinNZG1d7J2cknrkfExwZ6YgfteZlxdBmi6lNS0xMCkbN1W1o+D QK2i5REcjesIz8elxLPujxE9pQcwsh6PXEpOz3esNGfNUDNlA+/tyOIEgmau1Eu8IjHK srKTW/I2LNW5mXO7ByzNQsFE8fGbnECJlEt8bdZit3am1JlexAkgva4YlbzqvshEuG/8 Drs11VlBHvx9YIba66RlGXtZR0jo0YlTW9A0ATgLmhfK60hHMMdTWMhsRmRdVdeLJHkR LrSg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to:user-agent; bh=T1UkNBTUF37pyhUmFNJ5V3Fp66WXmaKWtlOFlQTJfWw=; b=P/U+GsTcXhqYvHzb4UY0wuFse0vyMDhIqcOHNqvIco3NdpanLfHv40R390OHeqhOx1 mjV/yXdeygiauXeTGlVBHoj5FgKpYHB6LGoflanUB8BLd+rEFJSZp9MwT+RPRffOgmjS +xKhfA9WBFlp80L2Xf7E0rUvFEcfNEVYceOv1brENt+llTtMqMKk/UFRork4o2XlwU6W XpyuJhGchIBjIuOt2v+HIK8Zsn+i6/2/pfinxNPn98z/k5B1NkIIIYKL6QJZ+bkZQrl/ WvFT9yZbRPrxzwfD6jrM4Fbt+q2kN6M3FBDxp+rNtBdpdPjLpaGDVBkDUXRiPMlQ0XbY q3ZA== X-Gm-Message-State: AODbwcCkjAsZoNMjn1JJ9Z8zxZHGT5Guk4s/cL3xK6y6Xuc1XgvYFSYc lC/zMx+spXNhN+4D X-Received: by 10.223.145.195 with SMTP id 61mr22410270wri.43.1496827653140; Wed, 07 Jun 2017 02:27:33 -0700 (PDT) Received: from bidouze.vm.6wind.com (host.78.145.23.62.rev.coltfrance.com. [62.23.145.78]) by smtp.gmail.com with ESMTPSA id 62sm1432607wra.44.2017.06.07.02.27.32 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 07 Jun 2017 02:27:32 -0700 (PDT) Date: Wed, 7 Jun 2017 11:27:26 +0200 From: =?iso-8859-1?Q?Ga=EBtan?= Rivet To: Jerin Jacob Cc: dev@dpdk.org, bruce.richardson@intel.com, harry.van.haaren@intel.com, hemant.agrawal@nxp.com, gage.eads@intel.com, nipun.gupta@nxp.com, narender.vangati@intel.com, nikhil.rao@intel.com Message-ID: <20170607092726.GO18840@bidouze.vm.6wind.com> References: <20170606141046.32103-1-jerin.jacob@caviumnetworks.com> <20170607084333.6338-1-jerin.jacob@caviumnetworks.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20170607084333.6338-1-jerin.jacob@caviumnetworks.com> User-Agent: Mutt/1.5.23 (2014-03-12) Subject: Re: [dpdk-dev] [PATCH v2 0/4] Remove PCI and VDEV dependency from eventdev library X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 07 Jun 2017 09:27:33 -0000 Hi Jerin, On Wed, Jun 07, 2017 at 02:13:29PM +0530, Jerin Jacob wrote: > v3: > Removed the bus dependency by spliting lib/librte_eventdev/rte_eventdev_pmd_pci.h > and lib/librte_eventdev/rte_eventdev_pmd_vdev.h > It works with the PCI bus now, good job. Small problem however: to compile drivers/event/sw/sw_evdev.c, two includes were missing: #include #include I added both to rte_eventdev_pmd_vdev.h to quickly fix this and test the compilation otherwise, but maybe this is only necessary for sw_evdev.c. Thanks > Jerin Jacob (4): > eventdev: remove PCI dependency from generic data structures > eventdev: restructure event PMD release function > eventdev: make PCI probe and remove functions optional > eventdev: make vdev init and uninit functions optional > > drivers/event/octeontx/ssovf_evdev.h | 2 +- > drivers/event/octeontx/ssovf_worker.h | 1 + > drivers/event/skeleton/skeleton_eventdev.c | 33 +++--- > drivers/event/skeleton/skeleton_eventdev.h | 3 +- > drivers/event/sw/sw_evdev.h | 2 +- > lib/librte_eventdev/Makefile | 2 + > lib/librte_eventdev/rte_eventdev.c | 148 ------------------------- > lib/librte_eventdev/rte_eventdev.h | 2 - > lib/librte_eventdev/rte_eventdev_pmd.h | 101 +----------------- > lib/librte_eventdev/rte_eventdev_pmd_pci.h | 160 ++++++++++++++++++++++++++++ > lib/librte_eventdev/rte_eventdev_pmd_vdev.h | 133 +++++++++++++++++++++++ > 11 files changed, 323 insertions(+), 264 deletions(-) > create mode 100644 lib/librte_eventdev/rte_eventdev_pmd_pci.h > create mode 100644 lib/librte_eventdev/rte_eventdev_pmd_vdev.h > > -- > 2.13.0 > -- Gaëtan Rivet 6WIND