From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by dpdk.org (Postfix) with ESMTP id A7D372BB8 for ; Wed, 7 Jun 2017 15:23:45 +0200 (CEST) Received: from orsmga004.jf.intel.com ([10.7.209.38]) by fmsmga105.fm.intel.com with ESMTP; 07 Jun 2017 06:23:44 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.39,311,1493708400"; d="scan'208";a="95565452" Received: from bricha3-mobl3.ger.corp.intel.com ([10.237.221.28]) by orsmga004.jf.intel.com with SMTP; 07 Jun 2017 06:23:42 -0700 Received: by (sSMTP sendmail emulation); Wed, 07 Jun 2017 14:23:41 +0100 Date: Wed, 7 Jun 2017 14:23:41 +0100 From: Bruce Richardson To: "De Lara Guarch, Pablo" Cc: "Wu, Jingjing" , "dev@dpdk.org" Message-ID: <20170607132341.GA59372@bricha3-MOBL3.ger.corp.intel.com> References: <1496007391-182136-1-git-send-email-pablo.de.lara.guarch@intel.com> <9BB6961774997848B5B42BEC655768F810D9CBF6@SHSMSX103.ccr.corp.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Organization: Intel Research and =?iso-8859-1?Q?De=ACvel?= =?iso-8859-1?Q?opment?= Ireland Ltd. User-Agent: Mutt/1.8.1 (2017-04-11) Subject: Re: [dpdk-dev] [PATCH] app/testpmd: add parameter to start forwarding sending X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 07 Jun 2017 13:23:46 -0000 On Wed, Jun 07, 2017 at 01:20:45PM +0000, De Lara Guarch, Pablo wrote: > Hi Jingjing, > > > -----Original Message----- > > From: Wu, Jingjing > > Sent: Wednesday, June 07, 2017 10:18 AM > > To: De Lara Guarch, Pablo > > Cc: dev@dpdk.org > > Subject: RE: [PATCH] app/testpmd: add parameter to start forwarding > > sending > > > > > > > > > -----Original Message----- > > > From: De Lara Guarch, Pablo > > > Sent: Monday, May 29, 2017 5:37 AM > > > To: Wu, Jingjing > > > Cc: dev@dpdk.org; De Lara Guarch, Pablo > > > > > Subject: [PATCH] app/testpmd: add parameter to start forwarding > > sending > > > > > > Add parameter to start forwarding sending first > > > a burst of packets, which is useful when testing > > > a loopback connection. > > > > > > This was already implemented as an internal command, > > > but adding it as a parameter is interesting, as it > > > allows the user to test a loopback connection without > > > entering in the internal command line. > > > > > > Signed-off-by: Pablo de Lara > > > --- > > > app/test-pmd/parameters.c | 5 +++++ > > > app/test-pmd/testpmd.c | 5 +++-- > > > app/test-pmd/testpmd.h | 1 + > > > doc/guides/testpmd_app_ug/run_app.rst | 4 ++++ > > > 4 files changed, 13 insertions(+), 2 deletions(-) > > > > > > diff --git a/app/test-pmd/parameters.c b/app/test-pmd/parameters.c > > > index fbe6284..0da4172 100644 > > > --- a/app/test-pmd/parameters.c > > > +++ b/app/test-pmd/parameters.c > > > @@ -89,6 +89,7 @@ usage(char* progname) > > > "[--cmdline-file=FILENAME] " > > > #endif > > > "[--help|-h] | [--auto-start|-a] | [" > > > + "--tx-first" > > > > Just consider about the interactive mode. > > If using command start, will it still call start_packet_forwarding(0)? > > And if start tx_first, still call start_packet_forwarding(1)? > > > > If using the commands "start" and "start tx_first", the behaviour will remain the same. > The only behaviour that will change is the non-interactive forwarding mode, > and when using auto-start in interactive mode. > > Do you think it should modify the behaviour of "start", in the command line, > so if "--tx-first" is passed, then it sends a burst regardless using "start" or "start tx_first"? > > Thanks for the review! > Pablo > > > It may cause confused whether this argu "--tx-first" works. > > If it only works for non-interactive, you'd better to comment it. > > > > My 2c is that this flag should be only used for non-interactive mode, and you get an error if it is used with -i flag. That should minimize any confusion. /Bruce