From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <gaetan.rivet@6wind.com> Received: from mail-wr0-f178.google.com (mail-wr0-f178.google.com [209.85.128.178]) by dpdk.org (Postfix) with ESMTP id 33C5C2BA3 for <dev@dpdk.org>; Thu, 8 Jun 2017 00:54:50 +0200 (CEST) Received: by mail-wr0-f178.google.com with SMTP id q97so11706603wrb.2 for <dev@dpdk.org>; Wed, 07 Jun 2017 15:54:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to :user-agent; bh=2E5In0ur+g1keM92HwS4rTSTf3wF9g539stLsvz0oFg=; b=L18e2opPt1/5ah6BcbZpM2Xb0THfQLoZh5wzsIBZehL4n/DtbleDEkpJCrkSodtvhk qUSMGQJz5gA9meWgWhtcwZJPBQSiHGea2igHJcCU10Ik98FYuYK3JsOILTQNFDrEEQB0 CD9C/zOFg+RsSOZFyne/z/722uQEe45nOtKKyPdwThXOqqASt2B4x7UWbxDO5EvPlcDu sstT9jh0UM3YWEKzNpilTrcjZ6sVwh9rDL5gxO/XhhiGLMgHrj/7Xffv/fP3sv05e6Qp CPUy1BoC0pqZzmfSiXH4ZGi02XyIDEN8nSlnQgfjj/qK6p6nNYs6jVp4hUxlO2aep0Ir RULQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to:user-agent; bh=2E5In0ur+g1keM92HwS4rTSTf3wF9g539stLsvz0oFg=; b=bWj7PayYDRsQMDdBpmlLhYpIstEZY8uNjRsmdnLEt4bpck8guJbIUyySyHBIn+6nuD 2fgqU3r7HcNUGdp3ZrDlZoqlHnNodGOzBpn+OYH1TsNtjeriQRwjPGundrpdmLa9Lsyi J49h8Rm6bNAR714LyiwgNOL6LlCDiuMC7YrsZU4JII2iklBJdwZZTnB0xPkw4POC1+gE CimkQPjESEF0+O90yb9WuCHyk4obqBPfgvsYoVMxGwdz+mwuMQNH5Oszw7E2sBLnm/xi Ktpo/DsKafy/cspj6I643AzV91T0jXSwlZr0Ye57bf4ADnZjDiat7yicTDIbMjPEK2wI 92bA== X-Gm-Message-State: AODbwcCkDQNapdvs9ez+wyQq9UpWibcTyzj0YSmCB938osfRxeAm7QR7 KKAO7kwWMT6awMia X-Received: by 10.223.146.166 with SMTP id 35mr2518837wrn.104.1496876089762; Wed, 07 Jun 2017 15:54:49 -0700 (PDT) Received: from bidouze.vm.6wind.com (host.78.145.23.62.rev.coltfrance.com. [62.23.145.78]) by smtp.gmail.com with ESMTPSA id 202sm4505014wmq.27.2017.06.07.15.54.48 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 07 Jun 2017 15:54:48 -0700 (PDT) Date: Thu, 8 Jun 2017 00:54:41 +0200 From: =?iso-8859-1?Q?Ga=EBtan?= Rivet <gaetan.rivet@6wind.com> To: Pablo de Lara <pablo.de.lara.guarch@intel.com> Cc: declan.doherty@intel.com, thomas@monjalon.net, dev@dpdk.org Message-ID: <20170607225441.GX18840@bidouze.vm.6wind.com> References: <1495639634-74846-1-git-send-email-pablo.de.lara.guarch@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1495639634-74846-1-git-send-email-pablo.de.lara.guarch@intel.com> User-Agent: Mutt/1.5.23 (2014-03-12) Subject: Re: [dpdk-dev] [PATCH 00/12] Remove cryptodev driver X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <http://dpdk.org/ml/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://dpdk.org/ml/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <http://dpdk.org/ml/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> X-List-Received-Date: Wed, 07 Jun 2017 22:54:50 -0000 Hi Pablo, On Wed, May 24, 2017 at 04:27:02PM +0100, Pablo de Lara wrote: > Following the same aproach taken for ethdev, this patch series > removes the PCI specific structure cryptodev driver from rte_cryptodev. > > The patchset makes the following changes: > > - Moves the virtual and PCI device specific functions to separate files, > so other cryptodev header files contain only device type agnostic functions. > > - Modifies device info retrieval function to set the driver name for all devices > and set PCI info inside PCI device PMDs > > - Removes cryptodev driver structure from cryptodev library and drivers > that were using it (QAT and dpaa2) > While most of the work seems to be done within this patchset, there are still rte_pci.h includes in both: lib/librte_cryptodev/rte_cryptodev.c:50:#include <rte_pci.h> lib/librte_cryptodev/rte_cryptodev_pmd.h:50:#include <rte_pci.h> This breaks the compilation when the PCI bus is compiled outside the EAL. Would you be able to remove those last dependencies? > There is still a vdev specific function, rte_cryptodev_create_vdev() in cryptodev.c. > That function should be deprecated, as virtual devices should be created through > EAL. A deprecation notice will be sent separately. > > Pablo de Lara (12): > cryptodev: store device pointer in virtual devices > cryptodev: set driver name for all devices > cryptodev: rename device retrieval argument > cryptodev: simplify device list retrieval logic > cryptodev: only set PCI info when device is PCI > cryptodev: move vdev functions to a separate file > cryptodev: release device if PCI device probing fails > cryptodev: add PCI driver helpers > crypto/qat: do not use cryptodev driver > crypto/dpaa2_sec: do not use cryptodev driver > cryptodev: remove unused PCI probe/remove > cryptodev: remove unused cryptodev driver > > drivers/crypto/aesni_gcm/aesni_gcm_pmd.c | 4 +- > drivers/crypto/aesni_mb/rte_aesni_mb_pmd.c | 5 +- > drivers/crypto/armv8/rte_armv8_pmd.c | 4 +- > drivers/crypto/dpaa2_sec/dpaa2_sec_dpseci.c | 9 +- > drivers/crypto/kasumi/rte_kasumi_pmd.c | 4 +- > drivers/crypto/null/null_crypto_pmd.c | 8 +- > drivers/crypto/openssl/rte_openssl_pmd.c | 4 +- > drivers/crypto/qat/qat_crypto.c | 6 +- > drivers/crypto/qat/qat_qp.c | 8 +- > drivers/crypto/qat/rte_qat_cryptodev.c | 32 +-- > drivers/crypto/scheduler/scheduler_pmd.c | 59 +----- > drivers/crypto/scheduler/scheduler_pmd_ops.c | 1 + > drivers/crypto/snow3g/rte_snow3g_pmd.c | 4 +- > drivers/crypto/zuc/rte_zuc_pmd.c | 4 +- > lib/librte_cryptodev/Makefile | 2 + > lib/librte_cryptodev/rte_cryptodev.c | 272 +------------------------ > lib/librte_cryptodev/rte_cryptodev.h | 39 +--- > lib/librte_cryptodev/rte_cryptodev_pci.h | 177 ++++++++++++++++ > lib/librte_cryptodev/rte_cryptodev_pmd.h | 94 --------- > lib/librte_cryptodev/rte_cryptodev_vdev.h | 236 +++++++++++++++++++++ > lib/librte_cryptodev/rte_cryptodev_version.map | 18 +- > 21 files changed, 497 insertions(+), 493 deletions(-) > create mode 100644 lib/librte_cryptodev/rte_cryptodev_pci.h > create mode 100644 lib/librte_cryptodev/rte_cryptodev_vdev.h > > -- > 2.7.4 > -- Gaëtan Rivet 6WIND