From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f42.google.com (mail-wm0-f42.google.com [74.125.82.42]) by dpdk.org (Postfix) with ESMTP id 70A912BBB for ; Thu, 8 Jun 2017 12:08:19 +0200 (CEST) Received: by mail-wm0-f42.google.com with SMTP id 7so134523122wmo.1 for ; Thu, 08 Jun 2017 03:08:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=zmSKOTp6A84HH/sVpR+Wk0/RSK4WG0MfWXpPJmvJ+Z8=; b=O4LGGWOxTtJUEbRChCiI7Q/gxh4VynJlemwjTzjuBH5+OdaJqVtxlBTtGL0wOLF4jb mL5o92/FIaIGm+0GLcYJIOzC3N5uc9J3lAxvaN8v6dNaJTXM4dVHGRu0jzzlJWvF/UMb AGqHdenfQHUUEMdr6XjC4Lm1+Y23EGwcrGifsXvrwG+xcPqgncDdhPvME1B7QBPc1O45 YqB1w8ZERwL4pppYFC9u1JT9JwwTypvF7CtZmLOtmPtUuXoS/w39y+06nXsNEYIR9ynZ rXH1KjNIIUw8MSL66eSMSUxWNMyISNUFrbum603UrNc7NIKwhyrRTmRbggy/xPrJfUjP OZYQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=zmSKOTp6A84HH/sVpR+Wk0/RSK4WG0MfWXpPJmvJ+Z8=; b=Y4cD1YPG3nXMcOcNOkTvCpMhu8SbBRgRFiTzsbWjdKJhUrjVya/Q9vWzQ3bMTvPFVA 9FUTEhSZL8h+pSCxZXLYyybJdrtj0YL/6wvFgQv8XkmHn4tYyvbYUGWQZf1vlwoSrGfM kRZE3jwtgSkWAet3q0fYEF/WNZqJL9bHlRY+bmqgZ1aFuVUa5FOC2Xn6Sx001uRgmY/1 EzyvmBUtKrHjxwAHGAgX4g41nOp355Oe4kulYF80meCjHVCn0fwVpgY40aMMAL3HwJcl Iov9jrLpnPFxPfFArlZYUu+tY0Iep3jbFRQTgfkHYmJOtDpGRVNO0z/Qx/XRVax8p1JP TYbg== X-Gm-Message-State: AODbwcCFVIMfcKt7zqasrdGdeXBiDyGINS3Kgn9ajt9TE0/G+IDVrJCd mkgoQt/+/cOuZPba X-Received: by 10.28.138.73 with SMTP id m70mr2568283wmd.99.1496916499155; Thu, 08 Jun 2017 03:08:19 -0700 (PDT) Received: from platinum (2a01cb0c03c651000226b0fffeed02fc.ipv6.abo.wanadoo.fr. [2a01:cb0c:3c6:5100:226:b0ff:feed:2fc]) by smtp.gmail.com with ESMTPSA id w128sm6390002wmd.7.2017.06.08.03.08.18 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Thu, 08 Jun 2017 03:08:19 -0700 (PDT) Date: Thu, 8 Jun 2017 12:08:16 +0200 From: Olivier Matz To: Santosh Shukla Cc: dev@dpdk.org, thomas.monjalon@6wind.com, shreyansh.jain@nxp.com, stable@dpdk.org Message-ID: <20170608120816.48c25965@platinum> In-Reply-To: <20170511103044.14298-1-santosh.shukla@caviumnetworks.com> References: <20170511103044.14298-1-santosh.shukla@caviumnetworks.com> X-Mailer: Claws Mail 3.14.1 (GTK+ 2.24.31; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH 1/2] test/test_mbuf: Remove mempool global var X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 08 Jun 2017 10:08:19 -0000 Hi Santosh, On Thu, 11 May 2017 16:00:43 +0530, Santosh Shukla wrote: > Cc: stable@dpdk.org > Signed-off-by: Santosh Shukla > --- > test/test/test_mbuf.c | 100 +++++++++++++++++++++++++------------------------- > 1 file changed, 51 insertions(+), 49 deletions(-) > Thank you for doing this fix. My only comment is that commit introduces a memory leak, which is fixed by your second patch. The behavior before your patch was to allocate the pools once but never free them. The behavior after this patch is to allocate the pools each time the test is started and never free them. After your 2 patches, the behavior is good. So I suggest to merge them into one commit. What do you think? Olivier