From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f41.google.com (mail-wm0-f41.google.com [74.125.82.41]) by dpdk.org (Postfix) with ESMTP id 8E0EE378B for ; Fri, 9 Jun 2017 11:06:18 +0200 (CEST) Received: by mail-wm0-f41.google.com with SMTP id d73so45705614wma.0 for ; Fri, 09 Jun 2017 02:06:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to :user-agent; bh=ifQvCvVgWxNvkU5Al0duQnq4Bx7kk1UOeHxXAeKOoUM=; b=MGlnBxCX5pZZna5TpbefZ8GfeP7OZq7N9jS3dktq399sSDbgBQJkxwfnJWzOYuCayB 0c/0uLMGOrKjX8afhZL4jLXxl1+oWVl1u9ureHFHKXl7D/O22h1VTuKHUx90BNbWHsqB z4JYmMHQ7MwiMwy1LQkamJVWksE8M2ZWDaPA8eE63UfavMAAREl6Pi2BflzzIxMbVoE9 lL6oyc3Sy7kzwpE4Eam7mHxWU8vLepg/oecgRDyvQdgxLHdWX6U5Cld1Q84HhRVEINkL iEXmCB74bIjolR+s3exDUROCpIFYvdlyjj0rNiSmg+ZDkyV+tSCwCVro2Q8SiELUK7JX 7G6g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to:user-agent; bh=ifQvCvVgWxNvkU5Al0duQnq4Bx7kk1UOeHxXAeKOoUM=; b=B8KMV/zgXfCR9HOhVq9NURzfhgI9u3kPMl7wi9dJAY2cYI++tOnxe4c9UB6s7DTxIG QqcLt2Gk7eBWnPgvkw7bL3LwTqENmNNoj6cPCcXIWjTwgFixCmLuwpWaQNXfs4Z62IA/ ryqadMJhXQNNk7HEH31UYuVcDxWZB+Fwn24pPYHrmvEZyac+GjNvMR+H3flQAhwz0u5B tzvOi/clizk6ZNa7H6iEmY5nrU6Ejon5NAc8MfD5pvbiNN5g/axeeElt+dVT+BLgUWV3 mPRnnu89J61v00uhmhLTeCM8SWkZ/VZ5t4TVyRifP+cSL9CExT5GI28RNjsOonTx0Rov M8zw== X-Gm-Message-State: AODbwcBppRJLc0Vveiu5TEdPCvAk/uZcul9LRimOrqL8h7uzpk6oRMml ZOl73HQakcBGZh9UIYM= X-Received: by 10.28.26.135 with SMTP id a129mr6838303wma.11.1496999178169; Fri, 09 Jun 2017 02:06:18 -0700 (PDT) Received: from bidouze.vm.6wind.com (host.78.145.23.62.rev.coltfrance.com. [62.23.145.78]) by smtp.gmail.com with ESMTPSA id n2sm1032683wmd.16.2017.06.09.02.06.17 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 09 Jun 2017 02:06:17 -0700 (PDT) Date: Fri, 9 Jun 2017 11:06:09 +0200 From: =?iso-8859-1?Q?Ga=EBtan?= Rivet To: Ferruh Yigit Cc: dev@dpdk.org Message-ID: <20170609090609.GC29091@bidouze.vm.6wind.com> References: <015f5ab0-1936-44f3-a60e-f4ff9f377262@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <015f5ab0-1936-44f3-a60e-f4ff9f377262@intel.com> User-Agent: Mutt/1.5.23 (2014-03-12) Subject: Re: [dpdk-dev] [PATCH v2 08/12] kni: disabled by default X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 09 Jun 2017 09:06:18 -0000 Hi Ferruh, On Fri, Jun 09, 2017 at 09:56:14AM +0100, Ferruh Yigit wrote: > On 6/8/2017 12:59 AM, Gaetan Rivet wrote: > > Signed-off-by: Gaetan Rivet > > --- > > config/common_linuxapp | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/config/common_linuxapp b/config/common_linuxapp > > index b3cf41b..cc85cc6 100644 > > --- a/config/common_linuxapp > > +++ b/config/common_linuxapp > > @@ -38,7 +38,7 @@ CONFIG_RTE_EXEC_ENV_LINUXAPP=y > > CONFIG_RTE_EAL_IGB_UIO=y > > CONFIG_RTE_EAL_VFIO=y > > CONFIG_RTE_KNI_KMOD=y > > -CONFIG_RTE_LIBRTE_KNI=y > > +CONFIG_RTE_LIBRTE_KNI=n > > CONFIG_RTE_LIBRTE_PMD_KNI=y > > CONFIG_RTE_LIBRTE_VHOST=y > > CONFIG_RTE_LIBRTE_PMD_VHOST=y > > > > Hi Gaetan, > > We shouldn't just disable components that doesn't compile. > Ah, sure :) . This patch is not meant to be integrated as is, but only as a convenient way for testers to apply the patchset and verify the compilation, as far as KNI is not concerned. Eventdev and cryptodev fixed this dependency. I was thinking about looking into it for KNI and PDUMP but I don't have the time right now, and I'm not sure I will have until the end of June. > And what happens when it is enabled, not compiled at all? So you are > literally breaking the existing support with your patch? > > Thanks, > ferruh > -- Gaëtan Rivet 6WIND