From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f47.google.com (mail-wm0-f47.google.com [74.125.82.47]) by dpdk.org (Postfix) with ESMTP id 22E252BA1 for ; Fri, 9 Jun 2017 11:58:36 +0200 (CEST) Received: by mail-wm0-f47.google.com with SMTP id d73so46562349wma.0 for ; Fri, 09 Jun 2017 02:58:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to :user-agent; bh=Yzxe4gLruX0DHNJaXq2LU5wWEBBvPDmpak1yA6yiH1U=; b=djwnkvfZxYR4xQtX4glJDlZhYJuhqz5LJH/gYOHL0cZQf/ogb/ht8TfAmTXYy8ZZJG yWWuS3SxZvurqz6zCrGTC6lqBwL6hEeH+lTAmSkm9Da1Fe4ZRmHoEUmLuJZzRAkAh5iS mgp/zwXvGz5rQfUQOr39awW0ua11BvHn9UyipMaR76R6pK3i2zB23SK4XNSokNG4jdNN OQlcZgMUft2+nzVrplkW4M8sZ9mceDAJUKoL0dUoZV//obGgUSP78M0fp7d9Ynybofu0 Gj0PmWs8Ocu4hc6iTp38hCwPXRiKr+DL19PaxSKsgyRWro1EFrwhk0si3wdacp/YlW+P g18A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to:user-agent; bh=Yzxe4gLruX0DHNJaXq2LU5wWEBBvPDmpak1yA6yiH1U=; b=dopV4GQ74d1YY+XIyAwlJIIKFZ+2OsECK1E2LwBUuCKC1aiqI/Eo/9rd9EnWSCIDoz U9ezKx9XP0eK+qoR6sbEFkYeKPBCGSOZ6jMUtlHDmJJm2GoJtaQ4lL+M3dpOhXaX2Tq6 T7C6sct2Cxgtu8oPaoP2FXq7xt7TE7pbD/ZJtYu+HPu2U49rgGhn3gM6BY6PIm/4YzpO xfZoT40zIh5BemJhhnIJJaoDkHm28V8iYxJoRv/okBflSEMdWKrRzJyRrorjTKGgUkCr XrMiS33OjMnCIcaNPn4ofcZQhioxiPu1n700KrM7ca1hBMt29P4TiOzDC341kXL9N0nV 4GEA== X-Gm-Message-State: AODbwcCfZTRwZJMx+G4Qmm4B3UGvLzDi2OM7JXTsjZhGkbMR9RgJg/7l aSs9uIbNvEB1YoIt X-Received: by 10.28.218.3 with SMTP id r3mr6550529wmg.120.1497002316560; Fri, 09 Jun 2017 02:58:36 -0700 (PDT) Received: from bidouze.vm.6wind.com (host.78.145.23.62.rev.coltfrance.com. [62.23.145.78]) by smtp.gmail.com with ESMTPSA id e24sm1080686wre.54.2017.06.09.02.58.35 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 09 Jun 2017 02:58:35 -0700 (PDT) Date: Fri, 9 Jun 2017 11:58:28 +0200 From: =?iso-8859-1?Q?Ga=EBtan?= Rivet To: "De Lara Guarch, Pablo" Cc: "Doherty, Declan" , "thomas@monjalon.net" , "dev@dpdk.org" Message-ID: <20170609095828.GE29091@bidouze.vm.6wind.com> References: <1495639634-74846-1-git-send-email-pablo.de.lara.guarch@intel.com> <20170607225441.GX18840@bidouze.vm.6wind.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: Mutt/1.5.23 (2014-03-12) Subject: Re: [dpdk-dev] [PATCH 00/12] Remove cryptodev driver X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 09 Jun 2017 09:58:37 -0000 On Thu, Jun 08, 2017 at 03:58:16PM +0000, De Lara Guarch, Pablo wrote: > Hi Gaetan, > > > -----Original Message----- > > From: Gaëtan Rivet [mailto:gaetan.rivet@6wind.com] > > Sent: Wednesday, June 07, 2017 11:55 PM > > To: De Lara Guarch, Pablo > > Cc: Doherty, Declan; thomas@monjalon.net; dev@dpdk.org > > Subject: Re: [dpdk-dev] [PATCH 00/12] Remove cryptodev driver > > > > Hi Pablo, > > > > On Wed, May 24, 2017 at 04:27:02PM +0100, Pablo de Lara wrote: > > > Following the same aproach taken for ethdev, this patch series > > > removes the PCI specific structure cryptodev driver from rte_cryptodev. > > > > > > The patchset makes the following changes: > > > > > > - Moves the virtual and PCI device specific functions to separate files, > > > so other cryptodev header files contain only device type agnostic > > functions. > > > > > > - Modifies device info retrieval function to set the driver name for all > > devices > > > and set PCI info inside PCI device PMDs > > > > > > - Removes cryptodev driver structure from cryptodev library and drivers > > > that were using it (QAT and dpaa2) > > > > > > > While most of the work seems to be done within this patchset, there are > > still rte_pci.h includes in both: > > > > lib/librte_cryptodev/rte_cryptodev.c:50:#include > > lib/librte_cryptodev/rte_cryptodev_pmd.h:50:#include > > > > This breaks the compilation when the PCI bus is compiled outside the EAL. > > Would you be able to remove those last dependencies? > > These includes have been removed already in the patchset. > Have you applied all 12 patches? > Ah yes, sorry, I must have missed a few. I have some trouble applying the patch however, I will test the integration with the PCI bus move after I resolve this. > Thanks, > Pablo > > -- Gaëtan Rivet 6WIND