From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pg0-f67.google.com (mail-pg0-f67.google.com [74.125.83.67]) by dpdk.org (Postfix) with ESMTP id 25D5F2BB9 for ; Mon, 12 Jun 2017 12:21:45 +0200 (CEST) Received: by mail-pg0-f67.google.com with SMTP id f127so13924159pgc.2 for ; Mon, 12 Jun 2017 03:21:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fridaylinux-org.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=NNCCEfQVWpSOvQqTNGAWAd+CjFTNPXhWMBkpUYdXeGI=; b=CZpM53JLXnKXtzMX8KYA2/fZTRqHjzeTRvmbicEleer+jVie6KN6ndiLC81FDvRaES RXqykim5aRwHB7myUo7DB0Aha6mzrtRmKmotJeECJUvWp7wVsTaDO4aqW24MpFwVtQqR wzucgGEgHfxa2Pl84HSZHkLbrcDM3qzKlsozZXKO77mIhljhpwOW7la2qGNQGduH8ojv uUHFLhVGVcNCDv5ZjFgmfsrGwzUoqxnLt0x09wtkD8vLJeKVyeGlP9MhiXry+1X/R9uJ 62a6YiDtBK66ZQDee7bcs4hz/p1HqXysRU0YqufQo2AO9XrWGAhtIIk89/nJbASiIyWz Dy+Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=NNCCEfQVWpSOvQqTNGAWAd+CjFTNPXhWMBkpUYdXeGI=; b=EuergeJLYQT334/Jpk4cI7C3m8k+Oap3NZVcN0d47HC0kAF3PuU/xlaPbmgXuu0nRc /P6egP8HHBynabRoLczqjHtS7aO3laihzObn+X/gS2EDIUKZ/TVPbgKH6dYKEXF987ap y9UDgcWrpmqy/Ro+Y3+gn3Q7/WGKsHW9m36TVs/AOsLvdRdz4jJWFWouvNYvvfVqItcx /IE3UDoevUVsPvM0b9YF5f4nrg0rqudcaGcSVNoURo8kQ7cDARjT3B6iX8n8EezTfOeq AgTuNqaY5E4PeNmPVub6QCtZzsBFskx7oGWsIx5env943EvRc1TIng9BuapyCvyPF2T4 k6CA== X-Gm-Message-State: AKS2vOzU5eVgCfL5whZvNMgtDGC9F7wMwl/Vwf68biZVOBU3G7+ITND/ ATB/lTWCyYMAjTrJ X-Received: by 10.98.141.89 with SMTP id z86mr6398680pfd.34.1497262904078; Mon, 12 Jun 2017 03:21:44 -0700 (PDT) Received: from yliu-home ([45.63.61.64]) by smtp.gmail.com with ESMTPSA id j62sm15277632pgd.20.2017.06.12.03.21.41 (version=TLS1 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Mon, 12 Jun 2017 03:21:42 -0700 (PDT) Date: Mon, 12 Jun 2017 18:21:37 +0800 From: Yuanhan Liu To: Tiwei Bie Cc: dev@dpdk.org, maxime.coquelin@redhat.com, mtetsuyah@gmail.com, stable@dpdk.org Message-ID: <20170612102137.GA2611@yliu-home> References: <1497242070-68791-1-git-send-email-tiwei.bie@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1497242070-68791-1-git-send-email-tiwei.bie@intel.com> User-Agent: Mutt/1.6.1 (2016-04-27) Subject: Re: [dpdk-dev] [PATCH] net/virtio: zero the whole memory zone X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 12 Jun 2017 10:21:45 -0000 On Mon, Jun 12, 2017 at 12:34:30PM +0800, Tiwei Bie wrote: > Zero the whole memory zone instead of the first few bytes. > > Fixes: c1f86306a026 ("virtio: add new driver") > Cc: stable@dpdk.org > > Signed-off-by: Tiwei Bie > --- > drivers/net/virtio/virtio_ethdev.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/net/virtio/virtio_ethdev.c b/drivers/net/virtio/virtio_ethdev.c > index 45f9bca..88118f1 100644 > --- a/drivers/net/virtio/virtio_ethdev.c > +++ b/drivers/net/virtio/virtio_ethdev.c > @@ -424,7 +424,7 @@ virtio_init_queue(struct rte_eth_dev *dev, uint16_t vtpci_queue_idx) > } > } > > - memset(mz->addr, 0, sizeof(mz->len)); > + memset(mz->addr, 0, mz->len); Nice catch! Applied to dpdk-next-virtio. Thanks. --yliu