From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wr0-f171.google.com (mail-wr0-f171.google.com [209.85.128.171]) by dpdk.org (Postfix) with ESMTP id D7CD7DE3 for ; Mon, 12 Jun 2017 17:38:50 +0200 (CEST) Received: by mail-wr0-f171.google.com with SMTP id q97so102167509wrb.2 for ; Mon, 12 Jun 2017 08:38:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=1aaopSZGbiocFeDXSlnyk09fzzIiZ9RF+jir7TSpF5M=; b=TEtmbWmVZ8z1pCi7+P5X/HW/MttQrG3SMg9dyyir017PCAgVYCsTej+59LCbAWpmE9 TOtjd1bWdcfYNQUiO1N5DstG3jpeTMJZfTsYhGE0rMziLfs+7vs5xEh1XKQ2Pq+eAbYi kNq2G1lswnTKuDXLsOC3fCDt1hV56tyuxVN1oHs2xj9wAcpjhwpu5dYHWWeXcU9ayVKL KDqOphV/fCGVB+O8YwrOyKC3txbjT+B4/snYv1ghgnOVrNVKllVqvYwbeiJ6EmO5XMwI 8udcoxng7C4Va6BjbakRmO5xoDQA4hKK1dK/Sz7B4XYmOFf6oJW6cOz2FTw/O2wudHGs h84A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=1aaopSZGbiocFeDXSlnyk09fzzIiZ9RF+jir7TSpF5M=; b=IlUaNnOsdp2HJjhJWtLTaHUN0sLHLzsbCRXZH1tOLnrW56I4uzkgen5c3962/54S/d xCzHJN5bdogtSOCnFDXz7MeaMqF62OM8P+zcyHTEIgoXQg6XUPuBKuHgdzRacI09Dn1j DFwM2JHJuKDAhKk6ptmjPliYlBDWSoDE4w5ic7WgX6V7vH8hbp0HNJyA6LmEzJ1qhQa3 gT7kMsWcTaqex5yDxD9wYcIzSAiHedkGExWtR5SzPvc87g2yqPsfUNRFJvcBZ4t3y6lA l/iYCzt5QNghLGlZKBDMefjZxOwylgEx8ndqzT7esF0PmFZE6tHDcQgo/nwioJyJizhL yMNw== X-Gm-Message-State: AODbwcDT1slaAxYapNS8gcmi38Wfi0Bkhd7PeUU1R7yuCRAsSmEnZdM5 QnykkeiabNqVVQnp4mg= X-Received: by 10.223.151.219 with SMTP id t27mr7090332wrb.90.1497281930151; Mon, 12 Jun 2017 08:38:50 -0700 (PDT) Received: from 6wind.com (host.78.145.23.62.rev.coltfrance.com. [62.23.145.78]) by smtp.gmail.com with ESMTPSA id 50sm5566412wrw.32.2017.06.12.08.38.49 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 12 Jun 2017 08:38:49 -0700 (PDT) Date: Mon, 12 Jun 2017 17:38:41 +0200 From: Adrien Mazarguil To: Thomas Monjalon Cc: Qi Zhang , dev@dpdk.org Message-ID: <20170612153841.GE1758@6wind.com> References: <1495582134-13665-1-git-send-email-qi.z.zhang@intel.com> <1496874080-35086-1-git-send-email-qi.z.zhang@intel.com> <2304112.MuvLPJetXV@xps> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <2304112.MuvLPJetXV@xps> Subject: Re: [dpdk-dev] [PATCH v2] ethdev: add fuzzy match pattern X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 12 Jun 2017 15:38:51 -0000 On Thu, Jun 08, 2017 at 09:19:24AM +0200, Thomas Monjalon wrote: > Hi, > > 08/06/2017 00:21, Qi Zhang: > > Add new meta pattern item RTE_FLOW_TYPE_ITEM_FUZZY. > > I disagree about fuzzy wording, because fuzzy is something different > I think. At least it's a generic term, unrelated PMDs could likewise implement another kind of fuzzy matching for performance reasons (for applications that really care more about performance than accuracy). The fact this particular implementation is built on top of something that is internally known as signature hash should not be relevant. > > This is for device that support fuzzy match option. > > Usually a fuzzy match is fast but the cost is accuracy. > > i.e. Signature Match only match pattern's hash value, but it is > > possible two different patterns have the same hash value. > > You have described it yourself here: it matches a hash of the signature. > Why not using "hash" as wording? While "hash" would be also correct, in my opinion it would restrict this pattern item to Intel adapters (ixgbe) with the ability to actually perform a hash on patterns and use the resulting value to imperfectly match traffic. This excludes other implementations with similar unpredictable results. Also a threshold notion is necessary as far as I understand, the signature mode has several levels. The higher, the fuzzier it gets. This behavior is difficult to translate to something generic named "hash", as one would have to describe how the hash is computed and packets matched according to that value, which really is ixgbe-specific at the moment. > > Matching accuracy level can be configure by subfield threshold. > > Driver can divide the range of threshold and map to different > > accuracy levels that device support. > > > > Signed-off-by: Qi Zhang Qi, many of my other comments about v1 still stand, please check my previous reply in any case. -- Adrien Mazarguil 6WIND