From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <gaetan.rivet@6wind.com> Received: from mail-wr0-f169.google.com (mail-wr0-f169.google.com [209.85.128.169]) by dpdk.org (Postfix) with ESMTP id 9082C7CEB for <dev@dpdk.org>; Wed, 14 Jun 2017 11:48:38 +0200 (CEST) Received: by mail-wr0-f169.google.com with SMTP id v104so170358148wrb.0 for <dev@dpdk.org>; Wed, 14 Jun 2017 02:48:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to :user-agent; bh=x99keAPCZI/OM4iCmBNmhK86Nry/b5UL6UUzDsvU7KA=; b=HpIALZ1dNr5mubHlMV+8Hymn593qgMQAlUZCIS9zsKg7trwVnA4sSFxNDgQcH6iH1U JyM8NyMHm4Aboghf3OZCGfdWwFb7gwc6xsdtDpEi3zs7mqoP/TZGFyWZn1vwCV3GEM9o NeB6UNpBN1otFfDb5lXTIDPy7r3lVSysWbzTGvJV/Pged2wa7vP+wU58h+mlsWkcR0Ug C5LBWs478Cp3A0+ByWBshlRfavdTGdw4mFebfhaMp0Q7ViGLvpIeqt6onh3EYtL36nS/ TrCHnQz+NX8+bbCuMEmzFETcr66AjLtb7S1Bsak8tRAeCsPAy4FhPzG7IZ1vLovI+MdI cTPw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to:user-agent; bh=x99keAPCZI/OM4iCmBNmhK86Nry/b5UL6UUzDsvU7KA=; b=l7Hn8G+RTFladzZ9DZOwmmDHHBieESxBtoptLE8y3UAOs2iLd6M6CzS/jtkBuLqfs/ 6Y7cFcdZrVXgZy/LmTVGyv5xFbGxATVxbrETapgMD44+BONGnf+vbdW+EIPU1GJ1o0f+ 7ewTgDEnqj+T1b8hj45gaUwJ1w7V4P/WJkUNqh5u+ms57WVroQIu9hV5dA85HyV9vZmz kjTlj+7fum6rGrfDX2HwD6mJC5y6xxCMUnA8DFr4y0X8au3aMG3hm5/RR9Hhnvm1PxJu F2w+md3UR5cE2rVd+sk+ibaYRJsrEtlljphPAEjQKvy0eVvXhu8RJN4QpQttQZDE//T0 RZoQ== X-Gm-Message-State: AKS2vOw5bcuNqdTlLEJyYTDb6d7hiID2yGuRbWk0bkB1L9h+nu+UF9DL uDv2OWbDnBOHDtDtu2Y= X-Received: by 10.28.41.65 with SMTP id p62mr14354792wmp.32.1497433717225; Wed, 14 Jun 2017 02:48:37 -0700 (PDT) Received: from bidouze.vm.6wind.com (host.78.145.23.62.rev.coltfrance.com. [62.23.145.78]) by smtp.gmail.com with ESMTPSA id e14sm111958wmi.16.2017.06.14.02.48.36 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 14 Jun 2017 02:48:36 -0700 (PDT) Date: Wed, 14 Jun 2017 11:48:28 +0200 From: =?iso-8859-1?Q?Ga=EBtan?= Rivet <gaetan.rivet@6wind.com> To: "Dai, Wei" <wei.dai@intel.com> Cc: "dev@dpdk.org" <dev@dpdk.org> Message-ID: <20170614094827.GW29091@bidouze.vm.6wind.com> References: <cover.1496876859.git.gaetan.rivet@6wind.com> <0a60f041662ae5aec08d0ee9ba9795fc07292d62.1496876859.git.gaetan.rivet@6wind.com> <49759EB36A64CF4892C1AFEC9231E8D650AA51FA@PGSMSX106.gar.corp.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <49759EB36A64CF4892C1AFEC9231E8D650AA51FA@PGSMSX106.gar.corp.intel.com> User-Agent: Mutt/1.5.23 (2014-03-12) Subject: Re: [dpdk-dev] [PATCH v4 05/19] net/ixgbe: properly reference PCI header X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <http://dpdk.org/ml/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://dpdk.org/ml/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <http://dpdk.org/ml/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> X-List-Received-Date: Wed, 14 Jun 2017 09:48:39 -0000 Hi, On Wed, Jun 14, 2017 at 09:33:14AM +0000, Dai, Wei wrote: > Why to introduce this change ? > > Even without this patch, all files can be built successfully. > Each.*.o.d files in x86_64-native-linuxapp-gcc keeps same in both with and without this patch. > So there is no need to add the line at least in the config of x86_64-native-linuxapp-gcc. > > In order to remove the PCI bus from the EAL, I need to remove all references to it from EAL headers. rte_devargs.h previously included rte_pci.h, which then was included by several other parts of the DPDK. This needs to be fixed, as afterward, the commit * devargs: generic device representation removes the PCI include. This include was faulty anyway, as normally all compile units (or at least independent DPDK parts) should be self-sufficient in terms of includes, due to this exact situation where libraries are moved around and their dependencies are updated. > > -----Original Message----- > > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Gaetan Rivet > > Sent: Thursday, June 8, 2017 7:57 AM > > To: dev@dpdk.org > > Cc: Gaetan Rivet <gaetan.rivet@6wind.com> > > Subject: [dpdk-dev] [PATCH v4 05/19] net/ixgbe: properly reference PCI header > > > > Signed-off-by: Gaetan Rivet <gaetan.rivet@6wind.com> > > --- > > drivers/net/ixgbe/ixgbe_ethdev.h | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/drivers/net/ixgbe/ixgbe_ethdev.h > > b/drivers/net/ixgbe/ixgbe_ethdev.h > > index e2d0139..bb5ecd5 100644 > > --- a/drivers/net/ixgbe/ixgbe_ethdev.h > > +++ b/drivers/net/ixgbe/ixgbe_ethdev.h > > @@ -39,6 +39,7 @@ > > #include "ixgbe_bypass.h" > > #include <rte_time.h> > > #include <rte_hash.h> > > +#include <rte_pci.h> > > > > /* need update link, bit flag */ > > #define IXGBE_FLAG_NEED_LINK_UPDATE (uint32_t)(1 << 0) > > -- > > 2.1.4 > -- Gaëtan Rivet 6WIND