From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wr0-f169.google.com (mail-wr0-f169.google.com [209.85.128.169]) by dpdk.org (Postfix) with ESMTP id 2AECF2BB9 for ; Thu, 15 Jun 2017 01:01:34 +0200 (CEST) Received: by mail-wr0-f169.google.com with SMTP id 36so20326911wry.3 for ; Wed, 14 Jun 2017 16:01:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to :user-agent; bh=39AHSv5DNYRqkvEfo5PRYlJrW2jHUaCVB1uqcKIK/4g=; b=MXNnOQBpEZ/MWYkBTeq1RVy+a7qw9WKud8GrwqMDV0v+nZi0IlZkETBUoJVviwBJLz D8/4SZo02efFl9Y8cPEsAlwx4GrvCjDNukmnBqteftBa2QxqcdEY3HlE7r9O3DaE3O8Z t0hyuCQVBVF+epwKtiCd9Ir3upY8hdFU9QhoJZ8Gng9pNjbUx7mNS0X0nth7IrKT0WcB knLPd689fzXuaeKiYAORZ779eN6aCbX2nih6feV9qLi9NYwlbDBEV3lgijx1US1F6k1D 82UTakkf/BEqvOmxI5pAHInNnmW+urI+WQTrxXu+sGmhc1SoTUF+sTYGyQQ6sVpK/j/k 7WhQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to:user-agent; bh=39AHSv5DNYRqkvEfo5PRYlJrW2jHUaCVB1uqcKIK/4g=; b=arFgLMd4QrvxDUoUp+UInMOZl6R3ZhcZdDXsig7otGMdd/mJHggoBsCkdOQgehbZ5L mAXXKrh1NdKP0hoTksIfk3ZE14lXDkM0LFGjHLqD785f7duJPfYoca1D28kgs3GuA0sl AcJS63Kgub7Ksxp1VFK8foSSkbEqaGqgQvOmsaa0/KWrtwQ7/JWTf1w8qMLdx2CFYR8t RkR7O+5sLHV9LwyXoUT1oojH/bnL6QB/AOaq+yyttB6v9WsquwH7HjPM7ZopzJa/u04U ZOfTd7NJ9Uquq3xGbv7cXzhn46Iqie1mDb7t9c8n3L8W4tw5vX+QBymR1AwHg9gnHMZe ba8Q== X-Gm-Message-State: AKS2vOxGo6ygQBohEWwWNqCmztDOFgBi2v2JIHMu3jDFSiQ+XZ2RZu9P dmiZxzfIFPLC1rUl X-Received: by 10.223.138.139 with SMTP id y11mr1550704wry.93.1497481294359; Wed, 14 Jun 2017 16:01:34 -0700 (PDT) Received: from bidouze.vm.6wind.com (host.78.145.23.62.rev.coltfrance.com. [62.23.145.78]) by smtp.gmail.com with ESMTPSA id f3sm1840947wrf.2.2017.06.14.16.01.32 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 14 Jun 2017 16:01:33 -0700 (PDT) Date: Thu, 15 Jun 2017 01:01:25 +0200 From: =?iso-8859-1?Q?Ga=EBtan?= Rivet To: Ferruh Yigit Cc: "Pattan, Reshma" , "dev@dpdk.org" Message-ID: <20170614230124.GZ29091@bidouze.vm.6wind.com> References: <87a12a85ab782a5995100ea1e2ae80a2c7e0ec5e.1496877060.git.gaetan.rivet@6wind.com> <3AEA2BF9852C6F48A459DA490692831F2A2133A4@irsmsx110.ger.corp.intel.com> <20170611194225.GO29091@bidouze.vm.6wind.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: Mutt/1.5.23 (2014-03-12) Subject: Re: [dpdk-dev] [PATCH v2 07/12] pdump: disabled by default X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 14 Jun 2017 23:01:35 -0000 Hi Ferruh, On Tue, Jun 13, 2017 at 06:15:45PM +0100, Ferruh Yigit wrote: > On 6/11/2017 8:42 PM, Gaëtan Rivet wrote: > > Hi Reshma, > > > > On Fri, Jun 09, 2017 at 02:24:58PM +0000, Pattan, Reshma wrote: > >> Hi, > >> > >>> -----Original Message----- > >>> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Gaetan Rivet > >>> Sent: Thursday, June 8, 2017 12:59 AM > >>> To: dev@dpdk.org > >>> Cc: Gaetan Rivet > >>> Subject: [dpdk-dev] [PATCH v2 07/12] pdump: disabled by default > >>> > >>> Signed-off-by: Gaetan Rivet > >>> --- > >>> config/common_base | 2 +- > >>> 1 file changed, 1 insertion(+), 1 deletion(-) > >>> > >>> diff --git a/config/common_base b/config/common_base index > >>> cade611..8ec5e4e 100644 > >>> --- a/config/common_base > >>> +++ b/config/common_base > >>> @@ -700,7 +700,7 @@ CONFIG_RTE_KNI_PREEMPT_DEFAULT=y # # Compile > >>> the pdump library # -CONFIG_RTE_LIBRTE_PDUMP=y > >>> +CONFIG_RTE_LIBRTE_PDUMP=n > >>> > >>> # > >>> # Compile vhost user library > >>> -- > >>> 2.1.4 > >> > >> Since, you already mentioned in other mail to Ferruh that config flag disabling patches are only for testers compilation purpose and you have plans to make proper fix by end of June. I will wait on for actual patch. > >> > > > > I said I planned to do so, but found out that I would not have enough > > time before the end of June. Sorry about the ambiguous phrasing. > > > > Do you think you will be able to fix this library in time? > > KNI uses / depends pci, I am not sure what to fix here. > > The problem to enable the KNI is build dependency problem, right? > > I guess problem will be fixes if we can build in following order: > - lib/eal > - drivers/bus > - lib > - drivers > > This was the case when bus drives compiled within eal. What do you think > about this build order? > Yes, that build order would fix the issue. However, IMO this is not the proper way to proceed. It obscures the architecture, the distinction between DPDK abstractions and their implementations. Looking quickly into this dependency, it seems that the PCI info is only used during allocation, and only to register PCI information within device infos. They do not seem used afterward at the library level, except to print some device description upon device start. They can be completely removed from KNI (both from the lib and the driver), without breaking the compilation. This however changes the API of rte_kni_alloc() and the ABI of rte_kni_conf. But it seems better than changing the build order and opening a can of all kind of worms, allowing a few libraries to skirt around their duty to remain generic and independent from abstraction implementations. Ideally KNI interfaces should be able to use any rte_device, not only PCI. But if it is forced to use only PCI devices, then pointing to an rte_pci_device seems a better way to proceed, as it has all those infos readily available. It would allow the PCI device to grow and evolve without breaking the KNI lib. Anyway, I think there are several possible solutions to this, before resorting to modifying the build order. > > > >> Please see if rte_pci.h can be removed from the includes of rte_pdump.c , might be unnecessary include. > >> > >> Thanks, > >> Reshma > > > -- Gaëtan Rivet 6WIND