Re: [dpdk-dev] [PATCH] vhost: added error log in vhost_user_set_features

Re: [dpdk-dev] [PATCH] vhost: added error log in vhost_user_set_features

[Yuanhan Liu]

On Fri, Jun 16, 2017 at 04:32:05PM +0200, Dariusz Stojaczyk wrote:
> Since vhost_user_set_features failure is not handled in any way, a
> single error log has been added to at least to let the user know that
> something has gone wrong.

Indeed. And applied to dpdk-next-virtio.

Thanks.

	--yliu

[dpdk-dev] [PATCH] vhost: added error log in vhost_user_set_features

[Dariusz Stojaczyk]

Since vhost_user_set_features failure is not handled in any way, a
single error log has been added to at least to let the user know that
something has gone wrong.

Signed-off-by: Dariusz Stojaczyk <dariuszx.stojaczyk@intel.com>
---
 lib/librte_vhost/vhost_user.c | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)

diff --git a/lib/librte_vhost/vhost_user.c b/lib/librte_vhost/vhost_user.c
index 5c8058b..b3aff90 100644
--- a/lib/librte_vhost/vhost_user.c
+++ b/lib/librte_vhost/vhost_user.c
@@ -164,8 +164,12 @@ vhost_user_set_features(struct virtio_net *dev, uint64_t features)
 	uint64_t vhost_features = 0;
 
 	rte_vhost_driver_get_features(dev->ifname, &vhost_features);
-	if (features & ~vhost_features)
+	if (features & ~vhost_features) {
+		RTE_LOG(ERR, VHOST_CONFIG,
+			"(%d) received invalid negotiated features.\n",
+			dev->vid);
 		return -1;
+	}
 
 	if ((dev->flags & VIRTIO_DEV_RUNNING) && dev->features != features) {
 		if (dev->notify_ops->features_changed)
-- 
2.7.4