Re: [dpdk-dev] [PATCH] app/testpmd: always build VF and MACsec functions

[Tiwei Bie <tiwei.bie@intel.com>]

On Thu, Jun 15, 2017 at 01:02:21PM +0200, Thomas Monjalon wrote:
> These functions are supported only on ixgbe.
[...]
> @@ -3013,15 +3013,21 @@ set_vf_traffic(portid_t port_id, uint8_t is_rx, uint16_t vf, uint8_t on)
>  
>  	if (diag == 0)
>  		return;
> -	if(is_rx)
> +	if(is_rx) {

It's better to also fix this coding style issue.

Best regards,
Tiwei Bie

>  		printf("rte_pmd_ixgbe_set_vf_rx for port_id=%d failed "
> -	       		"diag=%d\n", port_id, diag);
> -	else
> +				"diag=%d\n", port_id, diag);
> +		return;
> +	} else {
>  		printf("rte_pmd_ixgbe_set_vf_tx for port_id=%d failed "
> -	       		"diag=%d\n", port_id, diag);
> -
> -}
> +				"diag=%d\n", port_id, diag);
> +		return;
> +	}
>  #endif
> +	printf("VF %s setting not supported for port %d\n",
> +			is_rx ? "Rx" : "Tx", port_id);
> +	RTE_SET_USED(vf);
> +	RTE_SET_USED(on);
> +}
>  
>  int
>  set_queue_rate_limit(portid_t port_id, uint16_t queue_idx, uint16_t rate)
> -- 
> 2.13.1
>