From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by dpdk.org (Postfix) with ESMTP id 9C0A4374 for ; Tue, 20 Jun 2017 08:52:06 +0200 (CEST) Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by fmsmga103.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 19 Jun 2017 23:52:05 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.39,364,1493708400"; d="scan'208";a="116485210" Received: from debian-zgviawfucg.sh.intel.com (HELO debian-ZGViaWFuCg) ([10.239.67.43]) by fmsmga005.fm.intel.com with ESMTP; 19 Jun 2017 23:52:04 -0700 Date: Tue, 20 Jun 2017 14:53:22 +0800 From: Tiwei Bie To: Thomas Monjalon Cc: jingjing.wu@intel.com, wenzhuo.lu@intel.com, dev@dpdk.org Message-ID: <20170620065322.GA12786@debian-ZGViaWFuCg> References: <20170615110221.1395-1-thomas@monjalon.net> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20170615110221.1395-1-thomas@monjalon.net> User-Agent: Mutt/1.7.2 (2016-11-26) Subject: Re: [dpdk-dev] [PATCH] app/testpmd: always build VF and MACsec functions X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 20 Jun 2017 06:52:07 -0000 On Thu, Jun 15, 2017 at 01:02:21PM +0200, Thomas Monjalon wrote: > These functions are supported only on ixgbe. [...] > @@ -3013,15 +3013,21 @@ set_vf_traffic(portid_t port_id, uint8_t is_rx, uint16_t vf, uint8_t on) > > if (diag == 0) > return; > - if(is_rx) > + if(is_rx) { It's better to also fix this coding style issue. Best regards, Tiwei Bie > printf("rte_pmd_ixgbe_set_vf_rx for port_id=%d failed " > - "diag=%d\n", port_id, diag); > - else > + "diag=%d\n", port_id, diag); > + return; > + } else { > printf("rte_pmd_ixgbe_set_vf_tx for port_id=%d failed " > - "diag=%d\n", port_id, diag); > - > -} > + "diag=%d\n", port_id, diag); > + return; > + } > #endif > + printf("VF %s setting not supported for port %d\n", > + is_rx ? "Rx" : "Tx", port_id); > + RTE_SET_USED(vf); > + RTE_SET_USED(on); > +} > > int > set_queue_rate_limit(portid_t port_id, uint16_t queue_idx, uint16_t rate) > -- > 2.13.1 >