From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pf0-f196.google.com (mail-pf0-f196.google.com [209.85.192.196]) by dpdk.org (Postfix) with ESMTP id 315202C72 for ; Tue, 20 Jun 2017 10:23:04 +0200 (CEST) Received: by mail-pf0-f196.google.com with SMTP id w12so21447192pfk.0 for ; Tue, 20 Jun 2017 01:23:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fridaylinux-org.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=+kfE1mlYSq6UBb01T6uEW6Y8o3uJYLlscaFqs4RqW5U=; b=0ALVuAM7k8HSGhkjnpo7o0l81d2Z2uu6/9RsIZUL3WIsulbEcJxEB+rbE0l9xkonmR BQCQabEc9ntWuWBF7+iksowBW93ttdjYvCXc+mDc/Q5q9qKmfo6TWahZrLdzdUExRFQC N+A0E/9Jh+t10WcxW71Cl7C+PypFQiQjOHxIfjFtCHOmkgwivckCJLlTSa8QN5G9QnIr uwXNL5UI60W1pjGGz55SE/HlIAGhLCPoHFOvI+MRMDddOsLRnBozkn4lh7xxXtTxzyYf W/OJMa493PCKA6mHD8q4EfpmFGPvYMG+SRGDwhKRa98F5Q8C4nhOqCGaVSGjxMjizsW0 dHvw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=+kfE1mlYSq6UBb01T6uEW6Y8o3uJYLlscaFqs4RqW5U=; b=kyHm0Qbzs1bl+nOTxuOTE6omBa+SVyV551TEf99U3pUJIFcBmGePJZ9eOzp9apnYgP aVmHmz12+tm8SF7AOoEOONoV1+k+XsBTJliUYmFtp/dT7eRC1+JhTpsYLSDnxxdSf6l4 QCezV5vF8IYf5mHonTISHmODLraqA0nN7biQIWOKDTnmaQe1E0AHSKI01kTgDe9fcCc6 uo3bgPpLTG33RPz7qQnInl+7qWk/CriFl8Ny4BbkZpKoQLRuqfBtVsbZF3VARPjKObRh Ct7CrCqOwOqagbFLhhZEkcrockn+gozS/0btly7ux/qQYP3Wt7UXdALmgbxQbc+46vfU iuew== X-Gm-Message-State: AKS2vOwS46dt7U2aGTx2cuVDxmy5eLZXUfS6eCQcOPN+UXV1Dylr2RPw D8fa5jlFLMDMZ3dS X-Received: by 10.84.178.101 with SMTP id y92mr34323285plb.116.1497946983169; Tue, 20 Jun 2017 01:23:03 -0700 (PDT) Received: from yliu-home ([45.63.61.64]) by smtp.gmail.com with ESMTPSA id x5sm25410733pfi.103.2017.06.20.01.23.00 (version=TLS1 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Tue, 20 Jun 2017 01:23:01 -0700 (PDT) Date: Tue, 20 Jun 2017 16:22:56 +0800 From: Yuanhan Liu To: Thomas Monjalon Cc: santosh , dev@dpdk.org, olivier.matz@6wind.com, shreyansh.jain@nxp.com, stable@dpdk.org Message-ID: <20170620082256.GA436@yliu-home> References: <20170608142831.28166-1-santosh.shukla@caviumnetworks.com> <2170817.cQF1WCe9mM@xps> <2118823.ueSLhbdIFl@xps> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <2118823.ueSLhbdIFl@xps> User-Agent: Mutt/1.6.1 (2016-04-27) Subject: Re: [dpdk-dev] [PATCH v2] test/test_mbuf: remove mempool global var X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 20 Jun 2017 08:23:04 -0000 On Tue, Jun 20, 2017 at 09:35:07AM +0200, Thomas Monjalon wrote: > 20/06/2017 06:14, santosh: > > On Tuesday 20 June 2017 02:07 AM, Thomas Monjalon wrote: > > > > > 08/06/2017 16:28, Santosh Shukla: > > >> Let test_mbuf alloc and free mempool. > > >> > > >> Cc: stable@dpdk.org > > >> Signed-off-by: Santosh Shukla > > > Why Cc stable? > > > Is it fixing something? > > > > > w/o this fix, application can't run more than once. > > Reason: Static allocation of resources and exiting w/o freeing so leak. > > > > Patch makes app resource handling dynamic and Now user could run > > test more than once and app exits gracefully. thats why Cc: stable a need (IHMO). > > Thanks. > > OK > So we need a Fixes: tag in order to be able to guess which > release it should be backported to. Also, I would suggest you to include above info (the real issue) in the commit log. --yliu