From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by dpdk.org (Postfix) with ESMTP id E40EB374 for ; Tue, 20 Jun 2017 11:22:43 +0200 (CEST) Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by orsmga101.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 20 Jun 2017 02:22:42 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.39,364,1493708400"; d="scan'208";a="1162511899" Received: from bricha3-mobl3.ger.corp.intel.com ([10.237.221.28]) by fmsmga001.fm.intel.com with SMTP; 20 Jun 2017 02:22:40 -0700 Received: by (sSMTP sendmail emulation); Tue, 20 Jun 2017 10:22:39 +0100 Date: Tue, 20 Jun 2017 10:22:39 +0100 From: Bruce Richardson To: Thomas Monjalon Cc: "De Lara Guarch, Pablo" , dev@dpdk.org, "Wu, Jingjing" Message-ID: <20170620092239.GA39980@bricha3-MOBL3.ger.corp.intel.com> References: <20170609023044.75127-1-pablo.de.lara.guarch@intel.com> <20170615040403.78712-1-pablo.de.lara.guarch@intel.com> <2741486.Oz5ccjHQup@xps> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <2741486.Oz5ccjHQup@xps> Organization: Intel Research and =?iso-8859-1?Q?De=ACvel?= =?iso-8859-1?Q?opment?= Ireland Ltd. User-Agent: Mutt/1.8.1 (2017-04-11) Subject: Re: [dpdk-dev] [PATCH v3] app/testpmd: add parameter to start forwarding TX first X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 20 Jun 2017 09:22:44 -0000 On Mon, Jun 19, 2017 at 11:12:53PM +0200, Thomas Monjalon wrote: > 15/06/2017 14:05, De Lara Guarch, Pablo: > > > Add parameter to start forwarding sending first > > > a burst of packets, which is useful when testing > > > a loopback connection. > > > > > > This was already implemented as an internal command, > > > but adding it as a parameter is interesting, as it > > > allows the user to test a loopback connection without > > > entering in the internal command line. > > > > > > Signed-off-by: Pablo de Lara > > > --- > > > --- a/doc/guides/testpmd_app_ug/run_app.rst > > > +++ b/doc/guides/testpmd_app_ug/run_app.rst > > > @@ -188,6 +188,14 @@ The commandline options are: > > > > > > Start forwarding on initialization. > > > > > > +* ``--tx-first`` > > > + > > > + Start forwarding, after sending a burst of packets first. > > > + > > > +.. Note:: > > > + > > > + This flag should be only used in non-interactive mode. > > I don't really understand the benefit of this option. > Why is it better than > echo start tx_first | testpmd -i > ? The one big difference I see is normal vs abnormal termination. With the echo command you suggest, the only way to terminate testpmd is to kill it via signal. With the extra cmdline option, it will cleanly exit via enter as with non-interactive mode right now. Not a huge difference, but I think having the extra argument to enable tx-first is useful. /Bruce