DPDK patches and discussions
 help / color / mirror / Atom feed
From: Jerin Jacob <jerin.jacob@caviumnetworks.com>
To: Harry van Haaren <harry.van.haaren@intel.com>
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH] event/sw: fix mapped qid count with parallel queue
Date: Tue, 20 Jun 2017 19:41:14 +0530	[thread overview]
Message-ID: <20170620141113.GB16157@jerin> (raw)
In-Reply-To: <1496829884-189816-1-git-send-email-harry.van.haaren@intel.com>

-----Original Message-----
> Date: Wed, 7 Jun 2017 11:04:44 +0100
> From: Harry van Haaren <harry.van.haaren@intel.com>
> To: dev@dpdk.org
> CC: jerin.jacob@caviumnetworks.com, Harry van Haaren
>  <harry.van.haaren@intel.com>
> Subject: [PATCH] event/sw: fix mapped qid count with parallel queue
> X-Mailer: git-send-email 2.7.4
> 
> This commit fixes the counting of mapped queues to a port,
> when the type of queue type is PARALLEL. Not incrementing
> the count here could lead to an underflow of the count when
> unlinking at a later date.
> 
> Fixes: 371a688fc159 ("event/sw: support linking queues to ports")

Applied to dpdk-next-eventdev/master. Thanks.

> 
> Reported-by: Jesse Bruni <jesse.bruni@intel.com>
> Signed-off-by: Harry van Haaren <harry.van.haaren@intel.com>
> ---
>  drivers/event/sw/sw_evdev.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/event/sw/sw_evdev.c b/drivers/event/sw/sw_evdev.c
> index a31aaa6..235e0cc 100644
> --- a/drivers/event/sw/sw_evdev.c
> +++ b/drivers/event/sw/sw_evdev.c
> @@ -90,7 +90,8 @@ sw_port_link(struct rte_eventdev *dev, void *port, const uint8_t queues[],
>  		} else if (q->type == RTE_SCHED_TYPE_ORDERED) {
>  			p->num_ordered_qids++;
>  			p->num_qids_mapped++;
> -		} else if (q->type == RTE_SCHED_TYPE_ATOMIC) {
> +		} else if (q->type == RTE_SCHED_TYPE_ATOMIC ||
> +				q->type == RTE_SCHED_TYPE_PARALLEL) {
>  			p->num_qids_mapped++;
>  		}
>  
> -- 
> 2.7.4
> 

      reply	other threads:[~2017-06-20 14:11 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-06-07 10:04 Harry van Haaren
2017-06-20 14:11 ` Jerin Jacob [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170620141113.GB16157@jerin \
    --to=jerin.jacob@caviumnetworks.com \
    --cc=dev@dpdk.org \
    --cc=harry.van.haaren@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).