* [dpdk-dev] [PATCH] event/octeontx: improve dequeue performance
@ 2017-06-09 12:06 Jerin Jacob
2017-06-13 23:06 ` Eads, Gage
0 siblings, 1 reply; 3+ messages in thread
From: Jerin Jacob @ 2017-06-09 12:06 UTC (permalink / raw)
To: dev; +Cc: hemant.agrawal, gage.eads, harry.van.haaren, Jerin Jacob
switch tag wait is a costly operation as it may
translate to IOB read if core swtag cache is not updated.
Do tag switch wait only when there is a tag request on
the same hardware work slot.
Signed-off-by: Jerin Jacob <jerin.jacob@caviumnetworks.com>
---
drivers/event/octeontx/ssovf_worker.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/event/octeontx/ssovf_worker.c b/drivers/event/octeontx/ssovf_worker.c
index ad3fe684d..1b372148f 100644
--- a/drivers/event/octeontx/ssovf_worker.c
+++ b/drivers/event/octeontx/ssovf_worker.c
@@ -126,9 +126,9 @@ ssows_deq(void *port, struct rte_event *ev, uint64_t timeout_ticks)
RTE_SET_USED(timeout_ticks);
- ssows_swtag_wait(ws);
if (ws->swtag_req) {
ws->swtag_req = 0;
+ ssows_swtag_wait(ws);
return 1;
} else {
return ssows_get_work(ws, ev);
@@ -142,9 +142,9 @@ ssows_deq_timeout(void *port, struct rte_event *ev, uint64_t timeout_ticks)
uint64_t iter;
uint16_t ret = 1;
- ssows_swtag_wait(ws);
if (ws->swtag_req) {
ws->swtag_req = 0;
+ ssows_swtag_wait(ws);
} else {
ret = ssows_get_work(ws, ev);
for (iter = 1; iter < timeout_ticks && (ret == 0); iter++)
--
2.13.1
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [dpdk-dev] [PATCH] event/octeontx: improve dequeue performance
2017-06-09 12:06 [dpdk-dev] [PATCH] event/octeontx: improve dequeue performance Jerin Jacob
@ 2017-06-13 23:06 ` Eads, Gage
2017-06-20 14:19 ` Jerin Jacob
0 siblings, 1 reply; 3+ messages in thread
From: Eads, Gage @ 2017-06-13 23:06 UTC (permalink / raw)
To: Jerin Jacob, dev; +Cc: hemant.agrawal, Van Haaren, Harry
> -----Original Message-----
> From: Jerin Jacob [mailto:jerin.jacob@caviumnetworks.com]
> Sent: Friday, June 9, 2017 7:07 AM
> To: dev@dpdk.org
> Cc: hemant.agrawal@nxp.com; Eads, Gage <gage.eads@intel.com>; Van
> Haaren, Harry <harry.van.haaren@intel.com>; Jerin Jacob
> <jerin.jacob@caviumnetworks.com>
> Subject: [dpdk-dev] [PATCH] event/octeontx: improve dequeue performance
>
> switch tag wait is a costly operation as it may translate to IOB read if core
> swtag cache is not updated.
> Do tag switch wait only when there is a tag request on the same hardware
> work slot.
>
> Signed-off-by: Jerin Jacob <jerin.jacob@caviumnetworks.com>
Acked-by: Gage Eads <gage.eads@intel.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [dpdk-dev] [PATCH] event/octeontx: improve dequeue performance
2017-06-13 23:06 ` Eads, Gage
@ 2017-06-20 14:19 ` Jerin Jacob
0 siblings, 0 replies; 3+ messages in thread
From: Jerin Jacob @ 2017-06-20 14:19 UTC (permalink / raw)
To: Eads, Gage; +Cc: dev, hemant.agrawal, Van Haaren, Harry
-----Original Message-----
> Date: Tue, 13 Jun 2017 23:06:27 +0000
> From: "Eads, Gage" <gage.eads@intel.com>
> To: Jerin Jacob <jerin.jacob@caviumnetworks.com>, "dev@dpdk.org"
> <dev@dpdk.org>
> CC: "hemant.agrawal@nxp.com" <hemant.agrawal@nxp.com>, "Van Haaren, Harry"
> <harry.van.haaren@intel.com>
> Subject: RE: [dpdk-dev] [PATCH] event/octeontx: improve dequeue performance
>
>
> > -----Original Message-----
> > From: Jerin Jacob [mailto:jerin.jacob@caviumnetworks.com]
> > Sent: Friday, June 9, 2017 7:07 AM
> > To: dev@dpdk.org
> > Cc: hemant.agrawal@nxp.com; Eads, Gage <gage.eads@intel.com>; Van
> > Haaren, Harry <harry.van.haaren@intel.com>; Jerin Jacob
> > <jerin.jacob@caviumnetworks.com>
> > Subject: [dpdk-dev] [PATCH] event/octeontx: improve dequeue performance
> >
> > switch tag wait is a costly operation as it may translate to IOB read if core
> > swtag cache is not updated.
> > Do tag switch wait only when there is a tag request on the same hardware
> > work slot.
> >
> > Signed-off-by: Jerin Jacob <jerin.jacob@caviumnetworks.com>
>
> Acked-by: Gage Eads <gage.eads@intel.com>
Applied to dpdk-next-eventdev/master. Thanks.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2017-06-20 14:19 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-06-09 12:06 [dpdk-dev] [PATCH] event/octeontx: improve dequeue performance Jerin Jacob
2017-06-13 23:06 ` Eads, Gage
2017-06-20 14:19 ` Jerin Jacob
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).