From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wr0-f181.google.com (mail-wr0-f181.google.com [209.85.128.181]) by dpdk.org (Postfix) with ESMTP id 4F00C37A6 for ; Wed, 21 Jun 2017 11:26:47 +0200 (CEST) Received: by mail-wr0-f181.google.com with SMTP id y25so87228901wrd.2 for ; Wed, 21 Jun 2017 02:26:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to :user-agent; bh=DDgBRmtFJAP1lz0DLDNZCN7ZAQxOGW0lCGsyAyBASbU=; b=sfOcvf736/rdPRCWod/kovYkn2gt5K4oUU2QasjDVnDDyuA62LpmkeRLfZ0+V8/D7h /uIF2Wk8CWbQBCphl5R9a4G9kVf6sJgufQ6B4Mi0y9eJ48yO3UdA/NAn6GpFieuBrNa4 jkNlmEwXpZKbdwYlVnLE4tx8x87MBkF5QCyf87PLMMhIgmAjKhpvaRDG3jt9V3YpjMi1 0AjLVxxH9kwVCkamSxD1JVRaMpx/wMfZMizezHcF4cO5gWst7Z7Xy4sA1jQxHiH/0s7H gPTLEpAbl7hmxL9r/k5w/hmP/Ok8S03pWBNAjXMzTPLvr4AsC+tsA8j4BkprOdgGOIxz RUpQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to:user-agent; bh=DDgBRmtFJAP1lz0DLDNZCN7ZAQxOGW0lCGsyAyBASbU=; b=Y79ejvyNYGUM3KZUt/7JDYsAKkmZV1ZJQRSwjgRpX6lokoVznsqete7ha0N2QpPqIS 6Zge08L6TlFqzUbJGCPXbOJ7yIKnpSoSBZH6Pe9MUVEmMPDdE2CvWC6vthnImLTqA+Sg w6USVoipgzoAph4GuR1B158BE5h6bXqgk8wDKi9E49sZB/VSvABAXJXwi1C29koW/5eR itoKN/fNpWIGuxXg7M8rWSgdHJJmyCRDXo3BQJYqyA86pbzcOYh6Y+eoXb1iNQ0TLXPL BDafIYif01w/f9A5FtGi6RVwmRHIr28utE87CsRz9f0f5IfFXmrduXJrtsIjMQ/Bjt5V wLxQ== X-Gm-Message-State: AKS2vOwc5g5Z2dQCo/l392/aAAtcuJNjmHtEpmaKteh4j6ZGjwoTRE5S 4QO/IDty30b5jFcMrW4= X-Received: by 10.223.145.78 with SMTP id j72mr22290126wrj.7.1498037206851; Wed, 21 Jun 2017 02:26:46 -0700 (PDT) Received: from bidouze.vm.6wind.com (host.78.145.23.62.rev.coltfrance.com. [62.23.145.78]) by smtp.gmail.com with ESMTPSA id x71sm28096646wmd.32.2017.06.21.02.26.45 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 21 Jun 2017 02:26:45 -0700 (PDT) Date: Wed, 21 Jun 2017 11:26:38 +0200 From: =?iso-8859-1?Q?Ga=EBtan?= Rivet To: Thomas Monjalon Cc: dev@dpdk.org Message-ID: <20170621092637.GC2344@bidouze.vm.6wind.com> References: <4a5ed1297b9b79329179e8aae8fd336bf98f6b97.1497999952.git.gaetan.rivet@6wind.com> <1948577.YXIUannuor@xps> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1948577.YXIUannuor@xps> User-Agent: Mutt/1.5.23 (2014-03-12) Subject: Re: [dpdk-dev] [PATCH v3 4/9] bus: properly include rte_debug X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 21 Jun 2017 09:26:47 -0000 On Wed, Jun 21, 2017 at 09:45:12AM +0200, Thomas Monjalon wrote: > 21/06/2017 01:36, Gaetan Rivet: > > Signed-off-by: Gaetan Rivet > > Please add a comment to explain why this include is required now. This commit will have this comment in the next version: This include is necessary for rte_bus, but it is currently brought by eal_private.h including rte_pci.h, including rte_debug.h. rte_pci.h will move out of the EAL. All compilation units should be self-sufficient include-wise. Cheers, -- Gaëtan Rivet 6WIND