From: Stephen Hemminger <stephen@networkplumber.org>
To: Shahaf Shuler <shahafs@mellanox.com>,
Pascal Mazon <pascal.mazon@6wind.com>
Cc: dev@dpdk.org
Subject: [dpdk-dev] DPDK drivers should not use kernel version
Date: Wed, 21 Jun 2017 09:28:43 -0700 [thread overview]
Message-ID: <20170621092843.72606c72@xeon-e3> (raw)
Looking at some other issues, I noticed that both the TAP and MLX5 device
drivers are looking at kernel version through uname. Although this may
seem like a good way to deal with kernel API changes, it is not reliable.
Enterprise kernel distro vendors never change kernel version but do backport
features from later kernels. Therefore the behavior expected may change
even though kernel version doesn't change. Also kernel version does not
dictate that the expected feature (like flower) is in the kernel configuration.
I recommend this be looked for in all future submissions. Maybe even flagged
as error in DPDK version of checkpatch.
$ git blame drivers/net/mlx5/mlx5_ethdev.c | grep uname
3a49ffe38a950 (Shahaf Shuler 2017-02-09 14:29:54 +0200 895) if (uname(&utsname) == -1 ||
$ git blame drivers/net/tap/rte_eth_tap.c | grep uname
de96fe68ae959 (Pascal Mazon 2017-03-23 09:33:57 +0100 1169) if (uname(&utsname) == -1 ||
next reply other threads:[~2017-06-21 16:28 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-21 16:28 Stephen Hemminger [this message]
2017-06-23 7:33 ` Hemant Agrawal
2017-06-23 17:55 ` Stephen Hemminger
2017-06-25 6:03 ` Shahaf Shuler
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170621092843.72606c72@xeon-e3 \
--to=stephen@networkplumber.org \
--cc=dev@dpdk.org \
--cc=pascal.mazon@6wind.com \
--cc=shahafs@mellanox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).