From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pf0-f169.google.com (mail-pf0-f169.google.com [209.85.192.169]) by dpdk.org (Postfix) with ESMTP id 531F27CEA for ; Wed, 21 Jun 2017 18:28:51 +0200 (CEST) Received: by mail-pf0-f169.google.com with SMTP id e7so7464376pfk.0 for ; Wed, 21 Jun 2017 09:28:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:mime-version :content-transfer-encoding; bh=x6njDCR0A+6NCyGsaYo44kjO8O2Jlp/l6bIRkObXlNw=; b=iFGTxbRVh4hhXEER6S3NjG8f3TXZYBpVtjUHMbk5LugvFIz4SQzSSpmAw5v/qy30Go MGitEqpEMZiYvAFw91lRxwm9GgGsV93Zygmq5nG7pHqsJQQBKzBtpgGjLIsyUhkuR6CN i1c690A9oeR/OH0/XM6eT9MiJgdcZY8X6NZ/tz6rbGMfp/PONq0D+d9y/XiJkfLdoPQ6 9eyppeqGr9+ATIdBl5cL4WCs2gq4HPa41EPHSntjTOXKCtl6ZQOeqUtTqQIOjV1fwLU1 YUSk3FoCsTQdCklfK3ERJ9IqFCM1VZjoaUGvAdBxQ41uYsTfgc5vW0a796umFaLNXmSV tUSg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:mime-version :content-transfer-encoding; bh=x6njDCR0A+6NCyGsaYo44kjO8O2Jlp/l6bIRkObXlNw=; b=WRZ944N+6451bFzhBEkCVFyTuEUDPCICMIIz1WIcRtOqUalJSZVWUnSSCWMnsXLOwe zSNlwV9sa+VfmX0EhgieX4aH+QNFtyvX/NLA8I5IvUxaB4quNAWsdWRtFr1mqvfQ2Qz6 PAV4kDdZSWUk2wAX9vkGtYTJXHzsl6F7n76VKnWU02dJ87C4yuRduFs7ztmqkMFIFpci PFH5lKgGurGF2/8WRncgdDhYEiZPppMxJsqJdNC+gCdPrdgV/YsQ6sX/C+WHYgZl0ABX EXm0m479/ZFLRx2S99q/sNciYZh4ihRET08tQZarJMBnbRXVGk04FODo5wuNjO5HSrP3 3MMQ== X-Gm-Message-State: AKS2vOyLYaDtgj2WWXwT2RUS9jUyxaD7T3BQmvgQ8O4qlAQ1ycu+iIK0 UqCAlFbZ1J0qkANI X-Received: by 10.98.102.151 with SMTP id s23mr37382414pfj.22.1498062530605; Wed, 21 Jun 2017 09:28:50 -0700 (PDT) Received: from xeon-e3 (76-14-207-240.or.wavecable.com. [76.14.207.240]) by smtp.gmail.com with ESMTPSA id 69sm32759858pfy.119.2017.06.21.09.28.50 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Wed, 21 Jun 2017 09:28:50 -0700 (PDT) Date: Wed, 21 Jun 2017 09:28:43 -0700 From: Stephen Hemminger To: Shahaf Shuler , Pascal Mazon Cc: dev@dpdk.org Message-ID: <20170621092843.72606c72@xeon-e3> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: [dpdk-dev] DPDK drivers should not use kernel version X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 21 Jun 2017 16:28:51 -0000 Looking at some other issues, I noticed that both the TAP and MLX5 device drivers are looking at kernel version through uname. Although this may seem like a good way to deal with kernel API changes, it is not reliable. Enterprise kernel distro vendors never change kernel version but do backport features from later kernels. Therefore the behavior expected may change even though kernel version doesn't change. Also kernel version does not dictate that the expected feature (like flower) is in the kernel configuration. I recommend this be looked for in all future submissions. Maybe even flagged as error in DPDK version of checkpatch. $ git blame drivers/net/mlx5/mlx5_ethdev.c | grep uname 3a49ffe38a950 (Shahaf Shuler 2017-02-09 14:29:54 +0200 895) if (uname(&utsname) == -1 || $ git blame drivers/net/tap/rte_eth_tap.c | grep uname de96fe68ae959 (Pascal Mazon 2017-03-23 09:33:57 +0100 1169) if (uname(&utsname) == -1 ||