From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wr0-f175.google.com (mail-wr0-f175.google.com [209.85.128.175]) by dpdk.org (Postfix) with ESMTP id 29B79548B for ; Wed, 21 Jun 2017 11:40:37 +0200 (CEST) Received: by mail-wr0-f175.google.com with SMTP id r103so126996126wrb.0 for ; Wed, 21 Jun 2017 02:40:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to :user-agent; bh=imk7sis37vLwShouSOIH+4u8xUHXhjvYe8JYuLgU0vs=; b=YHNmxcHvMVWu1LvcvYpDTAgjAOTsz9CNiWwDmaLkkn0XpiHjze7UELiAQLoPGgbiME mZezL/DdVuPd8dwHSp/XMPe5LKgFsL+G2u3U7xCAsXwWaNxC93jv4eDS8CrQY84RR0SX 06CeE65snmOgLVa9omay72YkaT1DOgnqa9fpkIFZP1KqZhFtaxpqAsRbUJTviJOhoXu3 i/Zu7JAP9GPFuHwghLWvr0BlRiU0oYUiKF8OguQ8bUqkkb+mQEurD7zKuYuJBJvqtPgO Dgg4EwXn9PHGEUvmnCNa8ZACqyuxHvFWADYb/nCo6rrevZwf1E/FLEJX001XKP05UmLV 0UcQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to:user-agent; bh=imk7sis37vLwShouSOIH+4u8xUHXhjvYe8JYuLgU0vs=; b=LOFgNAI0gQWP9a/Ygnmrfa/tnvck/jGCtxtk+SomE4Hfi/cgP6sd9DKMjE6fOcxj8w 2iR0MB7+2TIbYKg+NcG1iOInTFYqeDV7ucQ8fE9ukKZs/LhgL8jqKu9BEFUkCXRNL6Ba KElLXPHoGLoywU2ZY+/2oUYefZZY1f+b88RwdnXQbHWxfrwm41hGzLe05hzQh5peHaRh u2e9yhZF+kLjs8TJDF5oQhPzTRdqBG4jTSmhfGc+1V0A2++GQZPYRE32S1mkHb117MpM HNEXMVJn24pG/B8nxbB+FeClMWIBqFziqMMY9iocHwrbFxo/uayhH5njlQN6BoCbs7bS pDiQ== X-Gm-Message-State: AKS2vOw0cEKa5znqyEH1qnOtWuatM30xjqX8T1SdrFDLbaABWJ3hfMIB oJSEJnCdcF9DLMF9yAY= X-Received: by 10.223.131.66 with SMTP id 60mr11017038wrd.54.1498038036774; Wed, 21 Jun 2017 02:40:36 -0700 (PDT) Received: from bidouze.vm.6wind.com (host.78.145.23.62.rev.coltfrance.com. [62.23.145.78]) by smtp.gmail.com with ESMTPSA id l6sm9964162wmg.31.2017.06.21.02.40.35 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 21 Jun 2017 02:40:36 -0700 (PDT) Date: Wed, 21 Jun 2017 11:40:26 +0200 From: =?iso-8859-1?Q?Ga=EBtan?= Rivet To: Thomas Monjalon Cc: dev@dpdk.org Message-ID: <20170621094026.GD2344@bidouze.vm.6wind.com> References: <78a1d2393d08ec3152f01be35d29401447ce616f.1497999952.git.gaetan.rivet@6wind.com> <8418992.7tWpiUoDtu@xps> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <8418992.7tWpiUoDtu@xps> User-Agent: Mutt/1.5.23 (2014-03-12) Subject: Re: [dpdk-dev] [PATCH v3 5/9] pmdinfogen: move to drivers subdirectory X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 21 Jun 2017 09:40:37 -0000 On Wed, Jun 21, 2017 at 09:57:18AM +0200, Thomas Monjalon wrote: > 21/06/2017 01:36, Gaetan Rivet: > > pmdinfogen has a dependency on the PCI bus. The latter must be built > > first. > > I think it should not be moved outside of buildtools. > Right, I agree. I took the simplest path here, but if there is a better solution to be found I'd prefer to use it. > The build order can be fixed by installing headers before any compilation > like proposed in this RFC: http://dpdk.org/patch/25463 > This RFC should be discussed on its own merit, I will chime in the relevant thread. > Another (probably better) solution is to keep basic definitions > and helpers in EAL: > - rte_pci.h keeps only some PCI definitions and helpers > like rte_pci_addr and eal_parse_pci_BDF() in EAL > - bus management is done in the PCI driver > > For pmdinfogen, we just need struct rte_pci_id. > Other tools or applications will probably need this kind of basic > struct and functions available in EAL. I mostly agree, this proposal should be kept to a minimum at first for this release and carefully expanded afterward. If that's ok, I will propose a new version of this patchset with a new librte_pci, that might fix both pmdinfogen and librte_kni. -- Gaëtan Rivet 6WIND