From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by dpdk.org (Postfix) with ESMTP id B979837B7 for ; Mon, 26 Jun 2017 17:14:54 +0200 (CEST) Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by orsmga101.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 26 Jun 2017 08:14:53 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.39,396,1493708400"; d="scan'208";a="871842925" Received: from dwdohert-dpdk.ir.intel.com ([163.33.210.152]) by FMSMGA003.fm.intel.com with ESMTP; 26 Jun 2017 08:14:52 -0700 From: Declan Doherty To: dev@dpdk.org Cc: Declan Doherty Date: Mon, 26 Jun 2017 16:13:47 +0100 Message-Id: <20170626151347.16680-1-declan.doherty@intel.com> X-Mailer: git-send-email 2.9.4 Subject: [dpdk-dev] [PATCH] net/bond: change link status check to no-wait X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 26 Jun 2017 15:14:55 -0000 In the 802.3ad periodic callback function the link status of all slaves is checked using rte_eth_link_get function. Depending on the slave device this function can block for up to 9 seconds and therefore could cause issues with the LACP Daemon state machine and control patches handling. This patch changes to the no-wait version of the link get function. Fixes: 46fb4368 ("bond:add mode 4") Signed-off-by: Declan Doherty --- drivers/net/bonding/rte_eth_bond_8023ad.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/bonding/rte_eth_bond_8023ad.c b/drivers/net/bonding/rte_eth_bond_8023ad.c index d2b7592..3a97336 100644 --- a/drivers/net/bonding/rte_eth_bond_8023ad.c +++ b/drivers/net/bonding/rte_eth_bond_8023ad.c @@ -758,7 +758,7 @@ bond_mode_8023ad_periodic_cb(void *arg) uint16_t key; slave_id = internals->active_slaves[i]; - rte_eth_link_get(slave_id, &link_info); + rte_eth_link_get_nowait(slave_id, &link_info); rte_eth_macaddr_get(slave_id, &slave_addr); if (link_info.link_status != 0) { -- 2.9.4