From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by dpdk.org (Postfix) with ESMTP id 3127C2C8 for ; Tue, 27 Jun 2017 13:21:44 +0200 (CEST) Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by orsmga104.jf.intel.com with ESMTP; 27 Jun 2017 04:21:43 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.39,399,1493708400"; d="scan'208";a="119715492" Received: from bricha3-mobl3.ger.corp.intel.com ([10.237.221.28]) by fmsmga006.fm.intel.com with SMTP; 27 Jun 2017 04:21:40 -0700 Received: by (sSMTP sendmail emulation); Tue, 27 Jun 2017 12:21:40 +0100 Date: Tue, 27 Jun 2017 12:21:40 +0100 From: Bruce Richardson To: Ferruh Yigit Cc: Radu Nicolau , dev@dpdk.org, wenzhuo.lu@intel.com, reshma.pattan@intel.com, michalx.k.jastrzebski@intel.com, deepak.k.jain@intel.com, harry.van.haaren@intel.com, piotrx.t.azarewicz@intel.com Message-ID: <20170627112139.GB105608@bricha3-MOBL3.ger.corp.intel.com> References: <20170522143202.22424-2-michalx.k.jastrzebski@intel.com> <1498470133-29788-1-git-send-email-radu.nicolau@intel.com> <4375ffd8-6957-7f53-a9b0-081e705a5eb1@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4375ffd8-6957-7f53-a9b0-081e705a5eb1@intel.com> Organization: Intel Research and =?iso-8859-1?Q?De=ACvel?= =?iso-8859-1?Q?opment?= Ireland Ltd. User-Agent: Mutt/1.8.1 (2017-04-11) Subject: Re: [dpdk-dev] [PATCH v2] drivers/net: add support for IF-MIB and EtherLike-MIB for e1000 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 27 Jun 2017 11:21:45 -0000 On Tue, Jun 27, 2017 at 12:08:56PM +0100, Ferruh Yigit wrote: > On 6/26/2017 10:42 AM, Radu Nicolau wrote: > > From: Michal Jastrzebski > > > > If-MIB xstats: > > ifNumber > > ifIndex > > ifType > > ifMtu > > ifSpeed > > ifPhysAddress > > ifOperStatus > > ifLastChange > > ifHighSpeed > > ifConnectorPresent > > ifCounterDiscontinuityTime > > > > EtherLike-MIB xstats: > > dot3PauseOperMode > > dot3StatsDuplexStatus > > dot3StatsRateControlAbility > > dot3StatsRateControlStatus > > dot3ControlFunctionsSupported > > > > -updated in v2: coding style > > > > Signed-off-by: Piotr Azarewicz > > Signed-off-by: Michal Jastrzebski > > Signed-off-by: Radu Nicolau > > <...> > > This patch implements MIBs for some Intel drivers using xstats, this is > easy way to get some information from PMDs. > > But there was a outstanding comment to make this ethdev layer. > > So I believe we have two options: > > [1] > Each PMD implements MIBs using xstats, this is pragmatic solution and > each PMD can implement whichever MIBs they want. > > [2] > Implement a ethdev layer API and add a new dev_ops to get MIBs, API can > use existing methods to get required information, and if it fails can > call dev_ops which can be similar to the xstats. > Because of API all PMDs can have a small amount of support by default > and they can implement dev_ops for more support. > > > Although 2) looks more generic and proper, I am not really sure if that > is overkill and if this worth to the effort and to have new API and > dev_ops, comparing current method is easy to implement, any comments? > For 2, does the "use existing methods" include calling xstats? If so, then we can just drop the requirement for 2 to have any new functions implemented in the driver. Instead, have the information provided by drivers in the normal xstats call, but have a new ethdev API to provide that information to the app - basically hiding the xstats complexity underneath. /Bruce