From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by dpdk.org (Postfix) with ESMTP id EFB3B235 for ; Tue, 27 Jun 2017 15:54:38 +0200 (CEST) Received: from orsmga004.jf.intel.com ([10.7.209.38]) by orsmga103.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 27 Jun 2017 06:54:37 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.39,399,1493708400"; d="scan'208";a="101924775" Received: from bricha3-mobl3.ger.corp.intel.com ([10.237.221.28]) by orsmga004.jf.intel.com with SMTP; 27 Jun 2017 06:54:35 -0700 Received: by (sSMTP sendmail emulation); Tue, 27 Jun 2017 14:54:35 +0100 Date: Tue, 27 Jun 2017 14:54:34 +0100 From: Bruce Richardson To: Gaetan Rivet Cc: dev@dpdk.org, Jan Blunck Message-ID: <20170627135434.GH104744@bricha3-MOBL3.ger.corp.intel.com> References: <0094d130d0bc93de5d676b67aa28acf6dc81d37b.1498436062.git.gaetan.rivet@6wind.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <0094d130d0bc93de5d676b67aa28acf6dc81d37b.1498436062.git.gaetan.rivet@6wind.com> Organization: Intel Research and =?iso-8859-1?Q?De=ACvel?= =?iso-8859-1?Q?opment?= Ireland Ltd. User-Agent: Mutt/1.8.1 (2017-04-11) Subject: Re: [dpdk-dev] [PATCH v5 04/12] bus: add bus iterator to find a device X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 27 Jun 2017 13:54:39 -0000 On Mon, Jun 26, 2017 at 02:22:02AM +0200, Gaetan Rivet wrote: > From: Jan Blunck > > Signed-off-by: Jan Blunck > Signed-off-by: Gaetan Rivet > --- > lib/librte_eal/bsdapp/eal/rte_eal_version.map | 1 + > lib/librte_eal/common/eal_common_bus.c | 24 +++++++++++++++++++++++ > lib/librte_eal/common/include/rte_bus.h | 26 +++++++++++++++++++++++++ > lib/librte_eal/linuxapp/eal/rte_eal_version.map | 1 + > 4 files changed, 52 insertions(+) > > diff --git a/lib/librte_eal/bsdapp/eal/rte_eal_version.map b/lib/librte_eal/bsdapp/eal/rte_eal_version.map > index f1a0765..21640d6 100644 > --- a/lib/librte_eal/bsdapp/eal/rte_eal_version.map > +++ b/lib/librte_eal/bsdapp/eal/rte_eal_version.map > @@ -164,6 +164,7 @@ DPDK_17.05 { > > rte_bus_find; > rte_bus_find_by_device; > + rte_bus_find_device; > rte_cpu_is_supported; > rte_log_dump; > rte_log_register; > diff --git a/lib/librte_eal/common/eal_common_bus.c b/lib/librte_eal/common/eal_common_bus.c > index d208214..63fd9f1 100644 > --- a/lib/librte_eal/common/eal_common_bus.c > +++ b/lib/librte_eal/common/eal_common_bus.c > @@ -190,3 +190,27 @@ rte_bus_find_by_device(const struct rte_device *dev) > { > return rte_bus_find(bus_find_device, (const void *)dev, NULL); > } > + > +struct rte_device * > +rte_bus_find_device(rte_dev_cmp_t cmp, const void *data, > + const struct rte_device *start) One additional suggestion: might it be worthwhile also returning the bus for the device here, in an optional 4th parameter. This is, after all, a bus API. :-) /Bruce