From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by dpdk.org (Postfix) with ESMTP id A66A82C6A for ; Tue, 27 Jun 2017 16:08:38 +0200 (CEST) Received: from orsmga004.jf.intel.com ([10.7.209.38]) by fmsmga103.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 27 Jun 2017 07:08:20 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.39,399,1493708400"; d="scan'208";a="101929050" Received: from bricha3-mobl3.ger.corp.intel.com ([10.237.221.28]) by orsmga004.jf.intel.com with SMTP; 27 Jun 2017 07:08:18 -0700 Received: by (sSMTP sendmail emulation); Tue, 27 Jun 2017 15:08:17 +0100 Date: Tue, 27 Jun 2017 15:08:17 +0100 From: Bruce Richardson To: Gaetan Rivet Cc: dev@dpdk.org, Jan Blunck , Shreyansh Jain , Stephen Hemminger Message-ID: <20170627140816.GK104744@bricha3-MOBL3.ger.corp.intel.com> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Organization: Intel Research and =?iso-8859-1?Q?De=ACvel?= =?iso-8859-1?Q?opment?= Ireland Ltd. User-Agent: Mutt/1.8.1 (2017-04-11) Subject: Re: [dpdk-dev] [PATCH v5 00/12] bus: attach / detach API X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 27 Jun 2017 14:08:39 -0000 On Mon, Jun 26, 2017 at 02:21:58AM +0200, Gaetan Rivet wrote: > Following the work from Jan: > > This patchset introduces the attach / detach API to rte_bus. > The rte_device structure is used as the generic device representation. > > This API is implemented for the virtual bus. > The functions rte_eal_dev_attach and rte_eal_dev_detach are updated to > use this new interface. > Other than my opens on patch 12, this set all looks good to me. The other comments I made are mostly just suggestions. Hopefully next version can be merged. Regards, /Bruce